On Thu, 21 Nov 2024 20:46:47 GMT, Brent Christian wrote:
>> src/java.prefs/unix/classes/java/util/prefs/FileSystemPreferences.java line
>> 451:
>>
>>> 449: // Add shutdown hook to flush cached prefs on normal
>>> termination
>>> 450: Runtime.getRuntime().addShutdownHook(
>>> 45
On Mon, 18 Nov 2024 21:57:04 GMT, Stuart Marks wrote:
>> First cut at removal of Security Manager stuff from RMI.
>>
>> This covers just about every SM-related case in RMI, except for a bit of
>> package checking in MarshalInputStream. This will be handled separately.
>> It's covered by [JDK-8
On Fri, 15 Nov 2024 01:04:58 GMT, Shaojin Wen wrote:
>> The type of the Unsafe base offset constant is int, which may cause overflow
>> when adding int offsets, such as 8343925 (PR #22012). 8343984 (PR #22027)
>> fixes most of the offset overflows in JDK, but ArraysSupport and CRC32C are
>> st
On Fri, 22 Nov 2024 00:17:19 GMT, Brent Christian wrote:
>> Redone the benchmark. We actually want all targets to be reachable, and only
>> expose the Cleaner-side linked lists to the test. New performance data is
>> updated here:
>> https://github.com/openjdk/jdk/pull/22043#issuecomment-24709
On Fri, 15 Nov 2024 01:04:58 GMT, Shaojin Wen wrote:
>> The type of the Unsafe base offset constant is int, which may cause overflow
>> when adding int offsets, such as 8343925 (PR #22012). 8343984 (PR #22027)
>> fixes most of the offset overflows in JDK, but ArraysSupport and CRC32C are
>> st
On Tue, 19 Nov 2024 19:27:39 GMT, Stuart Marks wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> missed a few methods for specifying IllegalStateException
>
> src/java.base/share/classes/java/util/zip/Deflater.java l
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
On Tue, 19 Nov 2024 19:25:30 GMT, Stuart Marks wrote:
>> Hi Jai,
>>
>> I am not convinced we need to call this out specifically at the class level
>> given the classes implements AutoClosable and close indicates it calls end.
>> We will also want to add a Release Note which can help further
On Fri, 15 Nov 2024 01:05:10 GMT, ExE Boss wrote:
>> Doesn't this break any apps that use these offsets? Aren't these fields
>> part of the public API of Unsafe, so changing them requires a CSR?
>
> @dean-long
>> Doesn't this break any apps that use these offsets? Aren't these fields part
>> o
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
On 11/18/2024 1:17 PM, Chen Liang wrote:
Hi Eirik,
I think it might have been a legacy oversight; note that even
java.util.Arrays was just recently made final.
PS it would be a "small matter of programming" to write an annotation
processor to find the not subclassable public classes in the
On Thu, 21 Nov 2024 22:21:47 GMT, Phil Race wrote:
> Clean up permission checks in java.awt.Desktop class
> Also remove no longer needed exports from java.base to java.desktop
This pull request has now been integrated.
Changeset: 50c099d6
Author:Phil Race
URL:
https://git.openjdk.or
On Thu, 14 Nov 2024 13:28:57 GMT, Raffaello Giulietti
wrote:
>> Simplify tests.
>
> Raffaello Giulietti has updated the pull request with a new target base due
> to a merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request con
{
"emoji": "👍",
"version": 1
}
On Fri, 22 Nov 2024 00:01:32 GMT, Phil Race wrote:
>> Clean up permission checks in java.awt.Desktop class
>> Also remove no longer needed exports from java.base to java.desktop
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Thu, 21 Nov 2024 04:32:50 GMT, Taizo Kurashige wrote:
>> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
>> executed with "chcp 437". This ensures that the English message "No
>> Instance(s) Available." is output on localized windows platforms.
>>
>> I have refe
On Thu, 21 Nov 2024 19:29:07 GMT, Aleksey Shipilev wrote:
>> Ah (facepalms), I see, I thought I assigned it! Damn. Let me fix and
>> re-measure.
>
> Redone the benchmark. We actually want all targets to be reachable, and only
> expose the Cleaner-side linked lists to the test. New performance d
On Thu, 21 Nov 2024 23:58:05 GMT, Phil Race wrote:
> Did you mean to mention that in this PR ? Not sure how it came up here.
Yes, I saw that the `sun.security.action` is no longer exported to
`java.desktop`, and just wanted to check that it is no longer used in
there(even in comments).
--
On Thu, 21 Nov 2024 04:32:50 GMT, Taizo Kurashige wrote:
>> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
>> executed with "chcp 437". This ensures that the English message "No
>> Instance(s) Available." is output on localized windows platforms.
>>
>> I have refe
> Clean up permission checks in java.awt.Desktop class
> Also remove no longer needed exports from java.base to java.desktop
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8344799
-
Changes:
- all: https://git.openjdk.or
On Thu, 21 Nov 2024 23:46:14 GMT, Alexander Zvegintsev
wrote:
> There is a mention of the `GetPropertyAction` left in the comment:
>
> https://github.com/openjdk/jdk/blob/c199f5326b8dd41f33a12e5db7552331e0844601/src/java.desktop/share/classes/sun/awt/util/PerformanceLogger.java#L130
Did you me
On Thu, 21 Nov 2024 18:35:56 GMT, Alexey Semenyuk wrote:
> Switched jpackage unit tests to use JUnit5.
> Got rid of dependencies on the "hamcrest".
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22302#pullrequestreview-24530262
On Thu, 21 Nov 2024 22:21:47 GMT, Phil Race wrote:
> Clean up permission checks in java.awt.Desktop class
> Also remove no longer needed exports from java.base to java.desktop
There is a mention of the `GetPropertyAction` left in the comment:
https://github.com/openjdk/jdk/blob/c199f5326b8dd41f
On Thu, 21 Nov 2024 22:21:47 GMT, Phil Race wrote:
> Clean up permission checks in java.awt.Desktop class
> Also remove no longer needed exports from java.base to java.desktop
Marked as reviewed by azvegint (Reviewer).
src/java.desktop/share/classes/java/awt/Desktop.java line 409:
> 407:
On Thu, 21 Nov 2024 06:53:58 GMT, Justin Lu wrote:
>> Please review this PR and corresponding CSR which includes a wide range of
>> specification improvements for java.util.Locale. See the CSR for further
>> detail. Other changes/suggestions are welcomed to be included as part of
>> this chang
Clean up permission checks in java.awt.Desktop class
Also remove no longer needed exports from java.base to java.desktop
-
Commit messages:
- 8344799
Changes: https://git.openjdk.org/jdk/pull/22311/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22311&range=00
Issue: http
On Thu, 21 Nov 2024 04:32:50 GMT, Taizo Kurashige wrote:
>> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
>> executed with "chcp 437". This ensures that the English message "No
>> Instance(s) Available." is output on localized windows platforms.
>>
>> I have refe
On Thu, 21 Nov 2024 19:48:31 GMT, Alexey Semenyuk wrote:
>> Stop using internal AppImageFile, ApplicationLayout, and PackageFile classes
>> in the tests. Replace them with stubs.
>>
>> Stop referencing IOUtils class from XmlUtils and PathUtils classes.
>
> Alexey Semenyuk has updated the pull r
On Thu, 21 Nov 2024 07:07:39 GMT, Justin Lu wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Corrected the Unicode version in Grapheme.java
>
> src/java.base/share/classes/jdk/internal/util/regex/Grapheme.java line 38
On Wed, 20 Nov 2024 19:42:58 GMT, Roger Riggs wrote:
> Removed use of SecurityManager to check permissions.
> Relaxed defensive copying of byte arrays (due to lack of SM)
>
> Refresh of PR#22168 Including review comments made there.
This pull request has now been integrated.
Changeset: c199f53
On Tue, 19 Nov 2024 17:31:42 GMT, Naoto Sato wrote:
> Windows Java runtime has a mapping file /lib/tzmappings which maps Windows
> time zones to Java's time zones. The file is generated based on CLDR's
> windowsZones.xml, but in rare occasions, its update is out of sync with
> Windows updates.
On Wed, 20 Nov 2024 21:18:01 GMT, David Holmes wrote:
> In JDK 16 we deprecated the old signal and sigset signal-chaining interfaces
> under [JDK-8257572](https://bugs.openjdk.org/browse/JDK-8257572). The
> deprecation warning was written to stdout but all other warnings go to
> stderr. Having
On Fri, 15 Nov 2024 17:03:50 GMT, Aleksei Efimov wrote:
> This PR permanently disable remote code downloading in JNDI/LDAP and JNDI/RMI
> JDK providers, and contains the following changes:
> - The following two properties are removed:
> - `com.sun.jndi.ldap.object.trustURLCodebase`
> - `
> Remove usages of SecurityManager, doPrivildged, and AccessController from the
> java.prefs module.
Brent Christian has updated the pull request incrementally with one additional
commit since the last revision:
spacing changes
-
Changes:
- all: https://git.openjdk.org/jdk/pul
On Thu, 21 Nov 2024 15:05:44 GMT, Roger Riggs wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> indentation fixes
>
> src/java.prefs/unix/classes/java/util/prefs/FileSystemPreferences.java line
> 451:
>
>> 449:
> Updates the JDK to use the latest Unicode 16.0.0, which also updates the
> ICU4J along with it (8319992: Update ICU4J to Version 76.1). The
> corresponding CSR has already been approved.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
On Thu, 21 Nov 2024 06:50:42 GMT, Andrey Turbanov wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> indentation fixes
>
> src/java.prefs/unix/classes/java/util/prefs/FileSystemPreferences.java line
> 577:
>
>> 5
On Thu, 21 Nov 2024 19:48:31 GMT, Alexey Semenyuk wrote:
>> Stop using internal AppImageFile, ApplicationLayout, and PackageFile classes
>> in the tests. Replace them with stubs.
>>
>> Stop referencing IOUtils class from XmlUtils and PathUtils classes.
>
> Alexey Semenyuk has updated the pull r
On Thu, 21 Nov 2024 17:21:07 GMT, Andrew Haley wrote:
> Test bug.
>
> Another bug caused by the result of `Math.abs()` being negative. I also tried
> `floorMod()`, which would have been cleaner, but it increased the runtime of
> this extremely time-sensitive benchmark.
It is like computers ar
On Sun, 17 Nov 2024 14:52:06 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which removes exceptional control flow in
> `Boolean::getBoolean`, `Integer::getInteger` and `Long::getLong`.
>
> These methods are catching `IllegalArgumentException` and
> `NullPointerException`, thrown by `Syste
On Thu, 21 Nov 2024 14:03:37 GMT, Sean Mullan wrote:
>> Now that JEP 486 has been integrated, `java.security.jgss` and
>> `jdk.security.jgss` module dependencies on `System.getSecurityManager` and
>> `AccessController.doPrivileged*` can be removed.
>>
>> There is an undocumented property named
On Tue, 29 Oct 2024 18:01:55 GMT, Naoto Sato wrote:
> Updates the JDK to use the latest Unicode 16.0.0, which also updates the
> ICU4J along with it (8319992: Update ICU4J to Version 76.1). The
> corresponding CSR has already been approved.
Marked as reviewed by jlu (Committer).
src/java.base
On Thu, 21 Nov 2024 18:35:56 GMT, Alexey Semenyuk wrote:
> Switched jpackage unit tests to use JUnit5.
> Got rid of dependencies on the "hamcrest".
@sashamatveev ptal
-
PR Comment: https://git.openjdk.org/jdk/pull/22302#issuecomment-2492126711
> Stop using internal AppImageFile, ApplicationLayout, and PackageFile classes
> in the tests. Replace them with stubs.
>
> Stop referencing IOUtils class from XmlUtils and PathUtils classes.
Alexey Semenyuk has updated the pull request with a new target base due to a
merge or a rebase. The pul
On Thu, 21 Nov 2024 18:29:24 GMT, Aleksey Shipilev wrote:
>> Sorry for being dense, but where is a value being set to `CleanerGC.prev` ?
>
> Ah (facepalms), I see, I thought I assigned it! Damn. Let me fix and
> re-measure.
Redone the benchmark. We actually want all targets to be reachable, and
> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
> linked list with segmented list of arrays. Arrays are easy targets for GC.
> There are possible improvements here, most glaring is parallelism that is
> currently knee-capped by global synchronization. The synchroniz
On Thu, 7 Nov 2024 18:30:22 GMT, Vladimir Ivanov wrote:
>> The synchronization block may be substituted by the 'volatile' variable
>> smaller synchronization block.
>> It reduce the total blocking time for the specjvm2008::xml.validation
>> workload and improve the reported score.
>> Scores for
> Stop using internal AppImageFile, ApplicationLayout, and PackageFile classes
> in the tests. Replace them with stubs.
>
> Stop referencing IOUtils class from XmlUtils and PathUtils classes.
Alexey Semenyuk has updated the pull request incrementally with one additional
commit since the last re
On Thu, 21 Nov 2024 18:20:10 GMT, Brent Christian wrote:
>> No. Local `prev` variable goes out of scope when `setup()` finishes, making
>> the whole thing eligible for GC. We need something that keeps the list
>> alive, like a benchmark object field, which `CleanerGC.prev` is.
>
> Sorry for bei
Switched jpackage unit tests to use JUnit5.
Got rid of dependencies on the "hamcrest".
-
Commit messages:
- All tests pass
- Merge branch 'master' into JDK-8333571
- Copyright year update
- Run `bin/blessed-modifier-order.sh` script
- 8333571: Replace ExpectedException with asser
> Removed use of SecurityManager to check permissions.
> Relaxed defensive copying of byte arrays (due to lack of SM)
>
> Refresh of PR#22168 Including review comments made there.
Roger Riggs has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev e
On Sun, 29 Sep 2024 04:21:19 GMT, Jatin Bhateja wrote:
> This patch optimizes LongVector multiplication by inferring VPMUL[U]DQ
> instruction for following IR pallets.
>
>
>MulVL ( AndV SRC1, 0x) ( AndV SRC2, 0x)
>MulVL (URShiftVL SRC1 , 32) (URShif
On Thu, 21 Nov 2024 18:02:24 GMT, Aleksey Shipilev wrote:
>> Doesn't it get covered by the local `prev` in `setup()`? Should that be
>> removed?
>
> No. Local `prev` variable goes out of scope when `setup()` finishes, making
> the whole thing eligible for GC. We need something that keeps the li
On Thu, 21 Nov 2024 09:06:18 GMT, Jatin Bhateja wrote:
>> This patch optimizes LongVector multiplication by inferring VPMUL[U]DQ
>> instruction for following IR pallets.
>>
>>
>>MulVL ( AndV SRC1, 0x) ( AndV SRC2, 0x)
>>MulVL (URShiftVL SRC1 , 32) (
On Thu, 21 Nov 2024 03:28:29 GMT, Chen Liang wrote:
>> When core reflection was migrated to be implemented by Method Handles,
>> somehow, the method handles are not used for native methods, which are
>> generally linkable by method handles. This causes significant performance
>> regressions w
On Tue, 19 Nov 2024 15:58:30 GMT, Roger Riggs wrote:
> Unwrap calls using doPrivileged in jdk.unsupported sun.misc.Unsafe.
This pull request has now been integrated.
Changeset: 191b38e7
Author:Roger Riggs
URL:
https://git.openjdk.org/jdk/commit/191b38e71279151d0444bb38b659e880e6f8a1
On Sat, 16 Nov 2024 15:57:28 GMT, Attila Szegedi wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Apply review comments:
>> Retain public static constants for permission names to avoid source/binary
>> compatible
On Thu, 21 Nov 2024 17:53:00 GMT, Brent Christian wrote:
>> Yes. It maintains the root of a reachable linked list of `Target`-s.
>
> Doesn't it get covered by the local `prev` in `setup()`? Should that be
> removed?
No. Local `prev` variable goes out of scope when `setup()` finishes, making the
On Thu, 21 Nov 2024 07:11:00 GMT, Aleksey Shipilev wrote:
>> test/micro/org/openjdk/bench/java/lang/ref/CleanerGC.java line 45:
>>
>>> 43:
>>> 44: // Deliberately a linked list to avoid exposing external
>>> parallelism to GC.
>>> 45: Target prev;
>>
>> Is `CleanerGC.prev` used?
>
> Y
Test bug.
Another bug caused by the result of `Math.abs()` being negative. I also tried
`floorMod()`, which would have been cleaner, but it increased the runtime of
this extremely time-sensitive benchmark.
-
Commit messages:
- Fix integer overflow in abs()
Changes: https://git.op
On Thu, 31 Oct 2024 21:33:11 GMT, Vladimir Ivanov wrote:
> The synchronization block may be substituted by the 'volatile' variable
> smaller synchronization block.
> It reduce the total blocking time for the specjvm2008::xml.validation
> workload and improve the reported score.
> Scores for the
On Tue, 19 Nov 2024 20:43:25 GMT, Sean Mullan wrote:
> Now that JEP 486 has been integrated, `java.security.jgss` and
> `jdk.security.jgss` module dependencies on `System.getSecurityManager` and
> `AccessController.doPrivileged*` can be removed.
>
> There is an undocumented property named "sun
On Thu, 7 Nov 2024 18:30:22 GMT, Vladimir Ivanov wrote:
>> The synchronization block may be substituted by the 'volatile' variable
>> smaller synchronization block.
>> It reduce the total blocking time for the specjvm2008::xml.validation
>> workload and improve the reported score.
>> Scores for
On Thu, 21 Nov 2024 14:05:36 GMT, Per Minborg wrote:
>> This PR prevents sequence layout with padding to be used with the Linker.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix checking of padding layouts
I think the l
On Mon, 18 Nov 2024 17:06:03 GMT, Nizar Benalla wrote:
> Can I get a review for this test only change to the Since Checker?
>
> I drop the distinction between classes and interfaces when generating ids and
> use a generic name "class" to describe both, as to not consider classes that
> get con
On Thu, 21 Nov 2024 04:32:50 GMT, Taizo Kurashige wrote:
>> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
>> executed with "chcp 437". This ensures that the English message "No
>> Instance(s) Available." is output on localized windows platforms.
>>
>> I have refe
On Wed, 20 Nov 2024 18:20:35 GMT, jyxzwd wrote:
> Should I submit the modifications mentioned above to a commit, or should I
> conduct further testing first?
I think it would be good to add a test and add it to this PR with the updated
patch.
-
PR Comment: https://git.openjdk.org
On Wed, 20 Nov 2024 22:36:12 GMT, Brian Burkhalter wrote:
> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and
> #22132.
This pull request has now been integrated.
Changeset: 87be63f8
Author:Brian Burkhalter
URL:
https://git.openjdk.org/jdk/commit/87be63f85dbbf
> Improve the documentation for classfile instructions. Includes links to all
> opcodes, usage notes for instructions, and other various fixes.
>
> API Diff:
> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html
> Javadoc:
> https://cr.openjdk.org/~liach/javadoc/cf-inst
On Thu, 21 Nov 2024 01:45:56 GMT, Brian Burkhalter wrote:
>> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and
>> #22132.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8344659: System.getPropert
On Thu, 21 Nov 2024 01:45:56 GMT, Brian Burkhalter wrote:
>> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and
>> #22132.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8344659: System.getPropert
On Wed, 20 Nov 2024 22:43:44 GMT, Brent Christian wrote:
>> Remove usages of SecurityManager, doPrivildged, and AccessController from
>> the java.prefs module.
>
> Brent Christian has updated the pull request incrementally with one
> additional commit since the last revision:
>
> indentation
On Thu, 21 Nov 2024 14:08:33 GMT, Alan Bateman wrote:
> > Should I submit the modifications mentioned above to a commit, or should I
> > conduct further testing first?
>
> I think it would be good to add a test and add it to this PR with the updated
> patch.
ok,I will do this later.Thank you
Hi David,
I might respond to the Reddit thread later, I need to wrap some other tasks up
first.
Cheers,
√
Viktor Klang
Software Architect, Java Platform Group
Oracle
From: David Alayachew
Sent: Thursday, 21 November 2024 15:01
To: Viktor Klang
Cc: Rob Spoor ;
On Wed, 20 Nov 2024 19:15:28 GMT, Jorn Vernee wrote:
> Though, I'm still wondering if we don't want to reject that at the layout API
> level instead. i.e. have withByteAlignment throw an exception for
> PaddingLayout
I still don't understand why this wasn't done from the start, so I fully
app
> This PR prevents sequence layout with padding to be used with the Linker.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Fix checking of padding layouts
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21041/files
On Thu, 21 Nov 2024 06:49:10 GMT, Andrey Turbanov wrote:
>> Sean Mullan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix minor spacing issues.
>
> src/java.security.jgss/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java
>
> Now that JEP 486 has been integrated, `java.security.jgss` and
> `jdk.security.jgss` module dependencies on `System.getSecurityManager` and
> `AccessController.doPrivileged*` can be removed.
>
> There is an undocumented property named "sun.security.krb5.autodeducerealm"
> that can probably be
Thanks for the context Viktor. I think I got to see that breadth vs depth
threshold myself when work with danielaveryj on reddit. They explained
largely in the way that you did, and we experimented with batch sizes until
we found the cutoff point where things broke off.
But thanks again for the co
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote:
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of vario
On Thu, 21 Nov 2024 10:52:56 GMT, Adam Sotona wrote:
>> Chen Liang has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - typo
>> - More cleanup
>> - Remove a few confusions around bad modeling, some missing exceptions,
>> also the labell
On Tue, 19 Nov 2024 10:48:25 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to remove
>> SecurityManager related API usages from `URLClassLoader` and its related
>> `URLClassPath`? This addresses https://bugs.openjdk.org/browse/JDK-8344223.
>>
>> The `URLCl
On Wed, 20 Nov 2024 21:03:33 GMT, Roger Riggs wrote:
>> Removed use of SecurityManager to check permissions.
>> Relaxed defensive copying of byte arrays (due to lack of SM)
>>
>> Refresh of PR#22168 Including review comments made there.
>
> Roger Riggs has updated the pull request incrementally
On Wed, 20 Nov 2024 14:26:27 GMT, Severin Gehwolf wrote:
> Please review this simple patch which adds a new external system property
> `jdk.patched` when the runtime has been patched with the `--patch-module`
> switch. This is useful for two reasons: 1) it allows one to determine at
> run-time
On Wed, 20 Nov 2024 21:03:33 GMT, Roger Riggs wrote:
>> Removed use of SecurityManager to check permissions.
>> Relaxed defensive copying of byte arrays (due to lack of SM)
>>
>> Refresh of PR#22168 Including review comments made there.
>
> Roger Riggs has updated the pull request incrementally
On Wed, 20 Nov 2024 19:39:58 GMT, Daniel Fuchs wrote:
> This PR remove usage of SecurityManager, doPrivileges, etc... from
> `java.logging` and `java.base/jdk.internal.logger`
>
> Only notable hack - Logger.checkPermission() no longer checks permissions,
> but has been renamed into `ensureLogM
On Mon, 14 Oct 2024 20:58:43 GMT, Doug Lea wrote:
> This addresses tendencies in previous update to increase fencing, scanning,
> and signalling that can increase contention, and slow down performance
> especially on ARM platforms. It also uses more ARM-friendly constructions to
> reduce overh
On Thu, 21 Nov 2024 01:45:56 GMT, Brian Burkhalter wrote:
>> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and
>> #22132.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8344659: System.getPropert
On Thu, 21 Nov 2024 10:24:28 GMT, Daniel Fuchs wrote:
>> This PR remove usage of SecurityManager, doPrivileges, etc... from
>> `java.logging` and `java.base/jdk.internal.logger`
>>
>> Only notable hack - Logger.checkPermission() no longer checks permissions,
>> but has been renamed into `ensur
On Wed, 20 Nov 2024 23:03:43 GMT, Chen Liang wrote:
>> Improve the documentation for classfile instructions. Includes links to all
>> opcodes, usage notes for instructions, and other various fixes.
>>
>> API Diff:
>> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html
On Wed, 20 Nov 2024 23:03:43 GMT, Chen Liang wrote:
>> Improve the documentation for classfile instructions. Includes links to all
>> opcodes, usage notes for instructions, and other various fixes.
>>
>> API Diff:
>> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html
Text copied from PR draft since no one really goes through 2-month old
drafts ;)
For anyone wondering what's up with this PR, I have decided to take a
little break from coding itself and focus on the more fundamental part of
ranges. Most of the time I was thinking about the range lifecycle, how th
On Thu, 21 Nov 2024 07:46:46 GMT, Alan Bateman wrote:
> > Having now looked at #22037 which is what motivated this change, I now have
> > a more basic question.
> > The `--patch-module` option is an option for the `java` command. The code
> > changes in this current PR is proposing to set a sys
On Thu, 21 Nov 2024 06:50:48 GMT, Jaikiran Pai wrote:
> Hello Daniel, the changes look good to me. However, these changes appear to
> include both JEP 486 related updates as well as the JEP 491 (the reverting of
> ReentrantLock usage in favour of synchronized). Doing this clean up together
> I
On Wed, 20 Nov 2024 23:03:43 GMT, Chen Liang wrote:
>> Improve the documentation for classfile instructions. Includes links to all
>> opcodes, usage notes for instructions, and other various fixes.
>>
>> API Diff:
>> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html
On Thu, 21 Nov 2024 05:24:26 GMT, Jaikiran Pai wrote:
> in addition, should we explicitly set this system property to false (or
> remove the system property) when --patch-module isn't used? I think that
> would then prevent applications from passing -Djdk.patched=true when the
> runtime hasn't
On Wed, 20 Nov 2024 20:29:06 GMT, Roger Riggs wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review feedback
>
> src/java.base/share/classes/jdk/internal/logger/LoggerFinderLoader.java line
> 114:
>
>> 112:
>>
> This PR remove usage of SecurityManager, doPrivileges, etc... from
> `java.logging` and `java.base/jdk.internal.logger`
>
> Only notable hack - Logger.checkPermission() no longer checks permissions,
> but has been renamed into `ensureLogManagerInitialized()` in order to avoid
> disturbing the
On Thu, 21 Nov 2024 09:23:26 GMT, Alan Bateman wrote:
>> test/jdk/sun/misc/UnsafeMemoryAccessWarnings.java line 51:
>>
>>> 49: @ValueSource(strings = {
>>> 50: "allocateMemory+freeMemory",
>>> 51: "objectFieldOffset+putLong+getLong"
>>
>> Is the removal of `invokeCle
On Thu, 21 Nov 2024 09:05:23 GMT, Jatin Bhateja wrote:
>> Hi,
>>
>> Better to update the copyright year to 2024 for the following modified files:
>>
>>
>> src/hotspot/share/adlc/output_h.cpp
>> src/hotspot/share/opto/connode.cpp
>> src/hotspot/share/opto/connode.hpp
>> src/hotspot/share/opto/c
1 - 100 of 111 matches
Mail list logo
