On Wed, 20 Nov 2024 22:43:44 GMT, Brent Christian <bchri...@openjdk.org> wrote:
>> Remove usages of SecurityManager, doPrivildged, and AccessController from
>> the java.prefs module.
>
> Brent Christian has updated the pull request incrementally with one
> additional commit since the last revision:
>
> indentation fixes
src/java.prefs/unix/classes/java/util/prefs/FileSystemPreferences.java line 115:
> 113: userRootDir =
> 114: new File(System.getProperty("java.util.prefs.userRoot",
> 115: System.getProperty("user.home")), ".java/.userPrefs");
This expression would be more readable if the 2nd line was indented.
src/java.prefs/unix/classes/java/util/prefs/FileSystemPreferences.java line 451:
> 449: // Add shutdown hook to flush cached prefs on normal termination
> 450: Runtime.getRuntime().addShutdownHook(
> 451: new Thread(null, null, "Sync Timer Thread", 0, false) {
Future work, use a Virtual thread for this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22252#discussion_r1852307160
PR Review Comment: https://git.openjdk.org/jdk/pull/22252#discussion_r1852315551
