[GitHub] [pinot] codecov-commenter commented on pull request #11536: Update Segment Download URL Even When CRC Matches

2023-09-07 Thread via GitHub
codecov-commenter commented on PR #11536: URL: https://github.com/apache/pinot/pull/11536#issuecomment-1709587445 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11536?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] codecov-commenter commented on pull request #11537: Fix the issue with dict -> noDict (noDict -> dict) + Startree creation

2023-09-07 Thread via GitHub
codecov-commenter commented on PR #11537: URL: https://github.com/apache/pinot/pull/11537#issuecomment-1709610966 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11537?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] codecov-commenter commented on pull request #11538: DO NOT MERGE: Change notSupportedInV2 to fail in order to have the actual pass rate

2023-09-07 Thread via GitHub
codecov-commenter commented on PR #11538: URL: https://github.com/apache/pinot/pull/11538#issuecomment-1709653074 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11538?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[pinot] branch release-1.0.0-rc updated (b2eb24a9a7 -> 2ef214ad22)

2023-09-07 Thread saurabhd336
This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to branch release-1.0.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git from b2eb24a9a7 Fix return type for arrayLength (#11498) add 7ac65bb702 Updated License-binary for stax2

[pinot] 01/01: [maven-release-plugin] prepare release release-1.0.0-rc1

2023-09-07 Thread saurabhd336
This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a commit to branch release-1.0.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git commit 2ef214ad2200b6ac70e07870435320ef514d8123 Author: Saurabh Dubey AuthorDate: Thu Sep 7 16:40:27 2023 +0530

[pinot] annotated tag release-1.0.0-rc1 updated (2ef214ad22 -> 407dcf946d)

2023-09-07 Thread saurabhd336
This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to annotated tag release-1.0.0-rc1 in repository https://gitbox.apache.org/repos/asf/pinot.git *** WARNING: tag release-1.0.0-rc1 was modified! *** from 2ef214ad22 (commit) to 407dcf946d (t

[pinot] branch release-1.0.0-rc updated: [maven-release-plugin] prepare for next development iteration

2023-09-07 Thread saurabhd336
This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a commit to branch release-1.0.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/release-1.0.0-rc by this push: new 3f2a38c728 [maven-releas

[GitHub] [pinot] jadami10 commented on issue #11448: Realtime servers reporting lag for partitions they don't own after rebalancing w/o including consuming segments

2023-09-07 Thread via GitHub
jadami10 commented on issue #11448: URL: https://github.com/apache/pinot/issues/11448#issuecomment-1710235248 Doesn't calling `updateIngestionDelay` add the metric back for the partition group id? So if we were to remove it immediately in `onConsumingToOnline`, then we should see it come ba

[GitHub] [pinot] gortiz opened a new pull request, #11539: Add some catch-all prometheus rules

2023-09-07 Thread via GitHub
gortiz opened a new pull request, #11539: URL: https://github.com/apache/pinot/pull/11539 Before this PR, every time we added a new Pinot metric we needed to add it to the relative Prometheus file (`controller.yml`, `server.yml`, etc) and/or `pinot.yml` in order to be able to consume these

[GitHub] [pinot] ankitsultana commented on issue #11535: Segment Upload Does Not Update segment.download.uri if CRC Matches

2023-09-07 Thread via GitHub
ankitsultana commented on issue #11535: URL: https://github.com/apache/pinot/issues/11535#issuecomment-1710244044 Looks like one of the tests asserts that the segment download url should not change if CRC is the same. @Jackie-Jiang : do you have context about it? https://githu

[GitHub] [pinot] gortiz commented on a diff in pull request #11496: [POC] close channel on direct oom

2023-09-07 Thread via GitHub
gortiz commented on code in PR #11496: URL: https://github.com/apache/pinot/pull/11496#discussion_r1318700209 ## pinot-core/src/main/java/org/apache/pinot/core/transport/DataTableHandler.java: ## @@ -83,5 +98,12 @@ protected void channelRead0(ChannelHandlerContext ctx, ByteBuf

[GitHub] [pinot] jvenant closed issue #11525: Broker fails to start because of reflexion on methods using Boolean type

2023-09-07 Thread via GitHub
jvenant closed issue #11525: Broker fails to start because of reflexion on methods using Boolean type URL: https://github.com/apache/pinot/issues/11525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [pinot] jvenant commented on issue #11525: Broker fails to start because of reflexion on methods using Boolean type

2023-09-07 Thread via GitHub
jvenant commented on issue #11525: URL: https://github.com/apache/pinot/issues/11525#issuecomment-1710256543 I found the root cause. I have a pinot plugin depending on an older version of pinot. This plugin build a fat jar using the shade maven plugin. Pinot packages were not exclude f

[GitHub] [pinot] rajagopr opened a new pull request, #11540: Keep header parsing logic the same in defailt CSVRecordReader and the…

2023-09-07 Thread via GitHub
rajagopr opened a new pull request, #11540: URL: https://github.com/apache/pinot/pull/11540 ## Description This is a follow-up to the PR – (11487](https://github.com/apache/pinot/pull/11487/files) The following is addressed in the change. * Update commons-csv library version

[GitHub] [pinot] JeffBolle commented on issue #11530: Protobuf Stream Config validationg assumes Kafka streams

2023-09-07 Thread via GitHub
JeffBolle commented on issue #11530: URL: https://github.com/apache/pinot/issues/11530#issuecomment-1710350230 Maybe...I'm working another issue with missing metadata that is more important in my environment. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pinot] JeffBolle opened a new issue, #11541: Pulsar Stream Metadata no longer being written to Pinot

2023-09-07 Thread via GitHub
JeffBolle opened a new issue, #11541: URL: https://github.com/apache/pinot/issues/11541 The Pulsar metadata is being produced by the Pulsar stream ingestion plugin, but it isn't being written to Pinot because of a missing method implementation in the PulsarMessageBatch which is causing a de

svn commit: r63838 - /dev/pinot/apache-pinot-1.0.0-rc1/

2023-09-07 Thread saurabhd336
Author: saurabhd336 Date: Thu Sep 7 15:42:27 2023 New Revision: 63838 Log: Update apache-pinot-1.0.0-rc1 Added: dev/pinot/apache-pinot-1.0.0-rc1/ dev/pinot/apache-pinot-1.0.0-rc1/apache-pinot-1.0.0-bin.tar.gz (with props) dev/pinot/apache-pinot-1.0.0-rc1/apache-pinot-1.0.0-bin.tar

[GitHub] [pinot] codecov-commenter commented on pull request #11540: Keep header parsing logic the same in default CSVRecordReader and the line iterator

2023-09-07 Thread via GitHub
codecov-commenter commented on PR #11540: URL: https://github.com/apache/pinot/pull/11540#issuecomment-1710389996 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11540?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] JeffBolle opened a new pull request, #11542: [bugfix] Pulsar Stream metadata missing

2023-09-07 Thread via GitHub
JeffBolle opened a new pull request, #11542: URL: https://github.com/apache/pinot/pull/11542 Pulsar stream metadata was not being written to Pinot records due to a missing implementation in the PulsarMessageBatch class. `bugfix` @navina -- This is an automated message from the Apac

[GitHub] [pinot-site] xiangfu0 commented on pull request #83: Update to the Features list, refresh of dependencies in package.json

2023-09-07 Thread via GitHub
xiangfu0 commented on PR #83: URL: https://github.com/apache/pinot-site/pull/83#issuecomment-1710394933 Please fix the CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pinot] JeffBolle commented on issue #11541: Pulsar Stream Metadata not being written to Pinot

2023-09-07 Thread via GitHub
JeffBolle commented on issue #11541: URL: https://github.com/apache/pinot/issues/11541#issuecomment-1710395195 The PR is here: https://github.com/apache/pinot/pull/11542 #11542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #11537: Fix the issue with dict -> noDict (noDict -> dict) + Startree creation

2023-09-07 Thread via GitHub
vvivekiyer commented on code in PR #11537: URL: https://github.com/apache/pinot/pull/11537#discussion_r1318808752 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessor.java: ## @@ -131,13 +130,19 @@ public void process()

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #11537: Fix the issue with dict -> noDict (noDict -> dict) + Startree creation

2023-09-07 Thread via GitHub
vvivekiyer commented on code in PR #11537: URL: https://github.com/apache/pinot/pull/11537#discussion_r1318808752 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessor.java: ## @@ -131,13 +130,19 @@ public void process()

[GitHub] [pinot-site] tlberglund commented on pull request #83: Update to the Features list, refresh of dependencies in package.json

2023-09-07 Thread via GitHub
tlberglund commented on PR #83: URL: https://github.com/apache/pinot-site/pull/83#issuecomment-1710422050 > Please fix the CI Ah yes. We'll get on that. Sorry I missed it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pinot] codecov-commenter commented on pull request #11542: [bugfix] Pulsar Stream metadata missing

2023-09-07 Thread via GitHub
codecov-commenter commented on PR #11542: URL: https://github.com/apache/pinot/pull/11542#issuecomment-1710485079 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11542?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] chenboat closed issue #11535: Segment Upload Does Not Update segment.download.uri if CRC Matches

2023-09-07 Thread via GitHub
chenboat closed issue #11535: Segment Upload Does Not Update segment.download.uri if CRC Matches URL: https://github.com/apache/pinot/issues/11535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pinot] chenboat merged pull request #11536: Update Segment Download URL Even When CRC Matches

2023-09-07 Thread via GitHub
chenboat merged PR #11536: URL: https://github.com/apache/pinot/pull/11536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[pinot] branch master updated: Update Segment Download URL Even When CRC Matches (#11536)

2023-09-07 Thread tingchen
This is an automated email from the ASF dual-hosted git repository. tingchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 017e813213 Update Segment Download URL Even Whe

[GitHub] [pinot] snleee commented on a diff in pull request #11537: Fix the issue with dict -> noDict (noDict -> dict) + Startree creation

2023-09-07 Thread via GitHub
snleee commented on code in PR #11537: URL: https://github.com/apache/pinot/pull/11537#discussion_r1318893468 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessor.java: ## @@ -131,13 +130,19 @@ public void process()

[GitHub] [pinot] navina commented on issue #11530: Protobuf Stream Config validationg assumes Kafka streams

2023-09-07 Thread via GitHub
navina commented on issue #11530: URL: https://github.com/apache/pinot/issues/11530#issuecomment-1710550794 @xiangfu0 I can create a PR for this. I think @JeffBolle is busy fixing the pulsar connector here - https://github.com/apache/pinot/pull/11542#issuecomment-1710485079 -- This is a

[GitHub] [pinot] jugomezv opened a new issue, #11543: Queries that involve string timestamps do not work properly unless the string is singled quoted

2023-09-07 Thread via GitHub
jugomezv opened a new issue, #11543: URL: https://github.com/apache/pinot/issues/11543 I have a table with the following time column schema: ``` "dateTimeFieldSpecs": [ { "dataType": "STRING", "format": "1:DAYS:SIMPLE_DATE_FORMAT:-MM-dd-HH", "

[GitHub] [pinot] jugomezv commented on issue #11543: Queries that involve string timestamps do not work properly unless the string is singled quoted

2023-09-07 Thread via GitHub
jugomezv commented on issue #11543: URL: https://github.com/apache/pinot/issues/11543#issuecomment-1710643531 Further more using a single boundary does yield a result but not the proper one: ``` "SELECT \"time_stamp\", avg(\"fifteen_minutes_freshness\") AS \"fifteen_minutes_freshness:

[GitHub] [pinot] jugomezv commented on issue #11543: Queries that involve string timestamps do not work properly unless the string is singled quoted

2023-09-07 Thread via GitHub
jugomezv commented on issue #11543: URL: https://github.com/apache/pinot/issues/11543#issuecomment-1710649308 This is not a big deal for manual queries but we do have some tooling that autogenerates queries like these that do work well in other SQL interface dbs but they produce the wrong o

[GitHub] [pinot] navina opened a new pull request, #11544: Use streamType for parsing and validating protobuf decoder config

2023-09-07 Thread via GitHub
navina opened a new pull request, #11544: URL: https://github.com/apache/pinot/pull/11544 ## What does this PR do Fixes https://github.com/apache/pinot/issues/11530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [pinot] navina commented on pull request #11544: Use streamType for parsing and validating protobuf decoder config

2023-09-07 Thread via GitHub
navina commented on PR #11544: URL: https://github.com/apache/pinot/pull/11544#issuecomment-1710687117 Label: `bugfix` @xiangfu0 / @Jackie-Jiang : review pls! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[pinot] branch master updated: Fix the issue with dict -> noDict (noDict -> dict) + Startree creation (#11537)

2023-09-07 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 6208e7cb46 Fix the issue with dict -> noDict (noDi

[GitHub] [pinot] snleee commented on a diff in pull request #11537: Fix the issue with dict -> noDict (noDict -> dict) + Startree creation

2023-09-07 Thread via GitHub
snleee commented on code in PR #11537: URL: https://github.com/apache/pinot/pull/11537#discussion_r1319060054 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessor.java: ## @@ -131,13 +130,19 @@ public void process()

[GitHub] [pinot] snleee merged pull request #11537: Fix the issue with dict -> noDict (noDict -> dict) + Startree creation

2023-09-07 Thread via GitHub
snleee merged PR #11537: URL: https://github.com/apache/pinot/pull/11537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #11496: [POC] close channel on direct oom

2023-09-07 Thread via GitHub
jasperjiaguo commented on code in PR #11496: URL: https://github.com/apache/pinot/pull/11496#discussion_r1319073457 ## pinot-core/src/main/java/org/apache/pinot/core/transport/DataTableHandler.java: ## @@ -83,5 +98,12 @@ protected void channelRead0(ChannelHandlerContext ctx, By

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #11496: [POC] close channel on direct oom

2023-09-07 Thread via GitHub
jasperjiaguo commented on code in PR #11496: URL: https://github.com/apache/pinot/pull/11496#discussion_r1319073457 ## pinot-core/src/main/java/org/apache/pinot/core/transport/DataTableHandler.java: ## @@ -83,5 +98,12 @@ protected void channelRead0(ChannelHandlerContext ctx, By

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #11496: [POC] close channel on direct oom

2023-09-07 Thread via GitHub
jasperjiaguo commented on code in PR #11496: URL: https://github.com/apache/pinot/pull/11496#discussion_r1319074131 ## pinot-core/src/main/java/org/apache/pinot/core/transport/DataTableHandler.java: ## @@ -83,5 +98,12 @@ protected void channelRead0(ChannelHandlerContext ctx, By

[GitHub] [pinot-site] tlberglund commented on pull request #83: Update to the Features list, refresh of dependencies in package.json

2023-09-07 Thread via GitHub
tlberglund commented on PR #83: URL: https://github.com/apache/pinot-site/pull/83#issuecomment-1710731651 @xiangfu0, do you have an email from [November, 2021 from Algolia/DocSearch](https://docusaurus.io/blog/2021/11/21/algolia-docsearch-migration) with a new appId and apiKey? The build is

[GitHub] [pinot] codecov-commenter commented on pull request #11544: Use streamType for parsing and validating protobuf decoder config

2023-09-07 Thread via GitHub
codecov-commenter commented on PR #11544: URL: https://github.com/apache/pinot/pull/11544#issuecomment-1710751231 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11544?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] navina commented on a diff in pull request #11542: [bugfix] Pulsar Stream metadata missing

2023-09-07 Thread via GitHub
navina commented on code in PR #11542: URL: https://github.com/apache/pinot/pull/11542#discussion_r1319110187 ## pinot-spi/src/main/java/org/apache/pinot/spi/stream/MessageBatch.java: ## @@ -83,9 +83,7 @@ public LegacyStreamMessage(byte[] value, StreamMessageMetadata metadata)

[GitHub] [pinot] ege-st commented on a diff in pull request #11496: [POC] close channel on direct oom

2023-09-07 Thread via GitHub
ege-st commented on code in PR #11496: URL: https://github.com/apache/pinot/pull/11496#discussion_r1319157318 ## pinot-core/src/main/java/org/apache/pinot/core/transport/DataTableHandler.java: ## @@ -83,5 +98,12 @@ protected void channelRead0(ChannelHandlerContext ctx, ByteBuf

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #11496: [POC] close channel on direct oom

2023-09-07 Thread via GitHub
jasperjiaguo commented on code in PR #11496: URL: https://github.com/apache/pinot/pull/11496#discussion_r1319202311 ## pinot-core/src/main/java/org/apache/pinot/core/transport/DataTableHandler.java: ## @@ -83,5 +98,12 @@ protected void channelRead0(ChannelHandlerContext ctx, By

[GitHub] [pinot] zhtaoxiang opened a new pull request, #11545: [multistage] (improve #11518) disable calcite float to double cast

2023-09-07 Thread via GitHub
zhtaoxiang opened a new pull request, #11545: URL: https://github.com/apache/pinot/pull/11545 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [pinot] ege-st commented on a diff in pull request #11496: [POC] close channel on direct oom

2023-09-07 Thread via GitHub
ege-st commented on code in PR #11496: URL: https://github.com/apache/pinot/pull/11496#discussion_r1319219386 ## pinot-core/src/main/java/org/apache/pinot/core/transport/DataTableHandler.java: ## @@ -83,5 +98,12 @@ protected void channelRead0(ChannelHandlerContext ctx, ByteBuf

[GitHub] [pinot] codecov-commenter commented on pull request #11545: [multistage] (improve #11518) disable calcite float to double cast

2023-09-07 Thread via GitHub
codecov-commenter commented on PR #11545: URL: https://github.com/apache/pinot/pull/11545#issuecomment-1710924527 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11545?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] shenyu0127 opened a new pull request, #11546: Fix AND and OR transform functions.

2023-09-07 Thread via GitHub
shenyu0127 opened a new pull request, #11546: URL: https://github.com/apache/pinot/pull/11546 The correct behavior is this: https://prestodb.io/docs/current/functions/logical.html. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [pinot] shenyu0127 opened a new pull request, #11547: Add Boolean assertion transform functions.

2023-09-07 Thread via GitHub
shenyu0127 opened a new pull request, #11547: URL: https://github.com/apache/pinot/pull/11547 This PR adds the following transform functions: - IS TRUE - IS NOT TRUE - IS FALSE - IS NOT FALSE -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pinot] codecov-commenter commented on pull request #11546: Fix AND and OR transform functions.

2023-09-07 Thread via GitHub
codecov-commenter commented on PR #11546: URL: https://github.com/apache/pinot/pull/11546#issuecomment-1711004174 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] codecov-commenter commented on pull request #11547: Add Boolean assertion transform functions.

2023-09-07 Thread via GitHub
codecov-commenter commented on PR #11547: URL: https://github.com/apache/pinot/pull/11547#issuecomment-1711006092 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11547?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[pinot] annotated tag release-1.0.0-rc1 deleted (was 407dcf946d)

2023-09-07 Thread saurabhd336
This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to annotated tag release-1.0.0-rc1 in repository https://gitbox.apache.org/repos/asf/pinot.git *** WARNING: tag release-1.0.0-rc1 was deleted! *** tag was 407dcf946d The revisions that were on t

[pinot] branch release-1.0.0-rc updated (3f2a38c728 -> be496bc763)

2023-09-07 Thread saurabhd336
This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to branch release-1.0.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git discard 3f2a38c728 [maven-release-plugin] prepare for next development iteration discard 2ef214ad22 [maven-rel

[GitHub] [pinot] shenyu0127 opened a new issue, #11548: ScalarTransformFunctionWrapper NULL support

2023-09-07 Thread via GitHub
shenyu0127 opened a new issue, #11548: URL: https://github.com/apache/pinot/issues/11548 Currently the `ScalarTransformFunctionWrapper::getNullBitmap` returns NULL if any of the arguments is NULL. This is not true for many functions. E.g. `caseWhen` scalar function. This is a gap. -- Thi

[pinot] annotated tag releaase-1.0.0-rc1 updated (7fca4dba33 -> 57dfaab344)

2023-09-07 Thread saurabhd336
This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to annotated tag releaase-1.0.0-rc1 in repository https://gitbox.apache.org/repos/asf/pinot.git *** WARNING: tag releaase-1.0.0-rc1 was modified! *** from 7fca4dba33 (commit) to 57dfaab344

[pinot] branch release-1.0.0-rc updated: [maven-release-plugin] prepare for next development iteration

2023-09-07 Thread saurabhd336
This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a commit to branch release-1.0.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/release-1.0.0-rc by this push: new 64c8edeeb1 [maven-releas

[pinot] branch release-1.0.0-rc updated: [maven-release-plugin] prepare release releaase-1.0.0-rc1

2023-09-07 Thread saurabhd336
This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a commit to branch release-1.0.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/release-1.0.0-rc by this push: new 7fca4dba33 [maven-releas

[pinot] branch release-1.0.0-rc updated (64c8edeeb1 -> be496bc763)

2023-09-07 Thread saurabhd336
This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to branch release-1.0.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git discard 64c8edeeb1 [maven-release-plugin] prepare for next development iteration omit 7fca4dba33 [maven-rel

[GitHub] [pinot] gortiz commented on a diff in pull request #11546: Fix AND and OR transform functions.

2023-09-07 Thread via GitHub
gortiz commented on code in PR #11546: URL: https://github.com/apache/pinot/pull/11546#discussion_r1319438573 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/AndOperatorTransformFunction.java: ## @@ -45,4 +48,37 @@ int getLogicalFuncResult(int left,

[GitHub] [pinot] gortiz commented on a diff in pull request #11546: Fix AND and OR transform functions.

2023-09-07 Thread via GitHub
gortiz commented on code in PR #11546: URL: https://github.com/apache/pinot/pull/11546#discussion_r1319442926 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/AndOperatorTransformFunction.java: ## @@ -45,4 +48,37 @@ int getLogicalFuncResult(int left,

[GitHub] [pinot] gortiz commented on a diff in pull request #11546: Fix AND and OR transform functions.

2023-09-07 Thread via GitHub
gortiz commented on code in PR #11546: URL: https://github.com/apache/pinot/pull/11546#discussion_r1319444154 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/AndOperatorTransformFunction.java: ## @@ -45,4 +48,37 @@ int getLogicalFuncResult(int left,

[GitHub] [pinot] shenyu0127 commented on a diff in pull request #11546: Fix AND and OR transform functions.

2023-09-07 Thread via GitHub
shenyu0127 commented on code in PR #11546: URL: https://github.com/apache/pinot/pull/11546#discussion_r1319445158 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/AndOperatorTransformFunction.java: ## @@ -45,4 +48,37 @@ int getLogicalFuncResult(int l

[GitHub] [pinot] gortiz commented on a diff in pull request #11546: Fix AND and OR transform functions.

2023-09-07 Thread via GitHub
gortiz commented on code in PR #11546: URL: https://github.com/apache/pinot/pull/11546#discussion_r1319445980 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/AndOperatorTransformFunction.java: ## @@ -45,4 +48,37 @@ int getLogicalFuncResult(int left,

[GitHub] [pinot] gortiz commented on a diff in pull request #11546: Fix AND and OR transform functions.

2023-09-07 Thread via GitHub
gortiz commented on code in PR #11546: URL: https://github.com/apache/pinot/pull/11546#discussion_r1319445980 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/AndOperatorTransformFunction.java: ## @@ -45,4 +48,37 @@ int getLogicalFuncResult(int left,

[GitHub] [pinot] gortiz commented on a diff in pull request #11546: Fix AND and OR transform functions.

2023-09-07 Thread via GitHub
gortiz commented on code in PR #11546: URL: https://github.com/apache/pinot/pull/11546#discussion_r1319447515 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/AndOperatorTransformFunction.java: ## @@ -45,4 +48,37 @@ int getLogicalFuncResult(int left,