gortiz opened a new pull request, #11539: URL: https://github.com/apache/pinot/pull/11539
Before this PR, every time we added a new Pinot metric we needed to add it to the relative Prometheus file (`controller.yml`, `server.yml`, etc) and/or `pinot.yml` in order to be able to consume these metrics from Prometheus. Obviously, sometimes we forgot about that and the metric was not stored in Prometheus. This PR includes a bunch of catch-all rules that will match most common Pinot patterns. It also generalizes the newly added version pattern and add it to `pinot.yml` By using the new `pinot.yml` file in a very simple server, I've found all these new metrics in Prometheus: ``` pinot_server_grpcBytesReceived_<...> pinot_server_grpcBytesSent_<...> pinot_server_grpcQueries_<...> pinot_server_heapCriticalLevelExceeded_<...> pinot_server_heapPanicLevelExceeded_<...> pinot_server_indexingFailures_<...> pinot_server_jvmHeapUsedBytes_Value pinot_server_noTableAccess_<...> pinot_server_queriesDisabled_<...> pinot_server_queriesKilled_<...> pinot_server_readinessCheckBadCalls_<...> pinot_server_readinessCheckOkCalls_<...> pinot_server_version_Value pinot_server_version ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
