dario-liberman commented on PR #10867:
URL: https://github.com/apache/pinot/pull/10867#issuecomment-1605699119
I am working on other aggregation strategies that do not require
partitioning -
https://github.com/apache/pinot/compare/master...dario-liberman:pinot:funnel-strategies
--
This i
kishoreg commented on PR #10867:
URL: https://github.com/apache/pinot/pull/10867#issuecomment-1605717762
> > In order for this aggregation to work, does it require all the data to
be partitioned by segments (i.e. all users show up in the same segment, and no
user can be shared across segmen
kishoreg commented on PR #10867:
URL: https://github.com/apache/pinot/pull/10867#issuecomment-1605723605
I also noticed that this argument is taking steps and correlate column
arguments as another function but we did not add any transform functions. This
is violating the principle that argu
dario-liberman commented on PR #10867:
URL: https://github.com/apache/pinot/pull/10867#issuecomment-1605753936
> > > In order for this aggregation to work, does it require all the data to
be partitioned by segments (i.e. all users show up in the same segment, and no
user can be shared acros
dario-liberman commented on PR #10867:
URL: https://github.com/apache/pinot/pull/10867#issuecomment-1605755373
> I also noticed that this argument is taking steps and correlate column
arguments as another function but we did not add any transform functions. This
is violating the principle t
ankitsultana commented on PR #10937:
URL: https://github.com/apache/pinot/pull/10937#issuecomment-1605850109
> @npuppala111 @ankitsultana the instance tag can be retrieved from Pinot
controller using the controller's instance api. The tag is stored in Zookeeper
and the Pinot controller is u
ankitsultana commented on code in PR #10971:
URL: https://github.com/apache/pinot/pull/10971#discussion_r1241033631
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java:
##
@@ -189,73 +191,60 @@ int submit(long requestId, Dispatchable
ankitsultana commented on code in PR #10971:
URL: https://github.com/apache/pinot/pull/10971#discussion_r1241037225
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java:
##
@@ -85,15 +87,15 @@ public QueryDispatcher() {
}
publ
