dario-liberman commented on PR #10867: URL: https://github.com/apache/pinot/pull/10867#issuecomment-1605755373
> I also noticed that this argument is taking steps and correlate column arguments as another function but we did not add any transform functions. This is violating the principle that arguments should be either literal, identifier or another function. > > syntactical steps is a function but we are not handling it that way.. this probably works today but it will probably fail when we move to V2 and enforce stricter constraints. Can we please fix this soon cc @dario-liberman @chenboat I can work on this, the two solutions I can think of is to either declare the STEPS and other sub-functions as simply retuning their parameters (eg. an array), or do without them altogether. I liked the syntax of using sub-functions as a means to have named parameters in gapfill, so I replicated it here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
