[GitHub] [pinot] gortiz commented on a diff in pull request #10757: Improvements on the utility to convert table config to updated format

gortiz commented on code in PR #10757: URL: https://github.com/apache/pinot/pull/10757#discussion_r1192127114 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/H3IndexResolution.java: ## @@ -73,4 +74,21 @@ public List getResolutions() { public int g

[GitHub] [pinot] ankitsultana commented on a diff in pull request #10752: Minor Pinot Deepstore Upload Retry Task Improvements

ankitsultana commented on code in PR #10752: URL: https://github.com/apache/pinot/pull/10752#discussion_r1192543509 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1438,9 +1441,13 @@ public void upload

[GitHub] [pinot] INNOCENT-BOY opened a new pull request, #10759: bug fix: add @JsonProperty for variable _assignmentStrategy in SegmentAssignmentConfig

INNOCENT-BOY opened a new pull request, #10759: URL: https://github.com/apache/pinot/pull/10759 When we tried to add segmentAssignmentConfigMap to tableConfig, we found that property segmentAssignmentStrategy can't be parsed. After debugging, we found the key ''segmentAssignmentStrategy'' w

[GitHub] [pinot] codecov-commenter commented on pull request #10759: bug fix: add @JsonProperty for variable _assignmentStrategy in SegmentAssignmentConfig

codecov-commenter commented on PR #10759: URL: https://github.com/apache/pinot/pull/10759#issuecomment-1546046017 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10759?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache

[GitHub] [pinot] walterddr opened a new pull request, #10760: [multistage] follow up leaf scheduler

walterddr opened a new pull request, #10760: URL: https://github.com/apache/pinot/pull/10760 this is a follow up on comments on #10711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pinot] walterddr commented on a diff in pull request #10760: [multistage] follow up leaf scheduler

walterddr commented on code in PR #10760: URL: https://github.com/apache/pinot/pull/10760#discussion_r1192630013 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxSendOperator.java: ## @@ -125,24 +126,25 @@ public String toExplainString() {

[GitHub] [pinot] walterddr commented on a diff in pull request #10760: [multistage] follow up leaf scheduler

walterddr commented on code in PR #10760: URL: https://github.com/apache/pinot/pull/10760#discussion_r1192630337 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/MailboxSendOperatorTest.java: ## @@ -150,6 +150,12 @@ public void shouldSendDataBlock()

[GitHub] [pinot] walterddr opened a new pull request, #10761: [multistage] sending exchange service

walterddr opened a new pull request, #10761: URL: https://github.com/apache/pinot/pull/10761 this is to address the sending mailbox blocking the entire opChain without yielding problem. depend on #10760 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10760: [multistage] follow up leaf scheduler

xiangfu0 commented on code in PR #10760: URL: https://github.com/apache/pinot/pull/10760#discussion_r1192695138 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxSendOperator.java: ## @@ -128,21 +129,21 @@ protected TransferableBlock getNextBloc

[GitHub] [pinot] codecov-commenter commented on pull request #10760: [multistage] follow up leaf scheduler

codecov-commenter commented on PR #10760: URL: https://github.com/apache/pinot/pull/10760#issuecomment-1546148983 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10760?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache

[GitHub] [pinot] xiangfu0 merged pull request #10594: [feature] [null support # 8] Support null in all null related transform functions

xiangfu0 merged PR #10594: URL: https://github.com/apache/pinot/pull/10594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[pinot] branch master updated: [feature] [null support # 8] Support null in all null related transform functions (#10594)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 9e1160272a [feature] [null support # 8] Support

[GitHub] [pinot] 61yao commented on a diff in pull request #10598: [feature] [null support # 9] Support null in time related transform functions.

61yao commented on code in PR #10598: URL: https://github.com/apache/pinot/pull/10598#discussion_r1192746673 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/DateTimeConversionTransformFunction.java: ## @@ -106,8 +107,8 @@ public void init(List argum

[GitHub] [pinot] walterddr commented on a diff in pull request #10761: [multistage] sending exchange service

walterddr commented on code in PR #10761: URL: https://github.com/apache/pinot/pull/10761#discussion_r1192826109 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/exchange/ExchangeService.java: ## @@ -0,0 +1,60 @@ +package org.apache.pinot.query.runtim

[GitHub] [pinot] jasperjiaguo opened a new issue, #10762: RowDataBlock throws exceptions during ser/de of MV byte and empty MV types

jasperjiaguo opened a new issue, #10762: URL: https://github.com/apache/pinot/issues/10762 see https://github.com/apache/pinot/blob/9e1160272aec88591d9e768d15104b72521b2ffb/pinot-core/src/test/java/org/apache/pinot/core/common/datablock/DataBlockTest.java#L104 -- This is an automated mess

[GitHub] [pinot] abhioncbr opened a new pull request, #10763: [multistage]: Supporting Json data type & better error messages

abhioncbr opened a new pull request, #10763: URL: https://github.com/apache/pinot/pull/10763 - handling the `json` data type in a multistage query engine. as per the [comment](https://github.com/apache/pinot/issues/10205#issuecomment-1543278577) - returning the meaningful error msg for u

[GitHub] [pinot] kishoreg commented on pull request #10763: [multistage]: Supporting Json data type & better error messages

kishoreg commented on PR #10763: URL: https://github.com/apache/pinot/pull/10763#issuecomment-1546516472 LGTM.. lets add a test case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [pinot] codecov-commenter commented on pull request #10763: [multistage]: Supporting Json data type & better error messages

codecov-commenter commented on PR #10763: URL: https://github.com/apache/pinot/pull/10763#issuecomment-1546522327 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10763?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R