Jackie-Jiang merged PR #13525:
URL: https://github.com/apache/pinot/pull/13525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on code in PR #13525:
URL: https://github.com/apache/pinot/pull/13525#discussion_r1668954123
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/VectorTest.java:
##
@@ -331,7 +331,9 @@ private float[] createZeroVector(int vec
abhioncbr closed pull request #13525: Remove deprecated commons-lang3
RandomUtils class usage.
URL: https://github.com/apache/pinot/pull/13525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
Jackie-Jiang commented on PR #13525:
URL: https://github.com/apache/pinot/pull/13525#issuecomment-2204764948
We rarely use random in production code (especially in high perf code), so
I'd suggest just using `Random` for now and revisit if we need high performance
random generator
--
This
abhioncbr commented on PR #13525:
URL: https://github.com/apache/pinot/pull/13525#issuecomment-2204725683
> Seems all the usages are within the tests, and this library is not that
commonly used (only [71
usages](https://mvnrepository.com/artifact/org.apache.commons/commons-rng-simple)).
I'
Jackie-Jiang commented on code in PR #13525:
URL: https://github.com/apache/pinot/pull/13525#discussion_r1663281844
##
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/relocation/SegmentRelocatorTest.java:
##
@@ -126,7 +127,7 @@ public void testRebalanceTabl
