abhioncbr commented on PR #13525: URL: https://github.com/apache/pinot/pull/13525#issuecomment-2204725683
> Seems all the usages are within the tests, and this library is not that commonly used (only [71 usages](https://mvnrepository.com/artifact/org.apache.commons/commons-rng-simple)). I'd suggest just using regular java `Random()` for readability I agree that this library isn't widely used and that releases are minimal, but if we are looking for performance gains, we can use it. Here are the stats related to [performance](https://commons.apache.org/proper/commons-rng/userguide/rng.html#a4._Performance). Based on these stats, do you think we will try to replace `java.util.Random` usage with this in our entire codebase? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
