Re: [PR] Deterministic group by without order by [pinot]

Jackie-Jiang commented on code in PR #15844: URL: https://github.com/apache/pinot/pull/15844#discussion_r2103609302 ## pinot-core/src/main/java/org/apache/pinot/core/data/table/Key.java: ## @@ -63,4 +63,14 @@ public int hashCode() { public String toString() { return Arra

Re: [PR] Deterministic group by without order by [pinot]

Jackie-Jiang commented on code in PR #15844: URL: https://github.com/apache/pinot/pull/15844#discussion_r2103603013 ## pinot-core/src/main/java/org/apache/pinot/core/data/table/DeterministicConcurrentIndexedTable.java: ## @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Software

Re: [PR] Deterministic group by without order by [pinot]

anandheritage commented on PR #15844: URL: https://github.com/apache/pinot/pull/15844#issuecomment-2901716376 > It'll be good if you can share some perf number comparing this new `IndexedTable` with the existing one Benchmark Mode C

Re: [PR] Deterministic group by without order by [pinot]

anandheritage commented on code in PR #15844: URL: https://github.com/apache/pinot/pull/15844#discussion_r2102845051 ## pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java: ## @@ -275,6 +275,17 @@ public ExplainMode getExplain() { return _

Re: [PR] Deterministic group by without order by [pinot]

anandheritage commented on code in PR #15844: URL: https://github.com/apache/pinot/pull/15844#discussion_r2101917553 ## pinot-core/src/main/java/org/apache/pinot/core/data/table/DeterministicConcurrentIndexedTable.java: ## @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Softwar

Re: [PR] Deterministic group by without order by [pinot]

anandheritage commented on code in PR #15844: URL: https://github.com/apache/pinot/pull/15844#discussion_r2101912781 ## pinot-core/src/main/java/org/apache/pinot/core/data/table/DeterministicConcurrentIndexedTable.java: ## @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Softwar

Re: [PR] Deterministic group by without order by [pinot]

anandheritage commented on code in PR #15844: URL: https://github.com/apache/pinot/pull/15844#discussion_r2101825392 ## pinot-core/src/main/java/org/apache/pinot/core/data/table/DeterministicConcurrentIndexedTable.java: ## @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Softwar

Re: [PR] Deterministic group by without order by [pinot]

anandheritage commented on code in PR #15844: URL: https://github.com/apache/pinot/pull/15844#discussion_r2101810223 ## pinot-core/src/main/java/org/apache/pinot/core/data/table/DeterministicConcurrentIndexedTable.java: ## @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Softwar

Re: [PR] Deterministic group by without order by [pinot]

Jackie-Jiang commented on code in PR #15844: URL: https://github.com/apache/pinot/pull/15844#discussion_r2101258157 ## pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java: ## @@ -275,6 +275,17 @@ public ExplainMode getExplain() { return _e

Re: [PR] Deterministic group by without order by [pinot]

gortiz commented on code in PR #15844: URL: https://github.com/apache/pinot/pull/15844#discussion_r2100326122 ## pinot-core/src/main/java/org/apache/pinot/core/data/table/DeterministicConcurrentIndexedTable.java: ## @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Software Found

Re: [PR] Deterministic group by without order by [pinot]

anandheritage commented on PR #15844: URL: https://github.com/apache/pinot/pull/15844#issuecomment-2894996832 > > In distributed group-by queries that apply a LIMIT without an accompanying ORDER BY clause, each server arbitrarily selects a subset of groups, which can lead to non-determinist

Re: [PR] Deterministic group by without order by [pinot]

gortiz commented on PR #15844: URL: https://github.com/apache/pinot/pull/15844#issuecomment-2894788414 > In distributed group-by queries that apply a LIMIT without an accompanying ORDER BY clause, each server arbitrarily selects a subset of groups, which can lead to non-deterministic behavi