Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on PR #11578: URL: https://github.com/apache/pinot/pull/11578#issuecomment-1789629202 > should be fixed by #11915 Thanks for the fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] pre-configuration based assignment [pinot]

walterddr commented on PR #11578: URL: https://github.com/apache/pinot/pull/11578#issuecomment-1787927070 should be fixed by https://github.com/apache/pinot/pull/11915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] pre-configuration based assignment [pinot]

walterddr commented on PR #11578: URL: https://github.com/apache/pinot/pull/11578#issuecomment-1787895868 this PR broken ColocatedJoinQuickStart can we take a look CC @jasperjiaguo @siddharthteotia -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] pre-configuration based assignment [pinot]

siddharthteotia merged PR #11578: URL: https://github.com/apache/pinot/pull/11578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pi

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1375319910 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java: ## @@ -286,6 +290,81 @@ public String getTablesOnTenan

Re: [PR] pre-configuration based assignment [pinot]

somandal commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1375132678 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -60,19 +60,31 @@ public InstanceParti

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1375083118 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -1735,20 +1735,29 @@ private void assignInstances(Ta

Re: [PR] pre-configuration based assignment [pinot]

somandal commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1374921766 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -1735,20 +1735,29 @@ private void assignInstances(TableC

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1372543881 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java: ## @@ -286,6 +290,81 @@ public String getTablesOnTenan

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1372541085 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/MirrorServerSetInstancePartitionSelector.java: ## @@ -0,0 +1,353 @@ +/

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1372529334 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java: ## @@ -286,6 +290,81 @@ public String getTablesOnTenan

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1372524544 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/MirrorServerSetInstancePartitionSelector.java: ## @@ -0,0 +1,353 @@ +/

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1372523409 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/MirrorServerSetInstancePartitionSelector.java: ## @@ -0,0 +1,353 @@ +/

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1372507842 ## pinot-common/src/main/java/org/apache/pinot/common/assignment/InstanceAssignmentConfigUtils.java: ## @@ -124,4 +124,14 @@ public static InstanceAssignmentConfig

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1372507127 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/MirrorServerSetInstancePartitionSelector.java: ## @@ -0,0 +1,353 @@ +/

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1372504413 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/MirrorServerSetInstancePartitionSelector.java: ## @@ -0,0 +1,353 @@ +/

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1372503103 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/MirrorServerSetInstancePartitionSelector.java: ## @@ -0,0 +1,353 @@ +/

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1372502885 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/MirrorServerSetInstancePartitionSelector.java: ## @@ -0,0 +1,353 @@ +/

Re: [PR] pre-configuration based assignment [pinot]

vvivekiyer commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1372113740 ## pinot-common/src/main/java/org/apache/pinot/common/assignment/InstanceAssignmentConfigUtils.java: ## @@ -124,4 +124,14 @@ public static InstanceAssignmentConfig

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1372055451 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java: ## @@ -286,6 +291,75 @@ public String getTablesOnTenan

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1371079962 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/PreConfiguredInstancePartitionSelector.java: ## @@ -0,0 +1,304 @@ +/**

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1371070042 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java: ## @@ -286,6 +291,75 @@ public String getTablesOnTenan

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1371069731 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java: ## @@ -286,6 +291,75 @@ public String getTablesOnTenan

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1371043521 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java: ## @@ -286,6 +291,75 @@ public String getTablesOnTenan

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1371041721 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java: ## @@ -286,6 +291,75 @@ public String getTablesOnTenan

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1371000457 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/PreConfiguredInstancePartitionSelector.java: ## @@ -0,0 +1,304 @@ +/**

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1370998295 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/PreConfiguredInstancePartitionSelector.java: ## @@ -0,0 +1,304 @@ +/**

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1370997620 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/PreConfiguredInstancePartitionSelector.java: ## @@ -0,0 +1,304 @@ +/**

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1370997292 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/PreConfiguredInstancePartitionSelector.java: ## @@ -0,0 +1,304 @@ +/**

Re: [PR] pre-configuration based assignment [pinot]

vvivekiyer commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1370844943 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/PreConfiguredInstancePartitionSelector.java: ## @@ -0,0 +1,304 @@ +/** +

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1370876469 ## pinot-core/src/main/java/org/apache/pinot/core/auth/Actions.java: ## @@ -85,6 +85,8 @@ public static class Cluster { public static final String UPDATE_USER

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1370851013 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotInstanceAssignmentRestletResource.java: ## @@ -244,20 +244,32 @@ public Map assign

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1370848383 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotInstanceAssignmentRestletResource.java: ## @@ -244,20 +244,32 @@ public Map assign

Re: [PR] pre-configuration based assignment [pinot]

jasperjiaguo commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1370844325 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/assignment/InstanceAssignmentConfig.java: ## @@ -82,6 +82,7 @@ public InstanceReplicaGroupPartitionCon

Re: [PR] pre-configuration based assignment [pinot]

siddharthteotia commented on PR #11578: URL: https://github.com/apache/pinot/pull/11578#issuecomment-1778024169 > Do you have a design doc for this? Trying to understand what we want to achieve in this PR Let's meet to share our context on where we are coming from and the overall goa

Re: [PR] pre-configuration based assignment [pinot]

vvivekiyer commented on code in PR #11578: URL: https://github.com/apache/pinot/pull/11578#discussion_r1370576854 ## pinot-core/src/main/java/org/apache/pinot/core/auth/Actions.java: ## @@ -85,6 +85,8 @@ public static class Cluster { public static final String UPDATE_USER =

Re: [PR] pre-configuration based assignment [pinot]

Jackie-Jiang commented on PR #11578: URL: https://github.com/apache/pinot/pull/11578#issuecomment-1777824497 Do you have a design doc for this? Trying to understand what we want to achieve in this PR -- This is an automated message from the Apache Git Service. To respond to the message, p