anandheritage commented on PR #13645:
URL: https://github.com/apache/pinot/pull/13645#issuecomment-2429314665
Let me know if you want me to revert this for now and maybe we discuss if
major changes are required ?
--
This is an automated message from the Apache Git Service.
To respond to t
anandheritage commented on PR #13645:
URL: https://github.com/apache/pinot/pull/13645#issuecomment-2429296863
@gortiz Can you help me with the changes expected ?
When I had made the changes didn't had the dev env to test.
--
This is an automated message from the Apache Git Service
gortiz commented on PR #13645:
URL: https://github.com/apache/pinot/pull/13645#issuecomment-2429269516
This PR is buggy. It looks like QueryServer enables TLS when it is enabled
in netty config but query dispatcher is never using TLS, so multi-stage query
engine ends up not working at all i
gortiz commented on code in PR #13645:
URL: https://github.com/apache/pinot/pull/13645#discussion_r1807240795
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/server/QueryServer.java:
##
@@ -55,16 +58,18 @@ public class QueryServer extends
PinotQueryWorkerGrp
soumitra-st commented on code in PR #13645:
URL: https://github.com/apache/pinot/pull/13645#discussion_r1807168639
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/DispatchClient.java:
##
@@ -41,7 +45,17 @@ class DispatchClient {
private final Pino
soumitra-st commented on code in PR #13645:
URL: https://github.com/apache/pinot/pull/13645#discussion_r1807168639
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/DispatchClient.java:
##
@@ -41,7 +45,17 @@ class DispatchClient {
private final Pino
soumitra-st commented on code in PR #13645:
URL: https://github.com/apache/pinot/pull/13645#discussion_r1807168639
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/DispatchClient.java:
##
@@ -41,7 +45,17 @@ class DispatchClient {
private final Pino
ankitsultana merged PR #13645:
URL: https://github.com/apache/pinot/pull/13645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
anandheritage commented on code in PR #13645:
URL: https://github.com/apache/pinot/pull/13645#discussion_r1759753077
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/DispatchClient.java:
##
@@ -58,4 +90,26 @@ public void cancel(long requestId) {
anandheritage commented on code in PR #13645:
URL: https://github.com/apache/pinot/pull/13645#discussion_r1732145603
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/DispatchClient.java:
##
@@ -58,4 +90,26 @@ public void cancel(long requestId) {
ankitsultana commented on code in PR #13645:
URL: https://github.com/apache/pinot/pull/13645#discussion_r1731505892
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/DispatchClient.java:
##
@@ -58,4 +90,26 @@ public void cancel(long requestId) {
W
anandheritage commented on code in PR #13645:
URL: https://github.com/apache/pinot/pull/13645#discussion_r1730226104
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/DispatchClient.java:
##
@@ -58,4 +90,26 @@ public void cancel(long requestId) {
anandheritage commented on code in PR #13645:
URL: https://github.com/apache/pinot/pull/13645#discussion_r1730226104
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/DispatchClient.java:
##
@@ -58,4 +90,26 @@ public void cancel(long requestId) {
anandheritage commented on code in PR #13645:
URL: https://github.com/apache/pinot/pull/13645#discussion_r1730225172
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/server/QueryServer.java:
##
@@ -71,7 +88,17 @@ public void start() {
LOGGER.info("Startin
anandheritage commented on code in PR #13645:
URL: https://github.com/apache/pinot/pull/13645#discussion_r1730225393
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/DispatchClient.java:
##
@@ -36,12 +52,28 @@
*/
class DispatchClient {
private s
anandheritage commented on code in PR #13645:
URL: https://github.com/apache/pinot/pull/13645#discussion_r1730224851
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/GrpcMailboxServer.java:
##
@@ -37,17 +54,33 @@
* send by the sender of the sender/re
ankitsultana commented on code in PR #13645:
URL: https://github.com/apache/pinot/pull/13645#discussion_r1728177518
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/GrpcMailboxServer.java:
##
@@ -37,17 +54,33 @@
* send by the sender of the sender/rec
anandheritage commented on PR #13645:
URL: https://github.com/apache/pinot/pull/13645#issuecomment-2258076601
@xiangfu0 @npawar Can you help me get it reviewed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
codecov-commenter commented on PR #13645:
URL: https://github.com/apache/pinot/pull/13645#issuecomment-2247874775
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
anandheritage commented on PR #13645:
URL: https://github.com/apache/pinot/pull/13645#issuecomment-2247089004
@Jackie-Jiang @xiangfu0
Can you enable the workflow here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
anandheritage commented on code in PR #13645:
URL: https://github.com/apache/pinot/pull/13645#discussion_r1689116461
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/server/QueryServer.java:
##
@@ -184,4 +211,27 @@ public void cancel(Worker.CancelRequest reque
anandheritage commented on code in PR #13645:
URL: https://github.com/apache/pinot/pull/13645#discussion_r1689111716
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/server/QueryServer.java:
##
@@ -71,7 +88,17 @@ public void start() {
LOGGER.info("Startin
22 matches
Mail list logo
