gortiz commented on code in PR #13645:
URL: https://github.com/apache/pinot/pull/13645#discussion_r1807240795
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/server/QueryServer.java:
##########
@@ -55,16 +58,18 @@ public class QueryServer extends
PinotQueryWorkerGrpc.PinotQueryWorkerImplBase {
private final int _port;
private final QueryRunner _queryRunner;
+ private final TlsConfig _tlsConfig;
Review Comment:
@Nullable annotation is needed here
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/server/QueryServer.java:
##########
@@ -55,16 +58,18 @@ public class QueryServer extends
PinotQueryWorkerGrpc.PinotQueryWorkerImplBase {
private final int _port;
private final QueryRunner _queryRunner;
+ private final TlsConfig _tlsConfig;
// query submission service is only used for plan submission for now.
// TODO: with complex query submission logic we should allow asynchronous
query submission return instead of
// directly return from submission response observer.
private final ExecutorService _querySubmissionExecutorService;
private Server _server = null;
- public QueryServer(int port, QueryRunner queryRunner) {
+ public QueryServer(int port, QueryRunner queryRunner, TlsConfig tlsConfig) {
Review Comment:
@Nullabe annotation is needed here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
