Re: [PR] Support array literal functions [pinot]

2023-12-19 Thread via GitHub
xiangfu0 merged PR #12118: URL: https://github.com/apache/pinot/pull/12118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Support array literal functions [pinot]

2023-12-19 Thread via GitHub
codecov-commenter commented on PR #12118: URL: https://github.com/apache/pinot/pull/12118#issuecomment-1863566998 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] Support array literal functions [pinot]

2023-12-19 Thread via GitHub
Jackie-Jiang commented on code in PR #12118: URL: https://github.com/apache/pinot/pull/12118#discussion_r1431984479 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/TypeUtils.java: ## @@ -66,6 +66,12 @@ public static Object convert(Object value,

Re: [PR] Support array literal functions [pinot]

2023-12-19 Thread via GitHub
xiangfu0 commented on code in PR #12118: URL: https://github.com/apache/pinot/pull/12118#discussion_r1431978111 ## pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotEvaluateLiteralRule.java: ## @@ -171,13 +180,70 @@ private static RexNode evaluateLiteralOnlyFu

Re: [PR] Support array literal functions [pinot]

2023-12-19 Thread via GitHub
xiangfu0 commented on code in PR #12118: URL: https://github.com/apache/pinot/pull/12118#discussion_r1431972919 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CastTransformFunction.java: ## @@ -56,6 +56,10 @@ public void init(List arguments, Map c

Re: [PR] Support array literal functions [pinot]

2023-12-19 Thread via GitHub
xiangfu0 commented on code in PR #12118: URL: https://github.com/apache/pinot/pull/12118#discussion_r1431970432 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/TypeUtils.java: ## @@ -66,6 +66,12 @@ public static Object convert(Object value, Col

Re: [PR] Support array literal functions [pinot]

2023-12-19 Thread via GitHub
xiangfu0 commented on code in PR #12118: URL: https://github.com/apache/pinot/pull/12118#discussion_r1431967330 ## pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java: ## @@ -156,7 +156,12 @@ public enum ObjectType { FloatArrayList(44), StringAr

Re: [PR] Support array literal functions [pinot]

2023-12-19 Thread via GitHub
Jackie-Jiang commented on code in PR #12118: URL: https://github.com/apache/pinot/pull/12118#discussion_r1431875567 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java: ## @@ -1512,6 +1517,30 @@ private void computeResultsForLiteral

Re: [PR] Support array literal functions [pinot]

2023-12-18 Thread via GitHub
Jackie-Jiang commented on code in PR #12118: URL: https://github.com/apache/pinot/pull/12118#discussion_r1430849697 ## pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java: ## @@ -156,7 +156,12 @@ public enum ObjectType { FloatArrayList(44), Stri

Re: [PR] Support array literal functions [pinot]

2023-12-18 Thread via GitHub
xiangfu0 commented on code in PR #12118: URL: https://github.com/apache/pinot/pull/12118#discussion_r1430765003 ## pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java: ## @@ -156,7 +156,12 @@ public enum ObjectType { FloatArrayList(44), StringAr

Re: [PR] Support array literal functions [pinot]

2023-12-15 Thread via GitHub
Jackie-Jiang commented on code in PR #12118: URL: https://github.com/apache/pinot/pull/12118#discussion_r1428438510 ## pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java: ## @@ -156,7 +156,12 @@ public enum ObjectType { FloatArrayList(44), Stri

Re: [PR] Support array literal functions [pinot]

2023-12-14 Thread via GitHub
xiangfu0 commented on code in PR #12118: URL: https://github.com/apache/pinot/pull/12118#discussion_r1427470866 ## pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java: ## @@ -156,7 +156,12 @@ public enum ObjectType { FloatArrayList(44), StringAr

Re: [PR] Support array literal functions [pinot]

2023-12-14 Thread via GitHub
xiangfu0 commented on code in PR #12118: URL: https://github.com/apache/pinot/pull/12118#discussion_r1427418306 ## pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java: ## @@ -156,7 +156,12 @@ public enum ObjectType { FloatArrayList(44), StringAr

Re: [PR] Support array literal functions [pinot]

2023-12-11 Thread via GitHub
Jackie-Jiang commented on code in PR #12118: URL: https://github.com/apache/pinot/pull/12118#discussion_r1422823809 ## pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java: ## @@ -156,7 +156,12 @@ public enum ObjectType { FloatArrayList(44), Stri

Re: [PR] Support array literal functions [pinot]

2023-12-07 Thread via GitHub
codecov-commenter commented on PR #12118: URL: https://github.com/apache/pinot/pull/12118#issuecomment-1846338479 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[PR] Support array literal functions [pinot]

2023-12-07 Thread via GitHub
xiangfu0 opened a new pull request, #12118: URL: https://github.com/apache/pinot/pull/12118 Support array literal in thrift and ObjectSerde. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp