Jackie-Jiang commented on code in PR #12118:
URL: https://github.com/apache/pinot/pull/12118#discussion_r1431984479
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/TypeUtils.java:
##########
@@ -66,6 +66,12 @@ public static Object convert(Object value, ColumnDataType
storedType) {
if (value instanceof FloatArrayList) {
// For ArrayAggregationFunction
return ((FloatArrayList) value).elements();
+ } else if (value instanceof double[]) {
Review Comment:
Add some comment explaining this
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -1512,8 +1521,28 @@ private void computeResultsForLiteral(Literal literal,
List<String> columnNames,
columnTypes.add(DataSchema.ColumnDataType.UNKNOWN);
row.add(null);
break;
- default:
+ case INT_ARRAY_VALUE:
+ columnTypes.add(DataSchema.ColumnDataType.INT_ARRAY);
+ row.add(literal.getIntArrayValue());
+ break;
+ case LONG_ARRAY_VALUE:
+ columnTypes.add(DataSchema.ColumnDataType.LONG_ARRAY);
+ row.add(literal.getLongArrayValue());
break;
+ case FLOAT_ARRAY_VALUE:
+ columnTypes.add(DataSchema.ColumnDataType.FLOAT_ARRAY);
+
row.add(literal.getFloatArrayValue().stream().map(Float::intBitsToFloat).collect(Collectors.toList()));
+ break;
+ case DOUBLE_ARRAY_VALUE:
+ columnTypes.add(DataSchema.ColumnDataType.DOUBLE_ARRAY);
+ row.add(literal.getDoubleArrayValue());
+ break;
+ case STRING_ARRAY_VALUE:
+ columnTypes.add(DataSchema.ColumnDataType.STRING_ARRAY);
+ row.add(literal.getStringArrayValue());
+ break;
+ default:
+ throw new IllegalStateException("No able to compute results for
literal - " + literal);
Review Comment:
```suggestion
throw new IllegalStateException("Unsupported literal: " + literal);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
