Re: [PR] Safeguard AbstractBuilder copy constructor from empty TextIndexConfig [pinot]

2024-12-06 Thread via GitHub
swaminathanmanish merged PR #14616: URL: https://github.com/apache/pinot/pull/14616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

Re: [PR] Safeguard AbstractBuilder copy constructor from empty TextIndexConfig [pinot]

2024-12-06 Thread via GitHub
shounakmk219 commented on code in PR #14616: URL: https://github.com/apache/pinot/pull/14616#discussion_r1873530036 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/store/TextIndexUtilsTest.java: ## @@ -45,7 +45,8 @@ public void testRoundTripProperties

Re: [PR] Safeguard AbstractBuilder copy constructor from empty TextIndexConfig [pinot]

2024-12-06 Thread via GitHub
swaminathanmanish commented on code in PR #14616: URL: https://github.com/apache/pinot/pull/14616#discussion_r1873503014 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/store/TextIndexUtilsTest.java: ## @@ -45,7 +45,8 @@ public void testRoundTripPrope

Re: [PR] Safeguard AbstractBuilder copy constructor from empty TextIndexConfig [pinot]

2024-12-06 Thread via GitHub
codecov-commenter commented on PR #14616: URL: https://github.com/apache/pinot/pull/14616#issuecomment-2523404804 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14616?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Safeguard AbstractBuilder copy constructor from empty TextIndexConfig [pinot]

2024-12-06 Thread via GitHub
shounakmk219 opened a new pull request, #14616: URL: https://github.com/apache/pinot/pull/14616 Refer https://github.com/apache/pinot/pull/13948#issuecomment-2523157822 The PR also fixes the default value of `useANDForMultiTermQueries` which was being set to `true` via `AbstractBuilde