shounakmk219 commented on code in PR #14616:
URL: https://github.com/apache/pinot/pull/14616#discussion_r1873530036
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/store/TextIndexUtilsTest.java:
##########
@@ -45,7 +45,8 @@ public void testRoundTripProperties()
TextIndexUtils.writeConfigToPropertiesFile(TEMP_DIR, config);
TextIndexConfig readConfig =
TextIndexUtils.getUpdatedConfigFromPropertiesFile(
- new File(TEMP_DIR,
V1Constants.Indexes.LUCENE_TEXT_INDEX_PROPERTIES_FILE), config);
+ new File(TEMP_DIR,
V1Constants.Indexes.LUCENE_TEXT_INDEX_PROPERTIES_FILE),
+ JsonUtils.stringToObject("{}", TextIndexConfig.class));
Review Comment:
Earlier test was writing the config to property file and then passing the
same to merge it with the property file which I thought may not be testing
much, hence updated the same test by passing an empty config to merge it with
the property file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
