Re: [PR] Replace fmpp-maven-plugin with fmpp Ant Task to avoid pulling the vul… [pinot]

2024-09-18 Thread via GitHub
Jackie-Jiang commented on code in PR #14015: URL: https://github.com/apache/pinot/pull/14015#discussion_r1765569242 ## pinot-common/pom.xml: ## @@ -100,22 +100,31 @@ -com.googlecode.fmpp-maven-plugin -fmpp-maven-plugin +org.apache.maven.pl

Re: [PR] Replace fmpp-maven-plugin with fmpp Ant Task to avoid pulling the vul… [pinot]

2024-09-18 Thread via GitHub
rfscholte commented on code in PR #14015: URL: https://github.com/apache/pinot/pull/14015#discussion_r1765098870 ## pinot-common/pom.xml: ## @@ -301,6 +303,10 @@ equalsverifier test + Review Comment: this makes it a project dependency, while it is onl

Re: [PR] Replace fmpp-maven-plugin with fmpp Ant Task to avoid pulling the vul… [pinot]

2024-09-18 Thread via GitHub
codecov-commenter commented on PR #14015: URL: https://github.com/apache/pinot/pull/14015#issuecomment-2357669419 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14015?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Replace fmpp-maven-plugin with fmpp Ant Task to avoid pulling the vul… [pinot]

2024-09-17 Thread via GitHub
chrajeshbabu opened a new pull request, #14015: URL: https://github.com/apache/pinot/pull/14015 …nerable log4j jars -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.