Jackie-Jiang commented on code in PR #14015: URL: https://github.com/apache/pinot/pull/14015#discussion_r1765569242
########## pinot-common/pom.xml: ########## @@ -100,22 +100,31 @@ <!-- "Plugs in" the Calcite's Parser.jj with the variables present in config.fmpp. These contain the custom rules as well as the class to which the custom implementation will get generated --> <plugin> - <groupId>com.googlecode.fmpp-maven-plugin</groupId> - <artifactId>fmpp-maven-plugin</artifactId> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-antrun-plugin</artifactId> <executions> <execution> - <id>generate-fmpp-sources</id> <phase>generate-sources</phase> - <goals> - <goal>generate</goal> - </goals> <configuration> - <cfgFile>${project.build.directory}/codegen/config.fmpp</cfgFile> - <outputDirectory>${project.build.directory}/generated-sources</outputDirectory> - <templateDirectory>${project.build.directory}/codegen/templates</templateDirectory> + <target name="generate-code"> + <taskdef name="fmpp" classname="fmpp.tools.AntTask" classpathref="maven.compile.classpath"/> + <fmpp configuration="${project.build.directory}/codegen/config.fmpp" + sourceRoot="${project.build.directory}/codegen/templates" + outputRoot="${project.build.directory}/generated-sources"/> + </target> </configuration> + <goals> + <goal>run</goal> + </goals> </execution> </executions> + <dependencies> + <dependency> + <groupId>net.sourceforge.fmpp</groupId> + <artifactId>fmpp</artifactId> + <version>${fmpp.version}</version> Review Comment: Can we pull this up to the parent pom dependency management? ########## pinot-common/pom.xml: ########## @@ -100,22 +100,31 @@ <!-- "Plugs in" the Calcite's Parser.jj with the variables present in config.fmpp. These contain the custom rules as well as the class to which the custom implementation will get generated --> <plugin> - <groupId>com.googlecode.fmpp-maven-plugin</groupId> - <artifactId>fmpp-maven-plugin</artifactId> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-antrun-plugin</artifactId> <executions> <execution> - <id>generate-fmpp-sources</id> <phase>generate-sources</phase> - <goals> - <goal>generate</goal> - </goals> <configuration> - <cfgFile>${project.build.directory}/codegen/config.fmpp</cfgFile> - <outputDirectory>${project.build.directory}/generated-sources</outputDirectory> - <templateDirectory>${project.build.directory}/codegen/templates</templateDirectory> + <target name="generate-code"> + <taskdef name="fmpp" classname="fmpp.tools.AntTask" classpathref="maven.compile.classpath"/> + <fmpp configuration="${project.build.directory}/codegen/config.fmpp" + sourceRoot="${project.build.directory}/codegen/templates" + outputRoot="${project.build.directory}/generated-sources"/> + </target> </configuration> + <goals> + <goal>run</goal> + </goals> </execution> </executions> + <dependencies> + <dependency> + <groupId>net.sourceforge.fmpp</groupId> + <artifactId>fmpp</artifactId> + <version>${fmpp.version}</version> Review Comment: Should we pull this up to the parent pom dependency management? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org