Jackie-Jiang merged PR #12189:
URL: https://github.com/apache/pinot/pull/12189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on code in PR #12189:
URL: https://github.com/apache/pinot/pull/12189#discussion_r1456581684
##
pinot-common/src/main/java/org/apache/pinot/common/auth/AuthProviderUtils.java:
##
@@ -63,6 +63,9 @@ public static AuthConfig extractAuthConfig(PinotConfigurati
xiangfu0 commented on code in PR #12189:
URL: https://github.com/apache/pinot/pull/12189#discussion_r1456567046
##
pinot-common/src/main/java/org/apache/pinot/common/auth/AuthProviderUtils.java:
##
@@ -63,6 +63,9 @@ public static AuthConfig extractAuthConfig(PinotConfiguration
codecov-commenter commented on PR #12189:
URL: https://github.com/apache/pinot/pull/12189#issuecomment-1865415471
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12189?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
Jackie-Jiang opened a new pull request, #12189:
URL: https://github.com/apache/pinot/pull/12189
`TableDataManagerConfig` is simply a wrapper over
`InstanceDataManagerConfig` and `TableConfig` but can introduce a lot of
confusion into the `TableDataManager`
--
This is an automated message