xiangfu0 commented on code in PR #12189:
URL: https://github.com/apache/pinot/pull/12189#discussion_r1456567046
##########
pinot-common/src/main/java/org/apache/pinot/common/auth/AuthProviderUtils.java:
##########
@@ -63,6 +63,9 @@ public static AuthConfig extractAuthConfig(PinotConfiguration
pinotConfig, Strin
* @return auth provider
*/
public static AuthProvider extractAuthProvider(PinotConfiguration
pinotConfig, String namespace) {
Review Comment:
Do you need to put `@Nullable` annotation for `PinotConfiguration
pinotConfig` and same for other methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
