Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-12 Thread via GitHub
gortiz merged PR #14337: URL: https://github.com/apache/pinot/pull/14337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-12 Thread via GitHub
bziobrowski commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1837772550 ## pinot-core/src/main/java/org/apache/pinot/core/util/NumberUtils.java: ## @@ -0,0 +1,224 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-12 Thread via GitHub
gortiz commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1837709046 ## pinot-core/src/main/java/org/apache/pinot/core/util/NumberUtils.java: ## @@ -0,0 +1,224 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-12 Thread via GitHub
bziobrowski commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1837700145 ## pinot-core/src/main/java/org/apache/pinot/core/util/NumberUtils.java: ## @@ -0,0 +1,224 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-12 Thread via GitHub
bziobrowski commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1837700145 ## pinot-core/src/main/java/org/apache/pinot/core/util/NumberUtils.java: ## @@ -0,0 +1,224 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-11 Thread via GitHub
gortiz commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1836107425 ## pinot-core/src/main/java/org/apache/pinot/core/util/NumberUtils.java: ## @@ -0,0 +1,224 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-08 Thread via GitHub
bziobrowski commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1834554527 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java: ## @@ -184,8 +191,7 @@ public long[] transfor

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-07 Thread via GitHub
gortiz commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1832480854 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java: ## @@ -184,8 +191,7 @@ public long[] transformToLo

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-07 Thread via GitHub
bziobrowski commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1832410493 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java: ## @@ -184,8 +191,7 @@ public long[] transfor

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-07 Thread via GitHub
bziobrowski commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1832410493 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java: ## @@ -184,8 +191,7 @@ public long[] transfor

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-07 Thread via GitHub
gortiz commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1832331941 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java: ## @@ -184,8 +191,7 @@ public long[] transformToLo

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-07 Thread via GitHub
bziobrowski commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1832283197 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java: ## @@ -184,8 +191,7 @@ public long[] transfor

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-07 Thread via GitHub
bziobrowski commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1832283197 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java: ## @@ -184,8 +191,7 @@ public long[] transfor

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-06 Thread via GitHub
Jackie-Jiang commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1831497506 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java: ## @@ -184,8 +191,7 @@ public long[] transfo

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-06 Thread via GitHub
gortiz commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1831105430 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java: ## @@ -184,8 +191,7 @@ public long[] transformToLo

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-06 Thread via GitHub
gortiz commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1831105430 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java: ## @@ -184,8 +191,7 @@ public long[] transformToLo

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-05 Thread via GitHub
Jackie-Jiang commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1830200695 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java: ## @@ -184,8 +184,12 @@ public long[] transf

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-05 Thread via GitHub
bziobrowski commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1829065409 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java: ## @@ -184,8 +184,12 @@ public long[] transfo

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-10-31 Thread via GitHub
Jackie-Jiang commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1825039705 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java: ## @@ -184,8 +184,12 @@ public long[] transf

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-10-31 Thread via GitHub
gortiz commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1823984614 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java: ## @@ -184,8 +184,12 @@ public long[] transformToL

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-10-30 Thread via GitHub
Jackie-Jiang commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1823424323 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java: ## @@ -184,8 +184,12 @@ public long[] transf

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-10-30 Thread via GitHub
bziobrowski commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1823032836 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java: ## @@ -184,8 +184,12 @@ public long[] transfo

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-10-30 Thread via GitHub
codecov-commenter commented on PR #14337: URL: https://github.com/apache/pinot/pull/14337#issuecomment-2447880886 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14337?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Fix long value parsing in jsonextractscalar [pinot]

2024-10-30 Thread via GitHub
bziobrowski opened a new pull request, #14337: URL: https://github.com/apache/pinot/pull/14337 When extracting very large LONG numbers, `json_extract_scalar()` function is losing some precision, even though the numbers should be able to fit into a LONG size just fine. For example, if the