gortiz commented on code in PR #14337:
URL: https://github.com/apache/pinot/pull/14337#discussion_r1823984614
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java:
##########
@@ -184,8 +184,12 @@ public long[] transformToLongValuesSV(ValueBlock
valueBlock) {
if (result instanceof Number) {
_longValuesSV[i] = ((Number) result).longValue();
} else {
- // Handle scientific notation
- _longValuesSV[i] = (long) Double.parseDouble(result.toString());
+ try {
Review Comment:
I think we could iterate on the string looking for numbers or -. If we only
find them, we optimistically call `Long.parseLong`. If that fails or if we find
anything different than `-` or numbers, we call `Double.parseDouble`. Unless I
missing something this should work in almost all case except very large numbers
(which we can probably also check statically by comparing the length of the
string).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
