Re: [PR] Exclude dimensions from star-tree index stored type check [pinot]

2024-06-11 Thread via GitHub
Jackie-Jiang merged PR #13355: URL: https://github.com/apache/pinot/pull/13355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Exclude dimensions from star-tree index stored type check [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang commented on code in PR #13355: URL: https://github.com/apache/pinot/pull/13355#discussion_r1634027291 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/startree/v2/builder/StarTreeIndexSeparatorTest.java: ## @@ -18,85 +18,63 @@ */ package org.a

Re: [PR] Exclude dimensions from star-tree index stored type check [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang commented on code in PR #13355: URL: https://github.com/apache/pinot/pull/13355#discussion_r1634019815 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/SegmentLocalFSDirectory.java: ## @@ -268,7 +267,7 @@ private synchronized void lo

Re: [PR] Exclude dimensions from star-tree index stored type check [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang commented on code in PR #13355: URL: https://github.com/apache/pinot/pull/13355#discussion_r1634019517 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/StarTreeIndexReader.java: ## @@ -67,17 +66,11 @@ public class StarTreeIndexReader

Re: [PR] Exclude dimensions from star-tree index stored type check [pinot]

2024-06-10 Thread via GitHub
codecov-commenter commented on PR #13355: URL: https://github.com/apache/pinot/pull/13355#issuecomment-2159556815 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13355?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Exclude dimensions from star-tree index stored type check [pinot]

2024-06-10 Thread via GitHub
jadami10 commented on code in PR #13355: URL: https://github.com/apache/pinot/pull/13355#discussion_r1634000831 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/SegmentLocalFSDirectory.java: ## @@ -268,7 +267,7 @@ private synchronized void loadDa

[PR] Exclude dimensions from star-tree index stored type check [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang opened a new pull request, #13355: URL: https://github.com/apache/pinot/pull/13355 Related to #12164 and #12554 Do not check stored type for dimensions to avoid mismatching columns with '__' in column name -- This is an automated message from the Apache Git Service. To