Jackie-Jiang commented on code in PR #13355:
URL: https://github.com/apache/pinot/pull/13355#discussion_r1634027291
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/startree/v2/builder/StarTreeIndexSeparatorTest.java:
##########
@@ -18,85 +18,63 @@
*/
package org.apache.pinot.segment.local.startree.v2.builder;
-import com.google.common.collect.Lists;
import java.io.File;
-import java.io.IOException;
import java.net.URL;
import java.util.Arrays;
+import java.util.HashSet;
import java.util.List;
-import java.util.Objects;
-import org.apache.commons.configuration2.PropertiesConfiguration;
-import org.apache.commons.configuration2.ex.ConfigurationException;
+import java.util.Set;
import org.apache.commons.io.FileUtils;
-import org.apache.pinot.segment.spi.V1Constants;
+import org.apache.pinot.segment.spi.index.metadata.SegmentMetadataImpl;
import org.apache.pinot.segment.spi.index.startree.StarTreeV2Constants;
import org.apache.pinot.spi.config.table.StarTreeIndexConfig;
-import org.apache.pinot.spi.env.CommonsConfigurationUtils;
+import org.testng.annotations.AfterClass;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;
import static
org.apache.pinot.segment.spi.V1Constants.Indexes.RAW_SV_FORWARD_INDEX_FILE_EXTENSION;
import static
org.apache.pinot.segment.spi.V1Constants.Indexes.UNSORTED_SV_FORWARD_INDEX_FILE_EXTENSION;
import static
org.apache.pinot.segment.spi.index.startree.StarTreeV2Constants.STAR_TREE_INDEX_FILE_NAME;
-import static org.testng.AssertJUnit.assertEquals;
-import static org.testng.AssertJUnit.assertNotNull;
+import static org.testng.Assert.assertNotNull;
import static org.testng.AssertJUnit.assertTrue;
public class StarTreeIndexSeparatorTest {
-
private static final String SEGMENT_PATH = "data/startree/segment";
- private static final String TOTAL_DOCS_KEY = "startree.v2.0.total.docs";
-
- private StarTreeIndexSeparator _separator;
- private PropertiesConfiguration _metadataProperties;
- private final StarTreeV2BuilderConfig _builderConfig =
StarTreeV2BuilderConfig.fromIndexConfig(
- new StarTreeIndexConfig(
- Lists.newArrayList("AirlineID", "Origin", "Dest"),
- Lists.newArrayList(),
- Lists.newArrayList("count__*", "max__ArrDelay"),
- null,
- 10));
+ private final StarTreeV2BuilderConfig BUILDER_CONFIG =
StarTreeV2BuilderConfig.fromIndexConfig(
+ new StarTreeIndexConfig(List.of("AirlineID", "Origin", "Dest"),
List.of(), List.of("count__*", "max__ArrDelay"),
Review Comment:
Good suggestion. Updated `BaseStarTreeV2Test` to capture that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
