Re: [PR] Bug fix: Do not ignore scheme property in Java client [pinot]

2024-11-20 Thread via GitHub
cyrilou242 commented on code in PR #12332: URL: https://github.com/apache/pinot/pull/12332#discussion_r1849438185 ## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransportFactory.java: ## @@ -85,8 +85,9 @@ public JsonAsyncHttpPino

Re: [PR] Bug fix: Do not ignore scheme property in Java client [pinot]

2024-02-13 Thread via GitHub
KKcorps merged PR #12332: URL: https://github.com/apache/pinot/pull/12332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

Re: [PR] Bug fix: Do not ignore scheme property in Java client [pinot]

2024-02-05 Thread via GitHub
walterddr commented on code in PR #12332: URL: https://github.com/apache/pinot/pull/12332#discussion_r1478983780 ## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransportFactory.java: ## @@ -85,8 +85,9 @@ public JsonAsyncHttpPinot

Re: [PR] Bug fix: Do not ignore scheme property in Java client [pinot]

2024-02-05 Thread via GitHub
walterddr commented on code in PR #12332: URL: https://github.com/apache/pinot/pull/12332#discussion_r1478983780 ## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransportFactory.java: ## @@ -85,8 +85,9 @@ public JsonAsyncHttpPinot

Re: [PR] Bug fix: Do not ignore scheme property in Java client [pinot]

2024-02-05 Thread via GitHub
KKcorps commented on code in PR #12332: URL: https://github.com/apache/pinot/pull/12332#discussion_r1477900874 ## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransportFactory.java: ## @@ -85,8 +85,9 @@ public JsonAsyncHttpPinotCl

Re: [PR] Bug fix: Do not ignore scheme property in Java client [pinot]

2024-01-31 Thread via GitHub
walterddr commented on code in PR #12332: URL: https://github.com/apache/pinot/pull/12332#discussion_r1473462577 ## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransportFactory.java: ## @@ -85,8 +85,9 @@ public JsonAsyncHttpPinot

Re: [PR] Bug fix: Do not ignore scheme property in Java client [pinot]

2024-01-31 Thread via GitHub
walterddr commented on code in PR #12332: URL: https://github.com/apache/pinot/pull/12332#discussion_r1473458810 ## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransportFactory.java: ## @@ -85,8 +85,9 @@ public JsonAsyncHttpPinot

Re: [PR] Bug fix: Do not ignore scheme property in Java client [pinot]

2024-01-31 Thread via GitHub
walterddr commented on code in PR #12332: URL: https://github.com/apache/pinot/pull/12332#discussion_r1473458505 ## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransportFactory.java: ## @@ -85,8 +85,9 @@ public JsonAsyncHttpPinot

Re: [PR] Bug fix: Do not ignore scheme property in Java client [pinot]

2024-01-31 Thread via GitHub
walterddr commented on code in PR #12332: URL: https://github.com/apache/pinot/pull/12332#discussion_r1473458505 ## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransportFactory.java: ## @@ -85,8 +85,9 @@ public JsonAsyncHttpPinot

[PR] Bug fix: Do not ignore scheme property in Java client [pinot]

2024-01-29 Thread via GitHub
KKcorps opened a new pull request, #12332: URL: https://github.com/apache/pinot/pull/12332 Scheme property already has a default value of `http` when initialised. This leads to a bug where we always ignore when a scheme is set using properties. -- This is an automated message from the Apa