walterddr commented on code in PR #12332:
URL: https://github.com/apache/pinot/pull/12332#discussion_r1478983780
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransportFactory.java:
##########
@@ -85,8 +85,9 @@ public JsonAsyncHttpPinotClientTransportFactory
withConnectionProperties(Propert
_headers = ConnectionUtils.getHeadersFromProperties(properties);
}
- if (_scheme == null) {
- _scheme = properties.getProperty("scheme",
CommonConstants.HTTP_PROTOCOL);
+ String scheme = properties.getProperty("scheme",
CommonConstants.HTTP_PROTOCOL);
+ if (_scheme == null || !_scheme.contentEquals(scheme)) {
+ _scheme = scheme;
}
Review Comment:
i dont understand. the code is literally setting the class variable
`_schema` to the property value `schema`.
In any cases the schema variable is different from _schema?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
