noob-se7en commented on PR #14217:
URL: https://github.com/apache/pinot/pull/14217#issuecomment-2839693930
Any reason to keep it behind a flag? Any issue with always resetting error
segments by default?
@shauryachats
--
This is an automated message from the Apache Git Service.
To res
shauryachats commented on code in PR #14217:
URL: https://github.com/apache/pinot/pull/14217#discussion_r1931347200
##
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##
@@ -206,6 +206,8 @@ public static class ControllerPeriodicTasksConf {
Jackie-Jiang merged PR #14217:
URL: https://github.com/apache/pinot/pull/14217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
shauryachats commented on code in PR #14217:
URL: https://github.com/apache/pinot/pull/14217#discussion_r1931231448
##
pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java:
##
@@ -169,6 +171,10 @@ private void runSegmentLeve
shauryachats commented on code in PR #14217:
URL: https://github.com/apache/pinot/pull/14217#discussion_r1931231448
##
pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java:
##
@@ -169,6 +171,10 @@ private void runSegmentLeve
Jackie-Jiang commented on code in PR #14217:
URL: https://github.com/apache/pinot/pull/14217#discussion_r1805532242
##
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##
@@ -206,6 +206,8 @@ public static class ControllerPeriodicTasksConf {
Jackie-Jiang commented on code in PR #14217:
URL: https://github.com/apache/pinot/pull/14217#discussion_r1805529540
##
pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java:
##
@@ -169,6 +171,10 @@ private void runSegmentLeve
yashmayya commented on code in PR #14217:
URL: https://github.com/apache/pinot/pull/14217#discussion_r1800435318
##
pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java:
##
@@ -169,6 +171,10 @@ private void runSegmentLevelVa
itschrispeck commented on code in PR #14217:
URL: https://github.com/apache/pinot/pull/14217#discussion_r1800411604
##
pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java:
##
@@ -169,6 +171,10 @@ private void runSegmentLeve
shauryachats commented on code in PR #14217:
URL: https://github.com/apache/pinot/pull/14217#discussion_r1800218911
##
pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java:
##
@@ -169,6 +171,10 @@ private void runSegmentLeve
shauryachats commented on code in PR #14217:
URL: https://github.com/apache/pinot/pull/14217#discussion_r1800218911
##
pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java:
##
@@ -169,6 +171,10 @@ private void runSegmentLeve
yashmayya commented on code in PR #14217:
URL: https://github.com/apache/pinot/pull/14217#discussion_r1798735073
##
pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java:
##
@@ -169,6 +171,10 @@ private void runSegmentLevelVa
codecov-commenter commented on PR #14217:
URL: https://github.com/apache/pinot/pull/14217#issuecomment-2409860874
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/14217?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
shauryachats opened a new pull request, #14217:
URL: https://github.com/apache/pinot/pull/14217
Auto reset of error segments can be done whenever segment validation flow
executes, which eliminates the need for manual resolution.
This feature is gated behind the controller config
`con
14 matches
Mail list logo
