yashmayya commented on code in PR #14217:
URL: https://github.com/apache/pinot/pull/14217#discussion_r1798735073
##########
pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java:
##########
@@ -169,6 +171,10 @@ private void runSegmentLevelValidation(TableConfig
tableConfig, StreamConfig str
if (_llcRealtimeSegmentManager.isDeepStoreLLCSegmentUploadRetryEnabled()) {
_llcRealtimeSegmentManager.uploadToDeepStoreIfMissing(tableConfig,
segmentsZKMetadata);
}
+
+ if (_segmentAutoResetOnErrorAtValidation) {
+ _pinotHelixResourceManager.resetSegments(realtimeTableName, null, true);
+ }
Review Comment:
This applies to all segments - consuming and otherwise right? What kinds of
scenarios would this auto reset mechanism help with?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
