Re: [PR] 11085: Pre PinotConfig commons-configuartions2 upgrade [pinot]

2023-10-27 Thread via GitHub
xiangfu0 merged PR #11868: URL: https://github.com/apache/pinot/pull/11868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] 11085: Pre PinotConfig commons-configuartions2 upgrade [pinot]

2023-10-27 Thread via GitHub
xiangfu0 commented on code in PR #11868: URL: https://github.com/apache/pinot/pull/11868#discussion_r1375082035 ## pinot-spi/src/main/java/org/apache/pinot/spi/env/CommonsConfigurationUtils.java: ## @@ -101,10 +101,16 @@ private static Iterable getIterable(Iterator keys) {

Re: [PR] 11085: Pre PinotConfig commons-configuartions2 upgrade [pinot]

2023-10-27 Thread via GitHub
abhioncbr commented on code in PR #11868: URL: https://github.com/apache/pinot/pull/11868#discussion_r1374284752 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/TlsIntegrationTest.java: ## @@ -211,7 +211,7 @@ protected PinotConfiguration getDefaultSe

Re: [PR] 11085: Pre PinotConfig commons-configuartions2 upgrade [pinot]

2023-10-26 Thread via GitHub
xiangfu0 commented on code in PR #11868: URL: https://github.com/apache/pinot/pull/11868#discussion_r1374054544 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/TlsIntegrationTest.java: ## @@ -211,7 +211,7 @@ protected PinotConfiguration getDefaultSer

Re: [PR] 11085: Pre PinotConfig commons-configuartions2 upgrade [pinot]

2023-10-25 Thread via GitHub
abhioncbr commented on code in PR #11868: URL: https://github.com/apache/pinot/pull/11868#discussion_r1372482904 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/TlsIntegrationTest.java: ## @@ -211,7 +211,7 @@ protected PinotConfiguration getDefaultSe