Jackie-Jiang commented on PR #12061:
URL: https://github.com/apache/pinot/pull/12061#issuecomment-2065467205
This no longer apply after #12812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Jackie-Jiang closed pull request #12061: [feature] use async methods to read
from Pulsar topic
URL: https://github.com/apache/pinot/pull/12061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
Jackie-Jiang commented on PR #12061:
URL: https://github.com/apache/pinot/pull/12061#issuecomment-1979756517
There are test failures. @JeffBolle Can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
enzo-dechaene commented on PR #12061:
URL: https://github.com/apache/pinot/pull/12061#issuecomment-1973221062
Hii @KKcorps, can we merge this PR in the 1.1.0 release ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
KKcorps commented on PR #12061:
URL: https://github.com/apache/pinot/pull/12061#issuecomment-1859958543
> This PR started from addressing a concurrency issue when interacting with
the List used to hold messages pulled from Pulsar after the read timeout
expired. It then evolved into a refact
KKcorps commented on code in PR #12061:
URL: https://github.com/apache/pinot/pull/12061#discussion_r1429804967
##
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarPartitionLevelConsumer.java:
##
@@ -75,81 +71,68 @@ publi
JeffBolle commented on PR #12061:
URL: https://github.com/apache/pinot/pull/12061#issuecomment-1855876618
This PR started from addressing a concurrency issue when interacting with
the List used to hold messages pulled from Pulsar after the read timeout
expired. It then evolved into a refac
codecov-commenter commented on PR #12061:
URL: https://github.com/apache/pinot/pull/12061#issuecomment-1830274214
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12061?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
JeffBolle opened a new pull request, #12061:
URL: https://github.com/apache/pinot/pull/12061
Addresses ConcurrentModificationException in reading from Pulsar topic and
uses fully async calls to read from a Pulsar Reader.
--
This is an automated message from the Apache Git Service.
To resp
