KKcorps commented on PR #12061: URL: https://github.com/apache/pinot/pull/12061#issuecomment-1859958543
> This PR started from addressing a concurrency issue when interacting with the List used to hold messages pulled from Pulsar after the read timeout expired. It then evolved into a refactor to use the asynchronous methods of reading from the pulsar topic to get the Future to place the read timeout on, rather than using a single threaded executor. Thanks a lot for contribution! Looks good overall, just have one comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
