[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1295577054 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/BlockingMultiStreamConsumer.java: ## @@ -0,0 +1,246 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1295575927 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/BlockingMultiStreamConsumer.java: ## @@ -0,0 +1,246 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1295575927 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/BlockingMultiStreamConsumer.java: ## @@ -0,0 +1,246 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1295560610 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/BlockingMultiStreamConsumer.java: ## @@ -0,0 +1,246 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1291103612 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java: ## @@ -173,30 +165,32 @@ public void cancel(long requestId) { @VisibleForTesti

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1291097043 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerServiceTest.java: ## @@ -203,84 +143,72 @@ public void shouldCallCancelOnOp

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1291096823 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerServiceTest.java: ## @@ -203,84 +143,72 @@ public void shouldCallCancelOnOp

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1290051875 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/SchedulerService.java: ## @@ -0,0 +1,29 @@ +/** + * Licensed to the Apache Software Foundati

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289962057 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/MailboxReceiveOperatorTest.java: ## @@ -139,21 +138,11 @@ public void shouldTimeoutOnExtraLo

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289961773 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerServiceTest.java: ## @@ -203,84 +143,72 @@ public void shouldCallCancelOnOp

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289961342 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/SetOperator.java: ## @@ -112,15 +112,14 @@ protected void constructRightBlockSet() { pr

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289833588 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/TransferableBlock.java: ## @@ -188,4 +193,10 @@ private boolean isType(MetadataBlock.MetadataB

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289956471 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java: ## @@ -113,14 +113,11 @@ public MultiStageBrokerRequestHandler(

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289954302 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerService.java: ## @@ -31,151 +32,73 @@ import org.slf4j.LoggerFactory; -

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289886813 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java: ## @@ -61,6 +61,9 @@ public GrpcSendingMailbox(String id, ChannelManager ch

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289877958 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxSendOperator.java: ## @@ -118,46 +118,52 @@ public String toExplainString() { @O

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289872541 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultiStageOperator.java: ## @@ -44,6 +45,7 @@ public MultiStageOperator(OpChainExecutionCont

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289872541 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultiStageOperator.java: ## @@ -44,6 +45,7 @@ public MultiStageOperator(OpChainExecutionCont

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289865538 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/TransformOperator.java: ## @@ -86,13 +86,14 @@ protected TransferableBlock getNextBlock() {

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289862143 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/BlockingMultiStreamConsumer.java: ## @@ -0,0 +1,246 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289857744 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/BlockingMultiStreamConsumer.java: ## @@ -0,0 +1,246 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289833588 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/TransferableBlock.java: ## @@ -188,4 +193,10 @@ private boolean isType(MetadataBlock.MetadataB

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289828568 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/ExecutorServiceUtils.java: ## @@ -0,0 +1,57 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289819281 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/ExecutorServiceUtils.java: ## @@ -0,0 +1,57 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] [pinot] gortiz commented on a diff in pull request #11205: Remove noop

gortiz commented on code in PR #11205: URL: https://github.com/apache/pinot/pull/11205#discussion_r1289769475 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/ExecutorServiceUtils.java: ## @@ -0,0 +1,57 @@ +/** + * Licensed to the Apache Software Foun