(pinot) branch master updated (de387c17da -> 64efe79476)

2025-05-06 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from de387c17da Create proper response when all segments are pruned on broker (#15703) add 64efe79476 Use AtomicInt

Re: [PR] Use AtomicInteger for _currentQueryServerThreads in MultiStageQueryThrottler to provide thread-safe computation [pinot]

2025-05-06 Thread via GitHub
yashmayya merged PR #15724: URL: https://github.com/apache/pinot/pull/15724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [PR] Fix Swagger UI redirect issue by preserving Knox gateway path in base… [pinot]

2025-05-06 Thread via GitHub
abhishekbafna commented on PR #15707: URL: https://github.com/apache/pinot/pull/15707#issuecomment-2857139567 > Thanks for the feedback, @abhishekbafna > > I’ll investigate the issue right away and work on a fix to ensure the Swagger link behaves correctly in both proxied environments

[PR] Broker selection for logical tables. [pinot]

2025-05-06 Thread via GitHub
abhishekbafna opened a new pull request, #15726: URL: https://github.com/apache/pinot/pull/15726 Implementation for broker selection for logical tables. For the logical tables, it adds an entry into brokerResource node under ideal state which is transitioned to external view node usin

Re: [PR] Broker selection for logical tables [pinot]

2025-05-06 Thread via GitHub
abhishekbafna closed pull request #15622: Broker selection for logical tables URL: https://github.com/apache/pinot/pull/15622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [bugfix] Remove deleting segments from table status info [pinot]

2025-05-06 Thread via GitHub
codecov-commenter commented on PR #15725: URL: https://github.com/apache/pinot/pull/15725#issuecomment-2857108009 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15725?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] [Query Resource Isolation] Workload Configs [pinot]

2025-05-06 Thread via GitHub
vvivekiyer commented on code in PR #15109: URL: https://github.com/apache/pinot/pull/15109#discussion_r2076797320 ## pinot-controller/src/main/java/org/apache/pinot/controller/workload/QueryWorkloadManager.java: ## @@ -0,0 +1,178 @@ +/** + * Licensed to the Apache Software Found

Re: [PR] Fix Swagger UI redirect issue by preserving Knox gateway path in base… [pinot]

2025-05-06 Thread via GitHub
userhimanshuverma commented on PR #15707: URL: https://github.com/apache/pinot/pull/15707#issuecomment-2857075796 Thanks for the feedback, @abhishekbafna I’ll investigate the issue right away and work on a fix to ensure the Swagger link behaves correctly in both proxied environments

[PR] [bugfix] Remove deleting segments from table status info [pinot]

2025-05-06 Thread via GitHub
himanish-star opened a new pull request, #15725: URL: https://github.com/apache/pinot/pull/15725 ### Description Showing segments to be deleted (part of lineage) is very confusing to users. We need to exclude from UI/debug .APIs Segments part of the lineage should not be includ

Re: [PR] Create proper response when all segments are pruned on broker [pinot]

2025-05-06 Thread via GitHub
Jackie-Jiang merged PR #15703: URL: https://github.com/apache/pinot/pull/15703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (ebcba81761 -> de387c17da)

2025-05-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from ebcba81761 Add Table config decorator support (#15714) add de387c17da Create proper response when all segments ar

[PR] Use AtomicInteger for _currentQueryServerThreads in MultiStageQueryThrottler to provide thread-safe computation [pinot]

2025-05-06 Thread via GitHub
yashmayya opened a new pull request, #15724: URL: https://github.com/apache/pinot/pull/15724 - https://github.com/apache/pinot/pull/15189 added this to keep track of the estimated number of query server threads from each broker's point of view. - The methods where the variable is incremen

Re: [PR] Fix Swagger UI redirect issue by preserving Knox gateway path in base… [pinot]

2025-05-06 Thread via GitHub
abhishekbafna commented on PR #15707: URL: https://github.com/apache/pinot/pull/15707#issuecomment-2856936326 > Thanks @jayeshchoudhary! I've double-checked the redirection behavior, and I can confirm that the existing redirections continue to work as expected. The change to relative paths

Re: [PR] netty 4.2.1 final [pinot]

2025-05-06 Thread via GitHub
codecov-commenter commented on PR #15723: URL: https://github.com/apache/pinot/pull/15723#issuecomment-2856760312 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15723?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add metrics for monitoring server's message queue size [pinot]

2025-05-06 Thread via GitHub
somandal commented on code in PR #15722: URL: https://github.com/apache/pinot/pull/15722#discussion_r2076618643 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java: ## @@ -1058,4 +1072,19 @@ private void initSegmentFetcher(PinotConfiguratio

(pinot) branch master updated (b206ccd076 -> ebcba81761)

2025-05-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from b206ccd076 Log IS update failures in ensureAllPartitionsConsuming (#15673) add ebcba81761 Add Table config decor

Re: [PR] Add Table config decorator support [pinot]

2025-05-06 Thread via GitHub
Jackie-Jiang merged PR #15714: URL: https://github.com/apache/pinot/pull/15714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Create proper response when all segments are pruned on broker [pinot]

2025-05-06 Thread via GitHub
Jackie-Jiang commented on code in PR #15703: URL: https://github.com/apache/pinot/pull/15703#discussion_r2076593173 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/EmptyResponseUtils.java: ## @@ -0,0 +1,206 @@ +/** + * Licensed to the Apache Software Foundat

Re: [PR] netty 4.2.0.Final [pinot]

2025-05-06 Thread via GitHub
sullis closed pull request #15462: netty 4.2.0.Final URL: https://github.com/apache/pinot/pull/15462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

Re: [PR] netty 4.2.0.Final [pinot]

2025-05-06 Thread via GitHub
sullis commented on PR #15462: URL: https://github.com/apache/pinot/pull/15462#issuecomment-2856694265 Replaced by Netty 4.2.1 https://github.com/apache/pinot/pull/15723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] netty 4.2.1 final [pinot]

2025-05-06 Thread via GitHub
sullis opened a new pull request, #15723: URL: https://github.com/apache/pinot/pull/15723 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] Add metrics for monitoring server's message queue size [pinot]

2025-05-06 Thread via GitHub
codecov-commenter commented on PR #15722: URL: https://github.com/apache/pinot/pull/15722#issuecomment-2856685656 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15722?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add metrics for monitoring server's message queue size [pinot]

2025-05-06 Thread via GitHub
rhodo commented on code in PR #15722: URL: https://github.com/apache/pinot/pull/15722#discussion_r2076585268 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java: ## @@ -1058,4 +1072,19 @@ private void initSegmentFetcher(PinotConfiguration

Re: [PR] Add metrics for monitoring server's message queue size [pinot]

2025-05-06 Thread via GitHub
rhodo commented on code in PR #15722: URL: https://github.com/apache/pinot/pull/15722#discussion_r2076584102 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java: ## @@ -698,6 +705,10 @@ public void start() _helixAdmin = _helixManager.g

Re: [PR] Add metrics for monitoring server's message queue size [pinot]

2025-05-06 Thread via GitHub
somandal commented on code in PR #15722: URL: https://github.com/apache/pinot/pull/15722#discussion_r2076571757 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java: ## @@ -1058,4 +1072,19 @@ private void initSegmentFetcher(PinotConfiguratio

Re: [PR] Add metrics for monitoring server's message queue size [pinot]

2025-05-06 Thread via GitHub
somandal commented on code in PR #15722: URL: https://github.com/apache/pinot/pull/15722#discussion_r2076567915 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java: ## @@ -117,7 +117,10 @@ public enum ServerGauge implements AbstractMetrics.Gauge { M

Re: [PR] Add metrics for monitoring server's message queue size [pinot]

2025-05-06 Thread via GitHub
somandal commented on code in PR #15722: URL: https://github.com/apache/pinot/pull/15722#discussion_r2076566526 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java: ## @@ -698,6 +705,10 @@ public void start() _helixAdmin = _helixManage

Re: [PR] Add metrics for monitoring server's message queue size [pinot]

2025-05-06 Thread via GitHub
raghavyadav01 commented on code in PR #15722: URL: https://github.com/apache/pinot/pull/15722#discussion_r2076561960 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java: ## @@ -698,6 +705,10 @@ public void start() _helixAdmin = _helixM

[PR] Add metrics for monitoring server's message queue size [pinot]

2025-05-06 Thread via GitHub
rhodo opened a new pull request, #15722: URL: https://github.com/apache/pinot/pull/15722 During large table rebalances, a massive number of state transitions may be triggered. If a server cannot keep up, the size of its Helix message queue can grow significantly. This PR adds visibility int

Re: [PR] Reduce segment metadata memory overhead. [pinot]

2025-05-06 Thread via GitHub
Jackie-Jiang commented on code in PR #15591: URL: https://github.com/apache/pinot/pull/15591#discussion_r2076557602 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BigNumberOfSegmentsIntegrationTest.java: ## @@ -0,0 +1,266 @@ +/** + * Licensed to the

Re: [PR] Reduce segment metadata memory overhead. [pinot]

2025-05-06 Thread via GitHub
Jackie-Jiang commented on code in PR #15591: URL: https://github.com/apache/pinot/pull/15591#discussion_r2076557228 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/PhysicalColumnIndexContainer.java: ## @@ -51,36 +53,115 @@ public Physica

(pinot) branch master updated: Log IS update failures in ensureAllPartitionsConsuming (#15673)

2025-05-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new b206ccd076 Log IS update failures in ensureAllPar

Re: [PR] Log IS update failures in ensureAllPartitionsConsuming [pinot]

2025-05-06 Thread via GitHub
Jackie-Jiang merged PR #15673: URL: https://github.com/apache/pinot/pull/15673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] MSE support for case-insensitiveness without breaking compatibility [pinot]

2025-05-06 Thread via GitHub
Jackie-Jiang commented on code in PR #15692: URL: https://github.com/apache/pinot/pull/15692#discussion_r2076531611 ## pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java: ## @@ -116,6 +117,13 @@ @Value.Enclosing public class QueryEnvironment { pr

(pinot) branch master updated: Fallback for bad values in periodic controller task configurations (#15466)

2025-05-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new cba670fa4f Fallback for bad values in periodic co

Re: [PR] Fallback for bad values in periodic controller task configurations [pinot]

2025-05-06 Thread via GitHub
Jackie-Jiang merged PR #15466: URL: https://github.com/apache/pinot/pull/15466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Fail the config file reading if there are duplicated keys in the file [pinot]

2025-05-06 Thread via GitHub
Jackie-Jiang commented on code in PR #15648: URL: https://github.com/apache/pinot/pull/15648#discussion_r2076495490 ## pinot-spi/src/main/java/org/apache/pinot/spi/env/CommonsConfigurationUtils.java: ## @@ -170,6 +178,34 @@ public static PropertiesConfiguration fromFile(@Nullabl

Re: [I] PageCache Warmup During Server Restart and Segment Refresh [pinot]

2025-05-06 Thread via GitHub
Jackie-Jiang commented on issue #15675: URL: https://github.com/apache/pinot/issues/15675#issuecomment-2856404660 @vvivekiyer @siddharthteotia Do you want to explore the shadowing query option, which should be able to simplify the flow, and applicable to most use cases -- This is an auto

Re: [PR] [Priority Replica Group Routing] Support orderedPreferredReplicas query option for customizable routing strategy [pinot]

2025-05-06 Thread via GitHub
wirybeaver commented on PR #15203: URL: https://github.com/apache/pinot/pull/15203#issuecomment-2856387345 > Can you define exactly what `orderedPreferredReplicas` policy is in the PR description? I only see a few examples like: > > > To make the solution more flexible, we allow speci

Re: [I] PageCache Warmup During Server Restart and Segment Refresh [pinot]

2025-05-06 Thread via GitHub
praveenc7 commented on issue #15675: URL: https://github.com/apache/pinot/issues/15675#issuecomment-2856384196 > > > One challenge is to figure out the pages to cache. Do you plan to shadow some queries to the segments so that cache can be warmed up based on the live traffic? > > > >

Re: [I] PageCache Warmup During Server Restart and Segment Refresh [pinot]

2025-05-06 Thread via GitHub
Jackie-Jiang commented on issue #15675: URL: https://github.com/apache/pinot/issues/15675#issuecomment-2856325204 > > One challenge is to figure out the pages to cache. Do you plan to shadow some queries to the segments so that cache can be warmed up based on the live traffic? > > [@

Re: [PR] [Priority Replica Group Routing] Support orderedPreferredReplicas query option for customizable routing strategy [pinot]

2025-05-06 Thread via GitHub
wirybeaver commented on code in PR #15203: URL: https://github.com/apache/pinot/pull/15203#discussion_r2076332040 ## pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryOptionsUtils.java: ## @@ -182,6 +185,19 @@ public static Integer getNumReplicaGroupsToQuery(

Re: [I] PageCache Warmup During Server Restart and Segment Refresh [pinot]

2025-05-06 Thread via GitHub
praveenc7 commented on issue #15675: URL: https://github.com/apache/pinot/issues/15675#issuecomment-2856280993 ### Some performance gains seen on our end ### Latency trendline during segment refresh & restart with feature disabled ![Image](https://github.com/user-attachments/as

Re: [PR] Move Table Routing logic in SSE to TableRoute class [pinot]

2025-05-06 Thread via GitHub
Jackie-Jiang merged PR #15388: URL: https://github.com/apache/pinot/pull/15388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [I] [Logical Table] Refactor Table Route Calculation in SSE Broker Handler [pinot]

2025-05-06 Thread via GitHub
Jackie-Jiang closed issue #15557: [Logical Table] Refactor Table Route Calculation in SSE Broker Handler URL: https://github.com/apache/pinot/issues/15557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

(pinot) branch master updated (0464333fed -> 497a90b725)

2025-05-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 0464333fed Bump com.gradle:common-custom-user-data-maven-extension (#15718) add 497a90b725 Move Table Routing log

Re: [PR] Move Table Routing logic in SSE to TableRoute class [pinot]

2025-05-06 Thread via GitHub
Jackie-Jiang commented on code in PR #15388: URL: https://github.com/apache/pinot/pull/15388#discussion_r2076425223 ## pinot-core/src/main/java/org/apache/pinot/core/transport/ImplicitHybridTableRouteInfo.java: ## @@ -0,0 +1,370 @@ +/** + * Licensed to the Apache Software Founda

Re: [PR] [Priority Replica Group Routing] Support orderedPreferredReplicas query option for customizable routing strategy [pinot]

2025-05-06 Thread via GitHub
wirybeaver commented on code in PR #15203: URL: https://github.com/apache/pinot/pull/15203#discussion_r2076332040 ## pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryOptionsUtils.java: ## @@ -182,6 +185,19 @@ public static Integer getNumReplicaGroupsToQuery(

Re: [PR] Dynamic timeout for EV convergence in table rebalance [pinot]

2025-05-06 Thread via GitHub
somandal commented on PR #15618: URL: https://github.com/apache/pinot/pull/15618#issuecomment-2856018292 @J-HowHuang can you update some testing notes for the `bestEfforts=true` changes? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] Disallow multiple TableRebalance jobs from running for the same table at the same time [pinot]

2025-05-06 Thread via GitHub
somandal commented on issue #15683: URL: https://github.com/apache/pinot/issues/15683#issuecomment-2856024561 As part of this, we should carefully think about how best to handle `SegmentRelocator` especially for long-running rebalances. The design should try and cover that part. -- This

Re: [PR] Dynamic timeout for EV convergence in table rebalance [pinot]

2025-05-06 Thread via GitHub
J-HowHuang commented on code in PR #15618: URL: https://github.com/apache/pinot/pull/15618#discussion_r2076291529 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1352,26 +1394,58 @@ static boolean isExternalViewConv

Re: [PR] Dynamic timeout for EV convergence in table rebalance [pinot]

2025-05-06 Thread via GitHub
somandal commented on code in PR #15618: URL: https://github.com/apache/pinot/pull/15618#discussion_r2076286916 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1352,26 +1394,58 @@ static boolean isExternalViewConver

Re: [PR] Dynamic timeout for EV convergence in table rebalance [pinot]

2025-05-06 Thread via GitHub
J-HowHuang commented on code in PR #15618: URL: https://github.com/apache/pinot/pull/15618#discussion_r2076139645 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1300,50 +1301,91 @@ private IdealState waitForExterna

Re: [PR] Dynamic timeout for EV convergence in table rebalance [pinot]

2025-05-06 Thread via GitHub
somandal commented on code in PR #15618: URL: https://github.com/apache/pinot/pull/15618#discussion_r2076151354 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1352,26 +1380,55 @@ static boolean isExternalViewConver

Re: [PR] Dynamic timeout for EV convergence in table rebalance [pinot]

2025-05-06 Thread via GitHub
J-HowHuang commented on code in PR #15618: URL: https://github.com/apache/pinot/pull/15618#discussion_r2076140374 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1352,26 +1394,58 @@ static boolean isExternalViewConv

Re: [PR] Dynamic timeout for EV convergence in table rebalance [pinot]

2025-05-06 Thread via GitHub
J-HowHuang commented on code in PR #15618: URL: https://github.com/apache/pinot/pull/15618#discussion_r2076139058 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1352,26 +1380,55 @@ static boolean isExternalViewConv

(pinot) branch dependabot/maven/nl.jqno.equalsverifier-equalsverifier-4.0 deleted (was 5038b22f52)

2025-05-06 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/nl.jqno.equalsverifier-equalsverifier-4.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 5038b22f52 Bump nl.jqno.equalsverifier:equalsverifier from 3.1

Re: [PR] Bump nl.jqno.equalsverifier:equalsverifier from 3.19.4 to 4.0 [pinot]

2025-05-06 Thread via GitHub
Jackie-Jiang closed pull request #15719: Bump nl.jqno.equalsverifier:equalsverifier from 3.19.4 to 4.0 URL: https://github.com/apache/pinot/pull/15719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Bump nl.jqno.equalsverifier:equalsverifier from 3.19.4 to 4.0 [pinot]

2025-05-06 Thread via GitHub
dependabot[bot] commented on PR #15719: URL: https://github.com/apache/pinot/pull/15719#issuecomment-2855649551 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

(pinot) branch dependabot/maven/com.gradle-common-custom-user-data-maven-extension-2.0.2 deleted (was 1129bc2fde)

2025-05-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.gradle-common-custom-user-data-maven-extension-2.0.2 in repository https://gitbox.apache.org/repos/asf/pinot.git was 1129bc2fde Bump com.gradle:common-custom-user-data-

(pinot) branch master updated (67cdf437ed -> 0464333fed)

2025-05-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 67cdf437ed Bump software.amazon.awssdk:bom from 2.31.35 to 2.31.36 (#15717) add 0464333fed Bump com.gradle:common

Re: [PR] Bump com.gradle:common-custom-user-data-maven-extension from 2.0.1 to 2.0.2 [pinot]

2025-05-06 Thread via GitHub
Jackie-Jiang merged PR #15718: URL: https://github.com/apache/pinot/pull/15718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (08769d2d7b -> 67cdf437ed)

2025-05-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 08769d2d7b Logical table CRUD operations. (#15515) add 67cdf437ed Bump software.amazon.awssdk:bom from 2.31.35 to

Re: [PR] Dynamic timeout for EV convergence in table rebalance [pinot]

2025-05-06 Thread via GitHub
somandal commented on code in PR #15618: URL: https://github.com/apache/pinot/pull/15618#discussion_r2076097269 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1352,26 +1394,58 @@ static boolean isExternalViewConver

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.31.36 deleted (was 41cba65f41)

2025-05-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.31.36 in repository https://gitbox.apache.org/repos/asf/pinot.git was 41cba65f41 Bump software.amazon.awssdk:bom from 2.31.35 to 2.31.36 The r

Re: [PR] Bump software.amazon.awssdk:bom from 2.31.35 to 2.31.36 [pinot]

2025-05-06 Thread via GitHub
Jackie-Jiang merged PR #15717: URL: https://github.com/apache/pinot/pull/15717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Dynamic timeout for EV convergence in table rebalance [pinot]

2025-05-06 Thread via GitHub
J-HowHuang commented on code in PR #15618: URL: https://github.com/apache/pinot/pull/15618#discussion_r2076094593 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1352,26 +1394,58 @@ static boolean isExternalViewConv

Re: [PR] Dynamic timeout for EV convergence in table rebalance [pinot]

2025-05-06 Thread via GitHub
somandal commented on code in PR #15618: URL: https://github.com/apache/pinot/pull/15618#discussion_r2076083881 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1300,50 +1301,91 @@ private IdealState waitForExternalV

Re: [PR] Dynamic timeout for EV convergence in table rebalance [pinot]

2025-05-06 Thread via GitHub
somandal commented on code in PR #15618: URL: https://github.com/apache/pinot/pull/15618#discussion_r2076083881 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1300,50 +1301,91 @@ private IdealState waitForExternalV

Re: [PR] Dynamic timeout for EV convergence in table rebalance [pinot]

2025-05-06 Thread via GitHub
J-HowHuang commented on code in PR #15618: URL: https://github.com/apache/pinot/pull/15618#discussion_r2076081984 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1300,50 +1301,91 @@ private IdealState waitForExterna

Re: [PR] Dynamic timeout for EV convergence in table rebalance [pinot]

2025-05-06 Thread via GitHub
J-HowHuang commented on code in PR #15618: URL: https://github.com/apache/pinot/pull/15618#discussion_r2076076577 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -485,7 +485,8 @@ private RebalanceResult doRebalance(T

Re: [PR] Dynamic timeout for EV convergence in table rebalance [pinot]

2025-05-06 Thread via GitHub
J-HowHuang commented on code in PR #15618: URL: https://github.com/apache/pinot/pull/15618#discussion_r2076058908 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1352,26 +1394,58 @@ static boolean isExternalViewConv

Re: [PR] Dynamic timeout for EV convergence in table rebalance [pinot]

2025-05-06 Thread via GitHub
somandal commented on code in PR #15618: URL: https://github.com/apache/pinot/pull/15618#discussion_r2076060961 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1352,26 +1394,58 @@ static boolean isExternalViewConver

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-05-06 Thread via GitHub
praveenc7 commented on PR #15585: URL: https://github.com/apache/pinot/pull/15585#issuecomment-2855450341 https://github.com/pinot-contrib/pinot-docs/pull/425 - >Docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] [multistage] Mailbox Content Observer Fails Silently when onNext Skipped [pinot]

2025-05-06 Thread via GitHub
shauryachats commented on issue #15721: URL: https://github.com/apache/pinot/issues/15721#issuecomment-2855290758 I can take a look here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[I] [multistage] Mailbox Content Observer Fails Silently when onNext Skipped [pinot]

2025-05-06 Thread via GitHub
ankitsultana opened a new issue, #15721: URL: https://github.com/apache/pinot/issues/15721 In scenarios where onError is called directly, we completely skip notifying the Mailbox Service, which leads to a failed query to remain stuck until the timeout is hit. https://github.com/user-

Re: [PR] Dynamic timeout for EV convergence in table rebalance [pinot]

2025-05-06 Thread via GitHub
somandal commented on PR #15618: URL: https://github.com/apache/pinot/pull/15618#issuecomment-2854869492 > > > > Before this PR, if we set externalViewStabilizationTimeoutInMs=1ms, regular run will fail after 1ms wait, while bestEfforts continue the next step after 1ms. > > >

Re: [PR] Add configs to logical tables [pinot]

2025-05-06 Thread via GitHub
codecov-commenter commented on PR #15720: URL: https://github.com/apache/pinot/pull/15720#issuecomment-2854574882 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15720?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Add configs to logical tables [pinot]

2025-05-06 Thread via GitHub
abhishekbafna opened a new pull request, #15720: URL: https://github.com/apache/pinot/pull/15720 The PR adds more configs for logical tables like query config, quota config, reference offline and realtime tables. Adds validation for the new configs. Updates the table cache for logical

[PR] Bump nl.jqno.equalsverifier:equalsverifier from 3.19.4 to 4.0 [pinot]

2025-05-06 Thread via GitHub
dependabot[bot] opened a new pull request, #15719: URL: https://github.com/apache/pinot/pull/15719 Bumps [nl.jqno.equalsverifier:equalsverifier](https://github.com/jqno/equalsverifier) from 3.19.4 to 4.0. Release notes Sourced from https://github.com/jqno/equalsverifier/releases";

(pinot) branch dependabot/maven/nl.jqno.equalsverifier-equalsverifier-4.0 created (now 5038b22f52)

2025-05-06 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/nl.jqno.equalsverifier-equalsverifier-4.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 5038b22f52 Bump nl.jqno.equalsverifier:equalsverifier from 3.1

[PR] Bump com.gradle:common-custom-user-data-maven-extension from 2.0.1 to 2.0.2 [pinot]

2025-05-06 Thread via GitHub
dependabot[bot] opened a new pull request, #15718: URL: https://github.com/apache/pinot/pull/15718 Bumps [com.gradle:common-custom-user-data-maven-extension](https://github.com/gradle/common-custom-user-data-maven-extension) from 2.0.1 to 2.0.2. Release notes Sourced from https://

(pinot) branch dependabot/maven/com.gradle-common-custom-user-data-maven-extension-2.0.2 created (now 1129bc2fde)

2025-05-06 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.gradle-common-custom-user-data-maven-extension-2.0.2 in repository https://gitbox.apache.org/repos/asf/pinot.git at 1129bc2fde Bump com.gradle:common-custom-user-d

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.31.36 created (now 41cba65f41)

2025-05-06 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.31.36 in repository https://gitbox.apache.org/repos/asf/pinot.git at 41cba65f41 Bump software.amazon.awssdk:bom from 2.31.35 to 2.31.36 N

[PR] Bump software.amazon.awssdk:bom from 2.31.35 to 2.31.36 [pinot]

2025-05-06 Thread via GitHub
dependabot[bot] opened a new pull request, #15717: URL: https://github.com/apache/pinot/pull/15717 Bumps software.amazon.awssdk:bom from 2.31.35 to 2.31.36. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- |

Re: [I] taskMaxNumFiles is being ignored [pinot]

2025-05-06 Thread via GitHub
YoavNordmann commented on issue #15666: URL: https://github.com/apache/pinot/issues/15666#issuecomment-2854253537 Regardless of my needs, I would expect, as per documentation, that when I use the `taskMaxNumFiles` parameters, it will be used and respected. `desiredSegmentSize`, as the name

Re: [I] taskMaxNumFiles is being ignored [pinot]

2025-05-06 Thread via GitHub
swaminathanmanish commented on issue #15666: URL: https://github.com/apache/pinot/issues/15666#issuecomment-2854151165 @YoavNordmann - taskMaxNumFiles is a config to control the number of files picked up by the task and this may not be what you need since there's already desiredSegmentSize

(pinot) branch master updated: Logical table CRUD operations. (#15515)

2025-05-06 Thread manishswaminathan
This is an automated email from the ASF dual-hosted git repository. manishswaminathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 08769d2d7b Logical table CRUD operatio

Re: [I] [Logical Table] Add CRUD APIs for Logical Tables [pinot]

2025-05-06 Thread via GitHub
swaminathanmanish closed issue #15556: [Logical Table] Add CRUD APIs for Logical Tables URL: https://github.com/apache/pinot/issues/15556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Logical table CRUD operations. [pinot]

2025-05-06 Thread via GitHub
swaminathanmanish merged PR #15515: URL: https://github.com/apache/pinot/pull/15515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@