Re: [PR] Add button to repair realtime table by triggering RealtimeSegmentValidationManager [pinot]

2025-04-17 Thread via GitHub
jayeshchoudhary commented on code in PR #15584: URL: https://github.com/apache/pinot/pull/15584#discussion_r2049173800 ## pinot-controller/src/main/resources/app/utils/PinotMethodUtils.ts: ## @@ -1008,6 +1009,12 @@ const rebalanceBrokersForTableOp = (tableName) => { return

(pinot) branch master updated: [multistage] Bug Fixes and Refactorings Based on E2E Physical Optimizer Test (#15561)

2025-04-17 Thread ankitsultana
This is an automated email from the ASF dual-hosted git repository. ankitsultana pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 97aa5cacce [multistage] Bug Fixes and Refac

Re: [PR] [multistage] Bug Fixes / Refactoring Based on E2E Physical Optimizer Test [pinot]

2025-04-17 Thread via GitHub
ankitsultana merged PR #15561: URL: https://github.com/apache/pinot/pull/15561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-04-17 Thread via GitHub
codecov-commenter commented on PR #15585: URL: https://github.com/apache/pinot/pull/15585#issuecomment-2814357378 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15585?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Fix range index on raw TIMESTAMP column [pinot]

2025-04-17 Thread via GitHub
codecov-commenter commented on PR #15589: URL: https://github.com/apache/pinot/pull/15589#issuecomment-2814293514 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15589?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Fix range index on raw TIMESTAMP column [pinot]

2025-04-17 Thread via GitHub
Jackie-Jiang opened a new pull request, #15589: URL: https://github.com/apache/pinot/pull/15589 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Fix range index on raw TIMESTAMP column [pinot]

2025-04-17 Thread via GitHub
Jackie-Jiang commented on PR #15589: URL: https://github.com/apache/pinot/pull/15589#issuecomment-2814261676 @KKcorps Can you help take a look and also add a test for it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Enhance and clean up star-tree tests [pinot]

2025-04-17 Thread via GitHub
codecov-commenter commented on PR #15587: URL: https://github.com/apache/pinot/pull/15587#issuecomment-2814189796 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15587?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Set cluster.tenant.isolation.enable to true in ControllerTest's default controller config [pinot]

2025-04-17 Thread via GitHub
codecov-commenter commented on PR #15588: URL: https://github.com/apache/pinot/pull/15588#issuecomment-2814260433 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15588?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Set cluster.tenant.isolation.enable to true in ControllerTest's default controller config [pinot]

2025-04-17 Thread via GitHub
J-HowHuang opened a new pull request, #15588: URL: https://github.com/apache/pinot/pull/15588 ## Description Today `cluster.tenant.isolation.enable` in controller config is default to `true` https://github.com/apache/pinot/blob/6c0215834bf3e6203d1246bbb0b49e01b369b6d4/pinot-controlle

Re: [PR] Add a New Pre-check Item for Replica Groups Info [pinot]

2025-04-17 Thread via GitHub
somandal commented on code in PR #15575: URL: https://github.com/apache/pinot/pull/15575#discussion_r2049749036 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java: ## @@ -379,6 +382,58 @@ private RebalancePreChecker

Re: [PR] Part 2: Enhance rebalance progress stats - Rollback Progress Stats Support [pinot]

2025-04-17 Thread via GitHub
somandal merged PR #15510: URL: https://github.com/apache/pinot/pull/15510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Part 2: Enhance rebalance progress stats - Rollback Progress Stats Support [pinot]

2025-04-17 Thread via GitHub
somandal commented on PR #15510: URL: https://github.com/apache/pinot/pull/15510#issuecomment-2814172465 > lgtm, but might want to update the PR title as to rollback rebalance stats. At first glance, I thought this PR would rollback rebalance :p good point, done! -- This is an aut

Re: [I] Setting numPools = 0 should not bypass the pool vs replica validation [pinot]

2025-04-17 Thread via GitHub
pengding-stripe closed issue #15543: Setting numPools = 0 should not bypass the pool vs replica validation URL: https://github.com/apache/pinot/issues/15543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

2025-04-17 Thread via GitHub
jitendrakr88 commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2049668083 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/ParserUtils.java: ## @@ -39,6 +39,49 @@ public static void validateFunction(String canonicalName, List

Re: [PR] Allow controller to skip PinotFS setup test during boot [pinot]

2025-04-17 Thread via GitHub
Jackie-Jiang commented on code in PR #15358: URL: https://github.com/apache/pinot/pull/15358#discussion_r2049554330 ## pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java: ## @@ -72,6 +72,10 @@ public class ControllerConf extends PinotConfiguration {

(pinot) branch master updated: Prevent NPE in minion tasks (#15550)

2025-04-17 Thread ankitsultana
This is an automated email from the ASF dual-hosted git repository. ankitsultana pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 0c2bac12cd Prevent NPE in minion tasks (#15

Re: [PR] Add validations for Pauseless Tables [pinot]

2025-04-17 Thread via GitHub
Jackie-Jiang commented on code in PR #15567: URL: https://github.com/apache/pinot/pull/15567#discussion_r2049440985 ## pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisStreamMetadataProvider.java: ## @@ -101,7 +100,11

Re: [PR] Add button to repair realtime table by triggering RealtimeSegmentValidationManager [pinot]

2025-04-17 Thread via GitHub
jayeshchoudhary commented on code in PR #15584: URL: https://github.com/apache/pinot/pull/15584#discussion_r2049173800 ## pinot-controller/src/main/resources/app/utils/PinotMethodUtils.ts: ## @@ -1008,6 +1009,12 @@ const rebalanceBrokersForTableOp = (tableName) => { return

Re: [PR] Add button to repair realtime table by triggering RealtimeSegmentValidationManager [pinot]

2025-04-17 Thread via GitHub
jayeshchoudhary commented on code in PR #15584: URL: https://github.com/apache/pinot/pull/15584#discussion_r2049176025 ## pinot-controller/src/main/resources/app/pages/TenantDetails.tsx: ## @@ -466,6 +466,20 @@ const TenantPageDetails = ({ match }: RouteComponentProps) => {

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

2025-04-17 Thread via GitHub
ankitsultana commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2049189342 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/ParserUtils.java: ## @@ -39,6 +39,49 @@ public static void validateFunction(String canonicalName, List

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

2025-04-17 Thread via GitHub
ankitsultana commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2049189342 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/ParserUtils.java: ## @@ -39,6 +39,49 @@ public static void validateFunction(String canonicalName, List

Re: [PR] Move Query Execution Planning to TableExecutionInfo in SSE [pinot]

2025-04-17 Thread via GitHub
vrajat commented on PR #15523: URL: https://github.com/apache/pinot/pull/15523#issuecomment-2813314137 Test failure is unrelated and seems like a flaky test. It passed locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] Add button to repair realtime table by triggering RealtimeSegmentValidationManager [pinot]

2025-04-17 Thread via GitHub
jayeshchoudhary commented on code in PR #15584: URL: https://github.com/apache/pinot/pull/15584#discussion_r2049176025 ## pinot-controller/src/main/resources/app/pages/TenantDetails.tsx: ## @@ -466,6 +466,20 @@ const TenantPageDetails = ({ match }: RouteComponentProps) => {

Re: [PR] Add button to repair realtime table by triggering RealtimeSegmentValidationManager [pinot]

2025-04-17 Thread via GitHub
jayeshchoudhary commented on code in PR #15584: URL: https://github.com/apache/pinot/pull/15584#discussion_r2049175562 ## pinot-controller/src/main/resources/app/pages/TenantDetails.tsx: ## @@ -466,6 +466,20 @@ const TenantPageDetails = ({ match }: RouteComponentProps) => {

Re: [PR] [ui][refactor] New API util - FetchRebalanceTableJobs [pinot]

2025-04-17 Thread via GitHub
somandal merged PR #15581: URL: https://github.com/apache/pinot/pull/15581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch master updated: Create new API util - FetchRebalanceTableJobs (#15581)

2025-04-17 Thread somandal
This is an automated email from the ASF dual-hosted git repository. somandal pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 1f4f3e46e7 Create new API util - FetchRebalance

[PR] update docker compose file [pinot]

2025-04-17 Thread via GitHub
xiangfu0 opened a new pull request, #15583: URL: https://github.com/apache/pinot/pull/15583 updated the image version and adding minion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Bump software.amazon.awssdk:bom from 2.31.22 to 2.31.23 [pinot]

2025-04-17 Thread via GitHub
codecov-commenter commented on PR #15582: URL: https://github.com/apache/pinot/pull/15582#issuecomment-2812639107 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15582?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Bump software.amazon.awssdk:bom from 2.31.22 to 2.31.23 [pinot]

2025-04-17 Thread via GitHub
dependabot[bot] opened a new pull request, #15582: URL: https://github.com/apache/pinot/pull/15582 Bumps software.amazon.awssdk:bom from 2.31.22 to 2.31.23. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- |

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.31.23 created (now c859ac3bc4)

2025-04-17 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.31.23 in repository https://gitbox.apache.org/repos/asf/pinot.git at c859ac3bc4 Bump software.amazon.awssdk:bom from 2.31.22 to 2.31.23 N

Re: [PR] Logical table CRUD operations. [pinot]

2025-04-17 Thread via GitHub
vrajat commented on code in PR #15515: URL: https://github.com/apache/pinot/pull/15515#discussion_r2048481715 ## pinot-common/src/main/java/org/apache/pinot/common/utils/LogicalTableUtils.java: ## @@ -0,0 +1,121 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

(pinot) branch master updated: Fixes rebalance server status rendering (#15554)

2025-04-17 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new f514c54c41 Fixes rebalance server status renderin

Re: [PR] Logical table CRUD operations. [pinot]

2025-04-17 Thread via GitHub
abhishekbafna commented on code in PR #15515: URL: https://github.com/apache/pinot/pull/15515#discussion_r2048419062 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java: ## @@ -152,6 +154,21 @@ public static ControllerTest getInstance() {

Re: [PR] [Priority Replica Group Routing] Support orderedPreferredReplicas query option for customizable routing strategy [pinot]

2025-04-17 Thread via GitHub
wirybeaver commented on code in PR #15203: URL: https://github.com/apache/pinot/pull/15203#discussion_r2048320915 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/adaptiveserverselector/PriorityGroupInstanceSelector.java: ## @@ -0,0 +1,194 @@ +/** + * Licensed to th