Jackie-Jiang commented on code in PR #15358:
URL: https://github.com/apache/pinot/pull/15358#discussion_r2049554330
##########
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##########
@@ -72,6 +72,10 @@ public class ControllerConf extends PinotConfiguration {
public static final String LEAD_CONTROLLER_RESOURCE_REBALANCE_STRATEGY =
"controller.resource.rebalance.strategy";
public static final String LEAD_CONTROLLER_RESOURCE_REBALANCE_DELAY_MS =
"controller.resource.rebalance.delay_ms";
+ //boolean Check if dataDir is avaiable on boot?
+ public static final String CONTINUE_WITHOUT_DEEP_STORE =
"controller.startup.continueWithoutDeepStore";
+
Review Comment:
(minor) Remove one empty line
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/ControllerFilePathProvider.java:
##########
@@ -66,13 +66,23 @@ private ControllerFilePathProvider(ControllerConf
controllerConf)
try {
_dataDirURI = URIUtils.getUri(dataDir);
LOGGER.info("Data directory: {}", _dataDirURI);
-
- PinotFS pinotFS = PinotFSFactory.create(_dataDirURI.getScheme());
- if (pinotFS.exists(_dataDirURI)) {
- Preconditions
- .checkState(pinotFS.isDirectory(_dataDirURI), "Data directory: %s
must be a directory", _dataDirURI);
- } else {
- Preconditions.checkState(pinotFS.mkdir(_dataDirURI), "Failed to create
data directory: %s", _dataDirURI);
+ try {
+ PinotFS pinotFS = PinotFSFactory.create(_dataDirURI.getScheme());
Review Comment:
(minor) Reformat the code with [Pinot
Style](https://docs.pinot.apache.org/developers/developers-and-contributors/code-setup#set-up-ide)
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/ControllerFilePathProvider.java:
##########
@@ -66,13 +66,23 @@ private ControllerFilePathProvider(ControllerConf
controllerConf)
try {
_dataDirURI = URIUtils.getUri(dataDir);
LOGGER.info("Data directory: {}", _dataDirURI);
-
- PinotFS pinotFS = PinotFSFactory.create(_dataDirURI.getScheme());
- if (pinotFS.exists(_dataDirURI)) {
- Preconditions
- .checkState(pinotFS.isDirectory(_dataDirURI), "Data directory: %s
must be a directory", _dataDirURI);
- } else {
- Preconditions.checkState(pinotFS.mkdir(_dataDirURI), "Failed to create
data directory: %s", _dataDirURI);
+ try {
+ PinotFS pinotFS = PinotFSFactory.create(_dataDirURI.getScheme());
+ if (pinotFS.exists(_dataDirURI)) {
+ Preconditions
Review Comment:
We can move the `controllerConf.continueWithoutDeepStore()` check under this
branch
##########
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##########
@@ -538,6 +542,10 @@ public boolean isUpdateSegmentStateModel() {
return getProperty(UPDATE_SEGMENT_STATE_MODEL, false);
}
+ public boolean continueWithoutDeepStore() {
Review Comment:
(minor)
```suggestion
public boolean isContinueWithoutDeepStore() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
