Re: [PR] [timeseries] Add Support for Partial Aggregate and Complex Intermediate Type [pinot]

2024-12-10 Thread via GitHub
codecov-commenter commented on PR #14631: URL: https://github.com/apache/pinot/pull/14631#issuecomment-2533696984 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14631?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add BETWEEN support to NumericalFilterOptimizer [pinot]

2024-12-10 Thread via GitHub
yashmayya commented on code in PR #14163: URL: https://github.com/apache/pinot/pull/14163#discussion_r1792979784 ## pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java: ## @@ -346,6 +365,156 @@ private static Expression rewriteRan

[PR] [timeseries] Add Support for Partial Aggregate and Complex Intermediate Type [pinot]

2024-12-10 Thread via GitHub
ankitsultana opened a new pull request, #14631: URL: https://github.com/apache/pinot/pull/14631 WIP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-12-10 Thread via GitHub
vrajat commented on PR #14110: URL: https://github.com/apache/pinot/pull/14110#issuecomment-2533647419 Pending discussions: - shared-nothing vs shared-storage - cursor response constructor - Naming - Response Store - Auth config param -- This is an automated message from the Ap

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-12-10 Thread via GitHub
vrajat commented on PR #14110: URL: https://github.com/apache/pinot/pull/14110#issuecomment-2533642293 I have added javadoc in `ResponseStore` to emphasis that there is a response store per broker and it is assumed that it is a shared-nothing storage. This is far more simpler and from exper

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-12-10 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1879342446 ## pinot-common/src/main/java/org/apache/pinot/common/cursors/AbstractResponseStore.java: ## @@ -0,0 +1,264 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] include reason why TableSegmentValidationInfo is invalid [pinot]

2024-12-10 Thread via GitHub
jadami10 commented on code in PR #14612: URL: https://github.com/apache/pinot/pull/14612#discussion_r1879333029 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -1256,8 +1256,9 @@ private long validateSegmentStateF

Re: [PR] Expose QueryScheduler from ServerInstance [pinot]

2024-12-10 Thread via GitHub
codecov-commenter commented on PR #14630: URL: https://github.com/apache/pinot/pull/14630#issuecomment-2533595117 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14630?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Expose QueryScheduler from ServerInstance [pinot]

2024-12-10 Thread via GitHub
praveenc7 opened a new pull request, #14630: URL: https://github.com/apache/pinot/pull/14630 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-incompat`

Re: [I] Hadoop based batch ingestion is not able to start job because of jetty related classes loading from pinot. [pinot]

2024-12-10 Thread via GitHub
chrajeshbabu commented on issue #14552: URL: https://github.com/apache/pinot/issues/14552#issuecomment-2533385724 Able to make the job gets started by excluding the dependency causing org.apache.hadoop.yarn.webapp.WebApps$Builder.start(WebApps.java:472) loading from pinot jar which leads

Re: [PR] Upsert small segment merger task in minions [pinot]

2024-12-10 Thread via GitHub
ankitsultana commented on code in PR #14477: URL: https://github.com/apache/pinot/pull/14477#discussion_r1879085302 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutor.java: #

Re: [PR] Upsert small segment merger task in minions [pinot]

2024-12-10 Thread via GitHub
ankitsultana commented on code in PR #14477: URL: https://github.com/apache/pinot/pull/14477#discussion_r1879069977 ## pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java: ## @@ -199,4 +200,59 @@ public static class UpsertCompactionTask { */ pub

(pinot) branch master updated: Fix flaky quota integration tests (#14602)

2024-12-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new b4066fbd40 Fix flaky quota integration tests (#14

Re: [PR] Fix flaky quota integration tests [pinot]

2024-12-10 Thread via GitHub
Jackie-Jiang merged PR #14602: URL: https://github.com/apache/pinot/pull/14602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] include reason why TableSegmentValidationInfo is invalid [pinot]

2024-12-10 Thread via GitHub
Jackie-Jiang commented on code in PR #14612: URL: https://github.com/apache/pinot/pull/14612#discussion_r1878946618 ## pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/TableSegmentValidationInfo.java: ## @@ -41,4 +44,8 @@ public boolean isValid() { public

Re: [I] Support AvgPrecision Aggregate function [pinot]

2024-12-10 Thread via GitHub
ilamhs commented on issue #14545: URL: https://github.com/apache/pinot/issues/14545#issuecomment-2532826617 @ashishjayamohan Please do raise a PR 👍 FYI: @zeronerdzerogeekzerocool -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Fix H3 index boundary calculations. [pinot]

2024-12-10 Thread via GitHub
Jackie-Jiang commented on code in PR #14628: URL: https://github.com/apache/pinot/pull/14628#discussion_r1878763687 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/H3IndexFilterOperator.java: ## @@ -78,7 +78,15 @@ public H3IndexFilterOperator(IndexSegment segme

Re: [I] Support AvgPrecision Aggregate function [pinot]

2024-12-10 Thread via GitHub
ashishjayamohan commented on issue #14545: URL: https://github.com/apache/pinot/issues/14545#issuecomment-2532651118 @ilamhs Mind if I take a swing at this? I already have the changes ready for a PR. No worries if you're already working on it. -- This is an automated message from the Apac

[I] Count(*) returns empty response when there are no segments [pinot]

2024-12-10 Thread via GitHub
rohityadav1993 opened a new issue, #14629: URL: https://github.com/apache/pinot/issues/14629 when doing a `select count(*) from table_name` query on a table with no segments, the response is empty instead of 0. This is a correct behavour for non aggregation queries but for general ag

Re: [PR] [timeseries] Part-3: Add Time Series Exchange Operator, Plan Node and Serde [pinot]

2024-12-10 Thread via GitHub
tibrewalpratik17 merged PR #14611: URL: https://github.com/apache/pinot/pull/14611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@p

(pinot) branch master updated: [timeseries] Part-3: Add Time Series Exchange Operator, Plan Node and Serde (#14611)

2024-12-10 Thread pratik
This is an automated email from the ASF dual-hosted git repository. pratik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 1b5858b5b4 [timeseries] Part-3: Add Time Series E

Re: [PR] Fix H3 index boundary calculations. [pinot]

2024-12-10 Thread via GitHub
codecov-commenter commented on PR #14628: URL: https://github.com/apache/pinot/pull/14628#issuecomment-2532111553 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14628?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Fix H3 index boundary calculations. [pinot]

2024-12-10 Thread via GitHub
bziobrowski opened a new pull request, #14628: URL: https://github.com/apache/pinot/pull/14628 PR fixes H3IndexFilterOperator's accuracy when used with ST_Distance function. Calculations in master branch are inaccurate because: - hexagon size in is not constant per level, so using

Re: [PR] [timeseries] Part-3: Add Time Series Exchange Operator, Plan Node and Serde [pinot]

2024-12-10 Thread via GitHub
ankitsultana commented on code in PR #14611: URL: https://github.com/apache/pinot/pull/14611#discussion_r1878237795 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/timeseries/serde/TimeSeriesBlockSerde.java: ## @@ -0,0 +1,203 @@ +/** + * Licensed to the Apach

Re: [PR] Adds Support of maxNumRowsPerTask in RTO Generator and Fixes Bugs [pinot]

2024-12-10 Thread via GitHub
swaminathanmanish commented on code in PR #14623: URL: https://github.com/apache/pinot/pull/14623#discussion_r1878219843 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/realtimetoofflinesegments/RealtimeToOfflineSegmentsT

Re: [PR] Add query request ID to log lines for slow / large queries [pinot]

2024-12-10 Thread via GitHub
codecov-commenter commented on PR #14627: URL: https://github.com/apache/pinot/pull/14627#issuecomment-2531698564 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14627?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Add query request ID to log lines for slow / large queries [pinot]

2024-12-10 Thread via GitHub
yashmayya opened a new pull request, #14627: URL: https://github.com/apache/pinot/pull/14627 - Currently, these log lines don't include any information on the exact query (apart from the table name which isn't too useful just by itself). - This minor patch includes the query's request ID

(pinot) branch master updated (442c0fc713 -> 1641a6d4bf)

2024-12-10 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 442c0fc713 Configurable sketch accuracy in merge rollup task (#14373) add 1641a6d4bf Bump software.amazon.awssd

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.29.30 deleted (was d41b1bb1d8)

2024-12-10 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.29.30 in repository https://gitbox.apache.org/repos/asf/pinot.git was d41b1bb1d8 Bump software.amazon.awssdk:bom from 2.29.29 to 2.29.30 Th

Re: [PR] Bump software.amazon.awssdk:bom from 2.29.29 to 2.29.30 [pinot]

2024-12-10 Thread via GitHub
yashmayya merged PR #14626: URL: https://github.com/apache/pinot/pull/14626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [PR] Upsert small segment merger task in minions [pinot]

2024-12-10 Thread via GitHub
tibrewalpratik17 commented on code in PR #14477: URL: https://github.com/apache/pinot/pull/14477#discussion_r1877937813 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutor.jav

Re: [PR] Feature: Extend Merge Rollup Capabilities for Datasketches [pinot]

2024-12-10 Thread via GitHub
codecov-commenter commented on PR #14625: URL: https://github.com/apache/pinot/pull/14625#issuecomment-2531334222 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14625?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.29.30 created (now d41b1bb1d8)

2024-12-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.29.30 in repository https://gitbox.apache.org/repos/asf/pinot.git at d41b1bb1d8 Bump software.amazon.awssdk:bom from 2.29.29 to 2.29.30 N

[PR] Bump software.amazon.awssdk:bom from 2.29.29 to 2.29.30 [pinot]

2024-12-10 Thread via GitHub
dependabot[bot] opened a new pull request, #14626: URL: https://github.com/apache/pinot/pull/14626 Bumps software.amazon.awssdk:bom from 2.29.29 to 2.29.30. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- |

[PR] Feature: Extend Merge Rollup Capabilities for Datasketches [pinot]

2024-12-10 Thread via GitHub
davecromberge opened a new pull request, #14625: URL: https://github.com/apache/pinot/pull/14625 Feature Give the user more control over how sketches are merged in different time buckets for the Merge Rollup Task. Examples where this could be helpful is if the user

Re: [PR] [timeseries] Part-3: Add Time Series Exchange Operator, Plan Node and Serde [pinot]

2024-12-10 Thread via GitHub
tibrewalpratik17 commented on code in PR #14611: URL: https://github.com/apache/pinot/pull/14611#discussion_r1877868802 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/timeseries/serde/TimeSeriesBlockSerde.java: ## @@ -0,0 +1,203 @@ +/** + * Licensed to the A

Re: [PR] [timeseries] Part-3: Add Time Series Exchange Operator, Plan Node and Serde [pinot]

2024-12-10 Thread via GitHub
tibrewalpratik17 commented on code in PR #14611: URL: https://github.com/apache/pinot/pull/14611#discussion_r1877862949 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/timeseries/serde/TimeSeriesBlockSerde.java: ## @@ -0,0 +1,203 @@ +/** + * Licensed to the A

Re: [PR] [timeseries] Part-3: Add Time Series Exchange Operator, Plan Node and Serde [pinot]

2024-12-10 Thread via GitHub
tibrewalpratik17 commented on code in PR #14611: URL: https://github.com/apache/pinot/pull/14611#discussion_r1877850019 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/timeseries/serde/TimeSeriesBlockSerde.java: ## @@ -0,0 +1,203 @@ +/** + * Licensed to the A

Re: [PR] Adds Support of maxNumRowsPerTask in RTO Generator and Fixes Bugs [pinot]

2024-12-10 Thread via GitHub
Harnoor7 commented on code in PR #14623: URL: https://github.com/apache/pinot/pull/14623#discussion_r1877724647 ## pinot-common/src/main/java/org/apache/pinot/common/minion/RealtimeToOfflineSegmentsTaskMetadata.java: ## @@ -41,19 +47,37 @@ public class RealtimeToOfflineSegments

Re: [PR] Configurable sketch accuracy in merge rollup task [pinot]

2024-12-10 Thread via GitHub
swaminathanmanish merged PR #14373: URL: https://github.com/apache/pinot/pull/14373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

(pinot) branch master updated: Configurable sketch accuracy in merge rollup task (#14373)

2024-12-10 Thread manishswaminathan
This is an automated email from the ASF dual-hosted git repository. manishswaminathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 442c0fc713 Configurable sketch accurac