Jackie-Jiang commented on code in PR #14628:
URL: https://github.com/apache/pinot/pull/14628#discussion_r1878763687
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/H3IndexFilterOperator.java:
##########
@@ -78,7 +78,15 @@ public H3IndexFilterOperator(IndexSegment segment,
QueryContext queryContext, Pr
assert _h3IndexReader != null;
int resolution =
_h3IndexReader.getH3IndexResolution().getLowestResolution();
_h3Id = H3Utils.H3_CORE.geoToH3(coordinate.y, coordinate.x, resolution);
- _edgeLength = H3Utils.H3_CORE.edgeLength(resolution, LengthUnit.m);
+
+ // choose current hexagon's longest edge instead of average for the
resolution;
Review Comment:
Is this correct? This is just the max edge length for the center id, but not
other hexagons. If the edge length is not all the same, the fundamental
assumption doesn't hold, and we need to think for a new algorithm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
