Re: [PR] Add hex decimal to long scalar functions [pinot]

2024-11-12 Thread via GitHub
codecov-commenter commented on PR #14435: URL: https://github.com/apache/pinot/pull/14435#issuecomment-2472394504 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14435?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Add hex decimal to long scalar functions [pinot]

2024-11-12 Thread via GitHub
xiangfu0 opened a new pull request, #14435: URL: https://github.com/apache/pinot/pull/14435 Add hex decimal to long scalar functions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Enhance funnel functions to accept a new option for stepMaxDuration [pinot]

2024-11-12 Thread via GitHub
codecov-commenter commented on PR #14434: URL: https://github.com/apache/pinot/pull/14434#issuecomment-2472353362 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14434?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Enhance funnel functions to accept a new option for stepMaxDuration [pinot]

2024-11-12 Thread via GitHub
xiangfu0 opened a new pull request, #14434: URL: https://github.com/apache/pinot/pull/14434 Enhance [funnel functions](https://docs.pinot.apache.org/users/user-guide-query/query-syntax/funnel-analysis) to accept a new option for stepMaxDuration. This option `stepMaxDuration` will all

Re: [I] [Pinot 1.2.0 UI] No support for "database" construct from UI [pinot]

2024-11-12 Thread via GitHub
shounakmk219 commented on issue #14068: URL: https://github.com/apache/pinot/issues/14068#issuecomment-2472313806 Hey @NihalJain thanks a lot for taking this up! Few questions 1. What is the usecase for showing tables/schemas across all databases in one view? 2. Can we have

Re: [PR] Add instance level consumer dir usage metric [pinot]

2024-11-12 Thread via GitHub
vvivekiyer commented on code in PR #14430: URL: https://github.com/apache/pinot/pull/14430#discussion_r1839194969 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java: ## @@ -76,7 +76,8 @@ public enum ServerGauge implements AbstractMetrics.Gauge { //

Re: [PR] Optimize `NOT` Predicates By Push Down [pinot]

2024-11-12 Thread via GitHub
ashishjayamohan commented on PR #14432: URL: https://github.com/apache/pinot/pull/14432#issuecomment-2472160888 That makes sense to me too. I think it would be beneficial to have it - even if it is an option that has to be manually set. I can go ahead and add that option. -- This is an a

Re: [PR] Add instance level consumer dir usage metric [pinot]

2024-11-12 Thread via GitHub
SabrinaZhaozyf commented on code in PR #14430: URL: https://github.com/apache/pinot/pull/14430#discussion_r1839096908 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java: ## @@ -180,6 +181,24 @@ private void initInstanceDataDir(File

Re: [PR] Add instance level consumer dir usage metric [pinot]

2024-11-12 Thread via GitHub
SabrinaZhaozyf commented on code in PR #14430: URL: https://github.com/apache/pinot/pull/14430#discussion_r1839102597 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java: ## @@ -180,6 +181,24 @@ private void initInstanceDataDir(File

Re: [PR] Add instance level consumer dir usage metric [pinot]

2024-11-12 Thread via GitHub
SabrinaZhaozyf commented on code in PR #14430: URL: https://github.com/apache/pinot/pull/14430#discussion_r1839101674 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java: ## @@ -180,6 +181,24 @@ private void initInstanceDataDir(File

Re: [PR] Add instance level consumer dir usage metric [pinot]

2024-11-12 Thread via GitHub
SabrinaZhaozyf commented on code in PR #14430: URL: https://github.com/apache/pinot/pull/14430#discussion_r1839101507 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java: ## @@ -180,6 +181,24 @@ private void initInstanceDataDir(File

Re: [PR] Add instance level consumer dir usage metric [pinot]

2024-11-12 Thread via GitHub
SabrinaZhaozyf commented on code in PR #14430: URL: https://github.com/apache/pinot/pull/14430#discussion_r1839099916 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java: ## @@ -180,6 +181,24 @@ private void initInstanceDataDir(File

Re: [PR] Add instance level consumer dir usage metric [pinot]

2024-11-12 Thread via GitHub
SabrinaZhaozyf commented on code in PR #14430: URL: https://github.com/apache/pinot/pull/14430#discussion_r1839098791 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java: ## @@ -707,6 +711,23 @@ public void start() _serverQueriesDisabl

Re: [PR] Optimize `NOT` Predicates By Push Down [pinot]

2024-11-12 Thread via GitHub
codecov-commenter commented on PR #14432: URL: https://github.com/apache/pinot/pull/14432#issuecomment-2472009907 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14432?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Push Down Not Optimizer [pinot]

2024-11-12 Thread via GitHub
ashishjayamohan opened a new pull request, #14432: URL: https://github.com/apache/pinot/pull/14432 - Adds a `PushDownNotFilterOptimizer` class that pushes down `NOT` operator into group clauses - Applies DeMorgan's law to `NOT` predicates recursively to fully fragment predicate group

Re: [PR] Controller AccessControl interface accepts Request parameter [pinot]

2024-11-12 Thread via GitHub
ilamhs commented on PR #14414: URL: https://github.com/apache/pinot/pull/14414#issuecomment-2471227616 The failing Integration Tests seem to be unrelated to the code in the PR above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Add instance level consumer dir usage metric [pinot]

2024-11-12 Thread via GitHub
jasperjiaguo commented on code in PR #14430: URL: https://github.com/apache/pinot/pull/14430#discussion_r1838620339 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java: ## @@ -180,6 +181,24 @@ private void initInstanceDataDir(File in

Re: [PR] Add instance level consumer dir usage metric [pinot]

2024-11-12 Thread via GitHub
vvivekiyer commented on code in PR #14430: URL: https://github.com/apache/pinot/pull/14430#discussion_r1838747910 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java: ## @@ -180,6 +181,24 @@ private void initInstanceDataDir(File inst

Re: [PR] Add instance level consumer dir usage metric [pinot]

2024-11-12 Thread via GitHub
codecov-commenter commented on PR #14430: URL: https://github.com/apache/pinot/pull/14430#issuecomment-2471353767 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14430?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add instance level consumer dir usage metric [pinot]

2024-11-12 Thread via GitHub
jasperjiaguo commented on code in PR #14430: URL: https://github.com/apache/pinot/pull/14430#discussion_r1838620339 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java: ## @@ -180,6 +181,24 @@ private void initInstanceDataDir(File in

Re: [PR] Add instance level consumer dir usage metric [pinot]

2024-11-12 Thread via GitHub
sajjad-moradi commented on code in PR #14430: URL: https://github.com/apache/pinot/pull/14430#discussion_r1838620812 ## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java: ## @@ -707,6 +711,23 @@ public void start() _serverQueriesDisable

[PR] Add instance level consumer dir usage metric [pinot]

2024-11-12 Thread via GitHub
SabrinaZhaozyf opened a new pull request, #14430: URL: https://github.com/apache/pinot/pull/14430 Recently, we have seen java.lang.[InternalError](https://stackoverflow.com/questions/45536049/java-lang-internalerror-a-fault-occurred-in-a-recent-unsafe-memory-access-opera) on RT servers whic

(pinot) branch master updated: Remove emitting null value fields during data transformation for SchemaConformingTransformer (#14351)

2024-11-12 Thread tingchen
This is an automated email from the ASF dual-hosted git repository. tingchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 447c518712 Remove emitting null value fields du

Re: [PR] Remove emitting null value fields during data transformation for SchemaConformingTransformer [pinot]

2024-11-12 Thread via GitHub
chenboat merged PR #14351: URL: https://github.com/apache/pinot/pull/14351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [I] Reduce the amount of trace info [pinot]

2024-11-12 Thread via GitHub
soupam05 commented on issue #9523: URL: https://github.com/apache/pinot/issues/9523#issuecomment-2471264651 I can pickup this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Using local copy of segment instead of downloading from remote [pinot]

2024-11-12 Thread via GitHub
codecov-commenter commented on PR #14429: URL: https://github.com/apache/pinot/pull/14429#issuecomment-2471223313 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14429?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [I] Pauseless Consumption [pinot]

2024-11-12 Thread via GitHub
mcvsubbu commented on issue #10147: URL: https://github.com/apache/pinot/issues/10147#issuecomment-2471187891 > @mcvsubbu > > 1. In ZooKeeper, segment metadata will use **COMMITTING** as the status for segments being built, distinguishing them from **DONE** segments that are alre

[PR] Using local copy of segment instead of downloading from remote [pinot]

2024-11-12 Thread via GitHub
rajagopr opened a new pull request, #14429: URL: https://github.com/apache/pinot/pull/14429 Re-introducing [PR-12863](https://github.com/apache/pinot/pull/12863) post testing in an internal cluster. ### Testing **Minion Logs** ``` 2024/11/12 17:04:12.231 INFO [FileIngesti

Re: [I] Add change streams to tables [pinot]

2024-11-12 Thread via GitHub
PeterCorless commented on issue #10573: URL: https://github.com/apache/pinot/issues/10573#issuecomment-2471031766 Change Data Capture (CDC) is non-trivial functionality. Do you just provide the latest version of the record? Do you provide the pre-image? Can you just show the diffs? Is it qu

(pinot) branch master updated: Cleanup UpsertCompaction validations during task-generation (#14424)

2024-11-12 Thread manishswaminathan
This is an automated email from the ASF dual-hosted git repository. manishswaminathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 0180a11bba Cleanup UpsertCompaction va

Re: [PR] Cleanup UpsertCompaction validations during task-generation [pinot]

2024-11-12 Thread via GitHub
swaminathanmanish merged PR #14424: URL: https://github.com/apache/pinot/pull/14424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

Re: [PR] Merge RecordEnricher into RecordTransformer [pinot]

2024-11-12 Thread via GitHub
shounakmk219 commented on PR #13704: URL: https://github.com/apache/pinot/pull/13704#issuecomment-2470846967 Hey @aadilkhalifa, wanted to check if you would be taking these changes to completion? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [I] [Pinot 1.2.0 UI] No support for "database" construct from UI [pinot]

2024-11-12 Thread via GitHub
NihalJain commented on issue #14068: URL: https://github.com/apache/pinot/issues/14068#issuecomment-2470803785 Hi @ajeydudhe, @Jackie-Jiang, @shounakmk219, @npawar Any thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

(pinot) branch master updated: Fix long value parsing in jsonextractscalar (#14337)

2024-11-12 Thread gortiz
This is an automated email from the ASF dual-hosted git repository. gortiz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 013e80f968 Fix long value parsing in jsonextracts

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-12 Thread via GitHub
gortiz merged PR #14337: URL: https://github.com/apache/pinot/pull/14337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

Re: [I] Pauseless Consumption [pinot]

2024-11-12 Thread via GitHub
9aman commented on issue #10147: URL: https://github.com/apache/pinot/issues/10147#issuecomment-2470474663 @mcvsubbu 1. In ZooKeeper, segment metadata will use **COMMITTING** as the status for segments being built, distinguishing them from **DONE** segments that are already in deep stor

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.29.10 created (now e30b6236c0)

2024-11-12 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.29.10 in repository https://gitbox.apache.org/repos/asf/pinot.git at e30b6236c0 Bump software.amazon.awssdk:bom from 2.29.5 to 2.29.10 No

Re: [PR] Bump software.amazon.awssdk:bom from 2.29.5 to 2.29.9 [pinot]

2024-11-12 Thread via GitHub
dependabot[bot] closed pull request #14420: Bump software.amazon.awssdk:bom from 2.29.5 to 2.29.9 URL: https://github.com/apache/pinot/pull/14420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump software.amazon.awssdk:bom from 2.29.5 to 2.29.9 [pinot]

2024-11-12 Thread via GitHub
dependabot[bot] commented on PR #14420: URL: https://github.com/apache/pinot/pull/14420#issuecomment-2470282759 Superseded by #14428. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Bump software.amazon.awssdk:bom from 2.29.5 to 2.29.10 [pinot]

2024-11-12 Thread via GitHub
dependabot[bot] opened a new pull request, #14428: URL: https://github.com/apache/pinot/pull/14428 Bumps software.amazon.awssdk:bom from 2.29.5 to 2.29.10. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- |

(pinot) branch dependabot/maven/parquet.version-1.14.4 created (now f0af61a7f3)

2024-11-12 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/parquet.version-1.14.4 in repository https://gitbox.apache.org/repos/asf/pinot.git at f0af61a7f3 Bump parquet.version from 1.14.3 to 1.14.4 No new revisions were added

[PR] Bump parquet.version from 1.14.3 to 1.14.4 [pinot]

2024-11-12 Thread via GitHub
dependabot[bot] opened a new pull request, #14427: URL: https://github.com/apache/pinot/pull/14427 Bumps `parquet.version` from 1.14.3 to 1.14.4. Updates `org.apache.parquet:parquet-avro` from 1.14.3 to 1.14.4 Release notes Sourced from https://github.com/apache/parquet-mr/releas

(pinot) branch master updated: [timeseries] Fix Server Selection Bug + Enforce Timeout (#14426)

2024-11-12 Thread pratik
This is an automated email from the ASF dual-hosted git repository. pratik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new a8a0a33864 [timeseries] Fix Server Selection Bug

Re: [PR] [timeseries] Fix Server Selection Bug + Enforce Timeout [pinot]

2024-11-12 Thread via GitHub
tibrewalpratik17 merged PR #14426: URL: https://github.com/apache/pinot/pull/14426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@p

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-12 Thread via GitHub
bziobrowski commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1837772550 ## pinot-core/src/main/java/org/apache/pinot/core/util/NumberUtils.java: ## @@ -0,0 +1,224 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-12 Thread via GitHub
gortiz commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1837709046 ## pinot-core/src/main/java/org/apache/pinot/core/util/NumberUtils.java: ## @@ -0,0 +1,224 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-12 Thread via GitHub
bziobrowski commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1837700145 ## pinot-core/src/main/java/org/apache/pinot/core/util/NumberUtils.java: ## @@ -0,0 +1,224 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Fix long value parsing in jsonextractscalar [pinot]

2024-11-12 Thread via GitHub
bziobrowski commented on code in PR #14337: URL: https://github.com/apache/pinot/pull/14337#discussion_r1837700145 ## pinot-core/src/main/java/org/apache/pinot/core/util/NumberUtils.java: ## @@ -0,0 +1,224 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one +