vvivekiyer commented on code in PR #14430:
URL: https://github.com/apache/pinot/pull/14430#discussion_r1839194969
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java:
##########
@@ -76,7 +76,8 @@ public enum ServerGauge implements AbstractMetrics.Gauge {
// Needed to track if valid doc id snapshots are present for faster restarts
UPSERT_VALID_DOC_ID_SNAPSHOT_COUNT("upsertValidDocIdSnapshotCount", false),
UPSERT_PRIMARY_KEYS_IN_SNAPSHOT_COUNT("upsertPrimaryKeysInSnapshotCount",
false),
- REALTIME_INGESTION_OFFSET_LAG("offsetLag", false);
+ REALTIME_INGESTION_OFFSET_LAG("offsetLag", false),
+ CONSUMER_DIR_USAGE("bytes", true);
Review Comment:
(nit) can we name it as `REALTIME_CONSUMER_DIR_USAGE`?
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -102,7 +102,7 @@ public class RealtimeTableDataManager extends
BaseTableDataManager {
// The old name of the stats file used to be stats.ser which we changed when
we moved all packages
// from com.linkedin to org.apache because of not being able to deserialize
the old files using the newer classes
private static final String STATS_FILE_NAME = "segment-stats.ser";
- private static final String CONSUMERS_DIR = "consumers";
+ public static final String CONSUMERS_DIR = "consumers";
Review Comment:
Can we revert this to `private` now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
