Re: [I] ImmutableTableOptions and ImmutableQueryEnvironment not found [pinot]

2024-10-21 Thread via GitHub
chunxiaozheng closed issue #14261: ImmutableTableOptions and ImmutableQueryEnvironment not found URL: https://github.com/apache/pinot/issues/14261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] ImmutableTableOptions and ImmutableQueryEnvironment not found [pinot]

2024-10-21 Thread via GitHub
chunxiaozheng commented on issue #14261: URL: https://github.com/apache/pinot/issues/14261#issuecomment-2428145179 > You have to compile the code at least once to generate these classes. If you are running it in intellij, be sure you it updates the code once maven has compiled it. Th

[I] Refactor to eliminate duplicate code in Spark 2.x and 3.x Batch Ingestion [pinot]

2024-10-21 Thread via GitHub
chrajeshbabu opened a new issue, #14271: URL: https://github.com/apache/pinot/issues/14271 Currently between spark 2.x and spark 3.x batch ingestion lot of code is duplicated other than SparkSegmentMetadataPushJobRunner class. This ticket is to refactor the code to eliminate the duplicat

Re: [PR] Fixing the vulnerabilities of amazon corretto pinot-base-runtime docker image. [pinot]

2024-10-21 Thread via GitHub
abhioncbr commented on PR #14042: URL: https://github.com/apache/pinot/pull/14042#issuecomment-2428043284 Amazon Corretto JDK docker images are only available on Amazon Linux and Alpine flavour. They do have the Debian based docker files in the repo, however they don't publish it. Here is t

Re: [PR] Start Kafka after zookeeper in integration tests [pinot]

2024-10-21 Thread via GitHub
xiangfu0 commented on PR #14270: URL: https://github.com/apache/pinot/pull/14270#issuecomment-2427943924 Saw errors like this: ``` Oct 21, 2024 11:43:47 PM io.grpc.internal.ServerCallImpl handleInternalError 23:43:47.045 ERROR [OpChainSchedulerService] [query-runner-on-45967-1-thre

(pinot) branch master updated: Adding more debug logs in BaseClusterIntegrationTestSet testReload method (#14269)

2024-10-21 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new f57648428c Adding more debug logs in BaseCluster

Re: [PR] Add more debug logs in BaseClusterIntegrationTestSet.testReload() method [pinot]

2024-10-21 Thread via GitHub
xiangfu0 merged PR #14269: URL: https://github.com/apache/pinot/pull/14269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Start Kafka after zookeeper in integration tests [pinot]

2024-10-21 Thread via GitHub
codecov-commenter commented on PR #14270: URL: https://github.com/apache/pinot/pull/14270#issuecomment-2427936744 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14270?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Start Kafka after zookeeper in integration tests [pinot]

2024-10-21 Thread via GitHub
xiangfu0 opened a new pull request, #14270: URL: https://github.com/apache/pinot/pull/14270 Start Kafka after zookeeper in integration tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Fixed integer division in floating-point context [pinot]

2024-10-21 Thread via GitHub
soumitra-st closed pull request #14267: Fixed integer division in floating-point context URL: https://github.com/apache/pinot/pull/14267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(pinot) branch master updated (1f8fd632c0 -> 633e83ce8d)

2024-10-21 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 1f8fd632c0 [Feature] Enable the capability to specify zstd and lz4 segment compression via config (#14008) add 6

Re: [PR] Enhance Cleanup logic in QuickStart CI jobs [pinot]

2024-10-21 Thread via GitHub
xiangfu0 merged PR #14268: URL: https://github.com/apache/pinot/pull/14268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Add more debug logs in BaseClusterIntegrationTestSet.testReload() method [pinot]

2024-10-21 Thread via GitHub
codecov-commenter commented on PR #14269: URL: https://github.com/apache/pinot/pull/14269#issuecomment-2427881834 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14269?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Enhance Cleanup logic in QuickStart CI jobs [pinot]

2024-10-21 Thread via GitHub
codecov-commenter commented on PR #14268: URL: https://github.com/apache/pinot/pull/14268#issuecomment-2427870556 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14268?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Adding more debug logs in BaseClusterIntegrationTestSet.testReload() method [pinot]

2024-10-21 Thread via GitHub
xiangfu0 opened a new pull request, #14269: URL: https://github.com/apache/pinot/pull/14269 Adding more debug logs in BaseClusterIntegrationTestSet.testReload() method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[PR] Cleanup temp data directory for QuickStart CI jobs [pinot]

2024-10-21 Thread via GitHub
xiangfu0 opened a new pull request, #14268: URL: https://github.com/apache/pinot/pull/14268 Cleanup temp data directory for QuickStart CI jobs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fixed integer division in floating-point context [pinot]

2024-10-21 Thread via GitHub
soumitra-st commented on code in PR #14267: URL: https://github.com/apache/pinot/pull/14267#discussion_r1809537045 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/FixedBitMVForwardIndexWriter.java: ## @@ -76,7 +76,7 @@ public class FixedBitMVFo

[PR] Fixed integer division in floating-point context [pinot]

2024-10-21 Thread via GitHub
soumitra-st opened a new pull request, #14267: URL: https://github.com/apache/pinot/pull/14267 ``` 2024/10/19 07:44:26.782 ERROR [RealtimeSegmentDataManager_owner5__12__65__20241018T0744Z] [owner5__12__65__20241018T0744Z] Could not build segment java.lang.ArithmeticException: / by zer

Re: [PR] Test Cases for JMX -> Prom Exporter Regexps [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14155: URL: https://github.com/apache/pinot/pull/14155#discussion_r1809500324 ## pinot-common/pom.xml: ## @@ -107,6 +107,10 @@ + Review Comment: Should the dependencies added here be in `test` scope ? -- This is an autom

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809481301 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,206 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809482947 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809481882 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809482412 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809480332 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,206 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809474593 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,206 @@ +/** + * Licensed to the Apache Software Foundation

(pinot) branch master updated: [Feature] Enable the capability to specify zstd and lz4 segment compression via config (#14008)

2024-10-21 Thread lqc
This is an automated email from the ASF dual-hosted git repository. lqc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 1f8fd632c0 [Feature] Enable the capability to specif

Re: [PR] [Feature] Enable the capability to specify zstd and lz4 segment compression via config [pinot]

2024-10-21 Thread via GitHub
deemoliu merged PR #14008: URL: https://github.com/apache/pinot/pull/14008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch dependabot/maven/it.unimi.dsi-fastutil-8.5.15 deleted (was a919c34035)

2024-10-21 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/it.unimi.dsi-fastutil-8.5.15 in repository https://gitbox.apache.org/repos/asf/pinot.git was a919c34035 Bump it.unimi.dsi:fastutil from 8.5.14 to 8.5.15 The revisions that

(pinot) branch master updated (6c84443109 -> f278e2e1c7)

2024-10-21 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 6c84443109 Bump com.google.errorprone:error_prone_annotations from 2.33.0 to 2.34.0 (#14262) add f278e2e1c7 Bump

Re: [PR] Bump it.unimi.dsi:fastutil from 8.5.14 to 8.5.15 [pinot]

2024-10-21 Thread via GitHub
Jackie-Jiang merged PR #14263: URL: https://github.com/apache/pinot/pull/14263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Bump com.google.errorprone:error_prone_annotations from 2.33.0 to 2.34.0 [pinot]

2024-10-21 Thread via GitHub
Jackie-Jiang merged PR #14262: URL: https://github.com/apache/pinot/pull/14262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/com.google.errorprone-error_prone_annotations-2.34.0 deleted (was 59ed6eaaa6)

2024-10-21 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.google.errorprone-error_prone_annotations-2.34.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 59ed6eaaa6 Bump com.google.errorprone:error_prone_annot

(pinot) branch master updated: Bump com.google.errorprone:error_prone_annotations from 2.33.0 to 2.34.0 (#14262)

2024-10-21 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 6c84443109 Bump com.google.errorprone:error_prone

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809420734 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -1261,4 +1268,23 @@ public static class NullValuePlaceHolder { public static final

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809406416 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -1261,4 +1268,23 @@ public static class NullValuePlaceHolder { public static final

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809397193 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -1261,4 +1268,23 @@ public static class NullValuePlaceHolder { public static final

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809393889 ## pinot-common/src/main/java/org/apache/pinot/common/response/CursorResponse.java: ## @@ -0,0 +1,132 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809382280 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BrokerRequestHandlerDelegate.java: ## @@ -46,13 +50,23 @@ public class BrokerRequestHandlerDelegate

Re: [PR] Add missing precondition check for V5 writer version in BaseChunkForwardIndexWriter [pinot]

2024-10-21 Thread via GitHub
xiangfu0 merged PR #14265: URL: https://github.com/apache/pinot/pull/14265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch master updated (751a0b9423 -> 0382dea173)

2024-10-21 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 751a0b9423 Cleanup remaining test usage of setters in IndexLoadingConfig (#14256) add 0382dea173 Enable v5 write

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809357555 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809350980 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809336954 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809337358 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809318643 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809299243 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809296586 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809283976 ## pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java: ## @@ -346,9 +352,38 @@ public void start() timeSeriesRequestHandler =

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809275481 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java: ## @@ -221,6 +230,8 @@ public void processSqlWithMultiStageQueryEngineGet(

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809278038 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java: ## @@ -221,6 +230,8 @@ public void processSqlWithMultiStageQueryEngineGet(

[I] "Authorization Failed" for BROKER users created via API having rights for "ALL" tables [pinot]

2024-10-21 Thread via GitHub
johannesploetner opened a new issue, #14266: URL: https://github.com/apache/pinot/issues/14266 In Pinot 1.2.0, user creation via REST API seems broken when "ZkBasicAuthAccessControlFactory" is activated. How to reproduce: - start pinot 1.2.0 (i.e. using docker-compose) and with

Re: [PR] Add missing precondition check for V5 writer version in BaseChunkForwardIndexWriter [pinot]

2024-10-21 Thread via GitHub
codecov-commenter commented on PR #14265: URL: https://github.com/apache/pinot/pull/14265#issuecomment-2427354159 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14265?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add support for application-level query quota. [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1809168697 ## pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java: ## @@ -758,4 +768,81 @@ public static boolean getClusterTenantIsolationEnabled(Z

Re: [PR] Add IGNORE NULLS option to FIRST_VALUE and LAST_VALUE window functions [pinot]

2024-10-21 Thread via GitHub
codecov-commenter commented on PR #14264: URL: https://github.com/apache/pinot/pull/14264#issuecomment-2427304736 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14264?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Add missing precondition check for V5 writer version in BaseChunkForwardIndexWriter [pinot]

2024-10-21 Thread via GitHub
jackluo923 opened a new pull request, #14265: URL: https://github.com/apache/pinot/pull/14265 This PR adds a missing precondition check for the V5 writer version introduced in [PR #14105](https://github.com/apache/pinot/pull/14105). Specifically, it ensures proper handling of the V5 writer

[PR] Window function ignore nulls [pinot]

2024-10-21 Thread via GitHub
yashmayya opened a new pull request, #14264: URL: https://github.com/apache/pinot/pull/14264 - The SQL standard defines a `RESPECT NULLS` or `IGNORE NULLS` option for the window functions `LEAD`, `LAG`, `FIRST_VALUE`, `LAST_VALUE`, and `NTH_VALUE` (although Pinot currently doesn't support t

(pinot) branch master updated (75907372b0 -> 751a0b9423)

2024-10-21 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 75907372b0 Added validation for minionInstanceTag while updating / creating table-config (#14228) add 751a0b9423

Re: [PR] Cleanup remaining test usage of setters in IndexLoadingConfig [pinot]

2024-10-21 Thread via GitHub
Jackie-Jiang merged PR #14256: URL: https://github.com/apache/pinot/pull/14256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Added validation for minionInstanceTag while updating / creating table-config (#14228)

2024-10-21 Thread pratik
This is an automated email from the ASF dual-hosted git repository. pratik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 75907372b0 Added validation for minionInstanceTag

Re: [I] Add validation of instance tag provided in task-config in TableConfigUtils [pinot]

2024-10-21 Thread via GitHub
tibrewalpratik17 closed issue #13941: Add validation of instance tag provided in task-config in TableConfigUtils URL: https://github.com/apache/pinot/issues/13941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Added validation for minionInstanceTag while updating / creating table-config [pinot]

2024-10-21 Thread via GitHub
tibrewalpratik17 merged PR #14228: URL: https://github.com/apache/pinot/pull/14228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@p

(pinot) branch master updated: [timeseries] Fix Time Series Query Correctness Issue (#14251)

2024-10-21 Thread ankitsultana
This is an automated email from the ASF dual-hosted git repository. ankitsultana pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 68899a30e4 [timeseries] Fix Time Series Que

Re: [PR] [timeseries] Fix Time Series Query Correctness Issue [pinot]

2024-10-21 Thread via GitHub
ankitsultana merged PR #14251: URL: https://github.com/apache/pinot/pull/14251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Improve parse error handling and error messages. [pinot]

2024-10-21 Thread via GitHub
bziobrowski commented on PR #14238: URL: https://github.com/apache/pinot/pull/14238#issuecomment-2427003830 Yes, calcite's babel parser has the same issue (core parser is better). It comes mainly from using nonReservedKeywords and `fixing it` with lookahead=2 setting, not from babel sql con

Re: [PR] Add support for application -level query quota. [pinot]

2024-10-21 Thread via GitHub
bziobrowski commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1808975523 ## pinot-broker/src/test/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManagerTest.java: ## @@ -18,6 +18,8 @@ */ package org.apache.pin

Re: [PR] Add support for application -level query quota. [pinot]

2024-10-21 Thread via GitHub
bziobrowski commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1808974123 ## pinot-broker/src/test/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManagerTest.java: ## @@ -531,25 +674,41 @@ private static ExternalV

Re: [PR] Add support for application -level query quota. [pinot]

2024-10-21 Thread via GitHub
shounakmk219 commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1808937974 ## pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java: ## @@ -81,15 +81,32 @@ public class HelixExternalVie

Re: [PR] Add support for application -level query quota. [pinot]

2024-10-21 Thread via GitHub
bziobrowski commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1808897188 ## pinot-broker/src/test/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManagerTest.java: ## @@ -18,6 +18,8 @@ */ package org.apache.pin

Re: [PR] Add support for application -level query quota. [pinot]

2024-10-21 Thread via GitHub
bziobrowski commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1808869947 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java: ## @@ -349,10 +349,10 @@ private TableAuthorizationResult

Re: [PR] Add support for application -level query quota. [pinot]

2024-10-21 Thread via GitHub
bziobrowski commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1808855811 ## pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java: ## @@ -264,52 +317,109 @@ public void updateDatabaseR

Re: [PR] Add support for application -level query quota. [pinot]

2024-10-21 Thread via GitHub
bziobrowski commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1808849573 ## pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java: ## @@ -81,15 +81,32 @@ public class HelixExternalView

Re: [PR] Add support for application -level query quota. [pinot]

2024-10-21 Thread via GitHub
bziobrowski commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1808840729 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotApplicationQuotaRestletResource.java: ## @@ -0,0 +1,163 @@ +/** + * Licensed to the

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
gortiz commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1808688033 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Added validation for minionInstanceTag while updating / creating table-config [pinot]

2024-10-21 Thread via GitHub
tarun11Mavani commented on code in PR #14228: URL: https://github.com/apache/pinot/pull/14228#discussion_r1808730345 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -1815,6 +1821,28 @@ void validateTableTenantConfig(

Re: [PR] Added validation for minionInstanceTag while updating / creating table-config [pinot]

2024-10-21 Thread via GitHub
swaminathanmanish commented on code in PR #14228: URL: https://github.com/apache/pinot/pull/14228#discussion_r1808728067 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -1815,6 +1821,28 @@ void validateTableTenantCon

Re: [PR] Prevent task generation when task queue is in STOPPED state [pinot]

2024-10-21 Thread via GitHub
tibrewalpratik17 commented on code in PR #14257: URL: https://github.com/apache/pinot/pull/14257#discussion_r1808697125 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java: ## @@ -589,6 +601,13 @@ private synchronized List schedu

Re: [PR] Added validation for minionInstanceTag while updating / creating table-config [pinot]

2024-10-21 Thread via GitHub
tibrewalpratik17 commented on code in PR #14228: URL: https://github.com/apache/pinot/pull/14228#discussion_r1808684382 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -1815,6 +1821,28 @@ void validateTableTenantConf

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
gortiz commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1808685011 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
gortiz commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1808683055 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Fixing the vulnerabilities of amazon corretto pinot-base-runtime docker image. [pinot]

2024-10-21 Thread via GitHub
gortiz commented on PR #14042: URL: https://github.com/apache/pinot/pull/14042#issuecomment-2426499150 I've just found [this blogpost](https://martinheinz.dev/blog/92) which is not super updated, but it is good to show the impact using Alpine has in the past. TBH I don't think it is worth t

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1808664167 ## pinot-common/src/main/java/org/apache/pinot/common/cursors/AbstractResponseStore.java: ## @@ -0,0 +1,186 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1808660695 ## pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java: ## @@ -346,9 +352,38 @@ public void start() timeSeriesRequestHandler =

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1808655475 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java: ## @@ -221,6 +230,8 @@ public void processSqlWithMultiStageQueryEngineGet(

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1808653546 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java: ## @@ -437,6 +456,22 @@ private BrokerResponse executeSqlQuery(ObjectNode s

Re: [PR] Added validation for minionInstanceTag while updating / creating table-config [pinot]

2024-10-21 Thread via GitHub
swaminathanmanish commented on code in PR #14228: URL: https://github.com/apache/pinot/pull/14228#discussion_r1808636526 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -1815,6 +1821,28 @@ void validateTableTenantCon

Re: [PR] Added validation for minionInstanceTag while updating / creating table-config [pinot]

2024-10-21 Thread via GitHub
swaminathanmanish commented on PR #14228: URL: https://github.com/apache/pinot/pull/14228#issuecomment-2426421677 > cc @swaminathanmanish Taking a look . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
gortiz commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1808584490 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
gortiz commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1808579633 ## pinot-common/src/main/java/org/apache/pinot/common/cursors/AbstractResponseStore.java: ## @@ -0,0 +1,186 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
gortiz commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1808569489 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

(pinot) 01/01: Bump com.google.errorprone:error_prone_annotations from 2.33.0 to 2.34.0

2024-10-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch dependabot/maven/com.google.errorprone-error_prone_annotations-2.34.0 in repository https://gitbox.apache.org/repos/asf/pinot.git commit 59ed6eaaa6684625a447a7f2dd11a2fe3194f95a Author: depen

[PR] Bump it.unimi.dsi:fastutil from 8.5.14 to 8.5.15 [pinot]

2024-10-21 Thread via GitHub
dependabot[bot] opened a new pull request, #14263: URL: https://github.com/apache/pinot/pull/14263 Bumps [it.unimi.dsi:fastutil](https://github.com/vigna/fastutil) from 8.5.14 to 8.5.15. Changelog Sourced from https://github.com/vigna/fastutil/blob/master/CHANGES";>it.unimi.dsi:fas

(pinot) branch dependabot/maven/com.google.errorprone-error_prone_annotations-2.34.0 created (now 59ed6eaaa6)

2024-10-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.errorprone-error_prone_annotations-2.34.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 59ed6eaaa6 Bump com.google.errorprone:error_prone_a

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
gortiz commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1808566601 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

(pinot) branch dependabot/maven/it.unimi.dsi-fastutil-8.5.15 created (now a919c34035)

2024-10-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/it.unimi.dsi-fastutil-8.5.15 in repository https://gitbox.apache.org/repos/asf/pinot.git at a919c34035 Bump it.unimi.dsi:fastutil from 8.5.14 to 8.5.15 No new revisio

[PR] Bump com.google.errorprone:error_prone_annotations from 2.33.0 to 2.34.0 [pinot]

2024-10-21 Thread via GitHub
dependabot[bot] opened a new pull request, #14262: URL: https://github.com/apache/pinot/pull/14262 Bumps [com.google.errorprone:error_prone_annotations](https://github.com/google/error-prone) from 2.33.0 to 2.34.0. Release notes Sourced from https://github.com/google/error-prone/r

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
gortiz commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1808558556 ## pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java: ## @@ -346,9 +352,38 @@ public void start() timeSeriesRequestHandler =

Re: [PR] Add support for application -level query quota. [pinot]

2024-10-21 Thread via GitHub
bziobrowski commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1808559645 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java: ## @@ -145,6 +148,16 @@ public BrokerResponse handleRequest(Json

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
gortiz commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1808557028 ## pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java: ## @@ -346,9 +352,38 @@ public void start() timeSeriesRequestHandler =

Re: [PR] Add support for Cursors through API Query Params [pinot]

2024-10-21 Thread via GitHub
gortiz commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1808556078 ## pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java: ## @@ -346,9 +352,38 @@ public void start() timeSeriesRequestHandler =

Re: [PR] Add support for application -level query quota. [pinot]

2024-10-21 Thread via GitHub
bziobrowski commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1808552529 ## pinot-broker/src/test/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManagerTest.java: ## @@ -531,25 +674,41 @@ private static ExternalV

  1   2   >