vrajat commented on code in PR #14110:
URL: https://github.com/apache/pinot/pull/14110#discussion_r1808660695
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -346,9 +352,38 @@ public void start()
timeSeriesRequestHandler = new TimeSeriesRequestHandler(_brokerConf,
brokerId, _routingManager,
_accessControlFactory, _queryQuotaManager, tableCache,
queryDispatcher);
}
+
+ LOGGER.info("Initializing PinotFSFactory");
+
PinotFSFactory.init(_brokerConf.subset(CommonConstants.Broker.PREFIX_OF_CONFIG_OF_PINOT_FS_FACTORY));
+
+ LOGGER.info("Initialize ResultStore");
+ PinotConfiguration resultStoreConfiguration =
+
_brokerConf.subset(CommonConstants.CursorConfigs.PREFIX_OF_CONFIG_OF_RESULT_STORE);
+ try {
+ ResponseSerde responseSerde =
ResponseSerdeService.getInstance().getResponseSerde(
+
resultStoreConfiguration.getProperty(CommonConstants.CursorConfigs.RESULT_STORE_SERDE,
+ CommonConstants.CursorConfigs.DEFAULT_RESULT_SERDE));
+
responseSerde.init(resultStoreConfiguration.subset(CommonConstants.CursorConfigs.RESULT_STORE_SERDE)
+ .subset(responseSerde.getType()));
+
+ String expirationTime =
getConfig().getProperty(CommonConstants.CursorConfigs.RESULTS_EXPIRATION_INTERVAL,
+ CommonConstants.CursorConfigs.DEFAULT_RESULTS_EXPIRATION_INTERVAL);
+
+ _resultStore = (AbstractResponseStore)
ResponseStoreService.getInstance().getResultStore(
Review Comment:
This is a consequence of not being able to import `BrokerResponse` in the
SPI package. `ResponseStoreService` is in the SPI package. Some methods that
should have been in `ResponseStore` are in `AbstractResponseStore` because the
methods need `BrokerResponse`.
The only option is to not define the interfaces in the SPI package and move
them to commons package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
