Jackie-Jiang commented on PR #13831:
URL: https://github.com/apache/pinot/pull/13831#issuecomment-2294711130
#13057 (all segments pruned on broker) is similar to the problem solved by
this PR. We should be able to construct the empty response based on the schema.
Do you want to also help fi
Jackie-Jiang opened a new pull request, #13832:
URL: https://github.com/apache/pinot/pull/13832
Also add the following libraries to the enforcer banned list:
- `log4j:log4j`: Use `org.apache.logging.log4j:log4j-core`
- `org.slf4j:slf4j-log4j12`: Use `org.apache.logging.log4j:log4j-slf4j
vrajat commented on code in PR #13816:
URL: https://github.com/apache/pinot/pull/13816#discussion_r1720672839
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/DynamicBrokerSelector.java:
##
@@ -45,11 +45,11 @@ public class DynamicBrokerSelector implements
vrajat commented on code in PR #13816:
URL: https://github.com/apache/pinot/pull/13816#discussion_r1720672168
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/DynamicBrokerSelector.java:
##
@@ -45,11 +45,11 @@ public class DynamicBrokerSelector implements
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 8f12fc1a92 Move pinot-common to plugin root and
xiangfu0 merged PR #13830:
URL: https://github.com/apache/pinot/pull/13830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
vvivekiyer opened a new pull request, #13831:
URL: https://github.com/apache/pinot/pull/13831
When all segments are pruned on the server, we construct a [empty
responseBlock](https://github.com/apache/pinot/blob/8603164cc646dcb4bc2a6ead51cc9ad37441fda7/pinot-core/src/main/java/org/apache/pin
Jackie-Jiang commented on code in PR #13789:
URL: https://github.com/apache/pinot/pull/13789#discussion_r1720492136
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##
@@ -1013,6 +1013,22 @@ public boolean tryLoadExistingSegment(SegmentZK
xiangfu0 opened a new pull request, #13830:
URL: https://github.com/apache/pinot/pull/13830
1. Move pinot-common to plugin root
2. Ensure all the pinot libs reference in plugins are provided scope
--
This is an automated message from the Apache Git Service.
To respond to the message, p
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new fca6babc33 Improve error messages when creating s
Jackie-Jiang merged PR #13818:
URL: https://github.com/apache/pinot/pull/13818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
xiangfu0 closed pull request #13821: Add missing s3-transfer-manager library
URL: https://github.com/apache/pinot/pull/13821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Jackie-Jiang commented on PR #13771:
URL: https://github.com/apache/pinot/pull/13771#issuecomment-2294414099
@klsince Can you help verify the test logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/orc.version-2.0.2
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 3df9d3487a Bump orc.version from 1.9.3 to 2.0.2
The revisions that were on this branch
dependabot[bot] commented on PR #13827:
URL: https://github.com/apache/pinot/pull/13827#issuecomment-2294374316
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a dependency by
Jackie-Jiang closed pull request #13827: Bump orc.version from 1.9.3 to 2.0.2
URL: https://github.com/apache/pinot/pull/13827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.27.6
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 0782c5a6c3 Bump software.amazon.awssdk:bom from 2.27.5 to 2.27.6
The revi
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 81194bfa0a Bump software.amazon.awssdk:bom from 2
Jackie-Jiang merged PR #13828:
URL: https://github.com/apache/pinot/pull/13828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
xbli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new b241d731b7 Track segments consistently for consiste
klsince merged PR #13677:
URL: https://github.com/apache/pinot/pull/13677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
xiangfu0 merged PR #129:
URL: https://github.com/apache/pinot-site/pull/129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch new-site-dev
in repository https://gitbox.apache.org/repos/asf/pinot-site.git
The following commit(s) were added to refs/heads/new-site-dev by this push:
new e3fdd26c New site dev (#129)
e3
e-loftis opened a new pull request, #129:
URL: https://github.com/apache/pinot-site/pull/129
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
deepthi912 commented on code in PR #13789:
URL: https://github.com/apache/pinot/pull/13789#discussion_r1716192276
##
pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentsReloadCheckResponse.java:
##
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the Apache Softwar
klsince merged PR #13636:
URL: https://github.com/apache/pinot/pull/13636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
This is an automated email from the ASF dual-hosted git repository.
xbli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 983d3563ef add metadata ttl field to DedupConfig (#
piby180 commented on code in PR #13450:
URL: https://github.com/apache/pinot/pull/13450#discussion_r1720222062
##
helm/pinot/templates/broker/service-external.yaml:
##
@@ -29,6 +29,7 @@ metadata:
{{- include "pinot.brokerLabels" . | nindent 4 }}
spec:
type: {{ .Values.b
lnbest0707-uber commented on PR #13695:
URL: https://github.com/apache/pinot/pull/13695#issuecomment-2294008682
> To ensure the ingestion order, we might be able to use a producer-consumer
pattern, where consumer thread creates `MessageBatch`s and put them into a
queue; another ingestion th
piby180 commented on code in PR #13450:
URL: https://github.com/apache/pinot/pull/13450#discussion_r1720221428
##
helm/pinot/templates/broker/service.yaml:
##
@@ -27,6 +27,7 @@ metadata:
{{- include "pinot.brokerLabels" . | nindent 4 }}
spec:
type: {{ .Values.broker.ser
piby180 commented on code in PR #13450:
URL: https://github.com/apache/pinot/pull/13450#discussion_r1720221134
##
helm/pinot/templates/controller/service.yaml:
##
@@ -27,6 +27,7 @@ metadata:
{{- include "pinot.controllerLabels" . | nindent 4 }}
spec:
type: {{ .Values.co
Jackie-Jiang commented on PR #13829:
URL: https://github.com/apache/pinot/pull/13829#issuecomment-2294006513
I'd suggest trying to fix the dependency issue first before reverting it
back to the old version. The problem might be specific to `hadoop-aws` library
--
This is an automated mess
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch new-site-dev
in repository https://gitbox.apache.org/repos/asf/pinot-site.git
The following commit(s) were added to refs/heads/new-site-dev by this push:
new 416dec46 adding new blog post f
xiangfu0 merged PR #128:
URL: https://github.com/apache/pinot-site/pull/128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
xiangfu0 commented on code in PR #13450:
URL: https://github.com/apache/pinot/pull/13450#discussion_r1720196860
##
helm/pinot/templates/broker/service.yaml:
##
@@ -27,6 +27,7 @@ metadata:
{{- include "pinot.brokerLabels" . | nindent 4 }}
spec:
type: {{ .Values.broker.se
xiangfu0 commented on PR #13450:
URL: https://github.com/apache/pinot/pull/13450#issuecomment-2293982972
Pinot handles all the internal readiness for routing request to servers, so
it's ok to expose all the server ips.
For controller and broker, they all start up pretty fast, so it's ok t
xiangfu0 commented on PR #13450:
URL: https://github.com/apache/pinot/pull/13450#issuecomment-2293979790
I think we should only make default value for service-headless to true, all
others to false.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
xiangfu0 commented on code in PR #13450:
URL: https://github.com/apache/pinot/pull/13450#discussion_r1720192010
##
helm/pinot/templates/broker/service-external.yaml:
##
@@ -29,6 +29,7 @@ metadata:
{{- include "pinot.brokerLabels" . | nindent 4 }}
spec:
type: {{ .Values.
zhtaoxiang commented on code in PR #13636:
URL: https://github.com/apache/pinot/pull/13636#discussion_r1720162873
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/dedup/ConcurrentMapPartitionDedupMetadataManager.java:
##
@@ -19,106 +19,121 @@
package org.apac
ege-st opened a new pull request, #13829:
URL: https://github.com/apache/pinot/pull/13829
Hadoop 3.4.0 is causing issues with the AWS SDK S3 library. Specifically,
the following exception is being thrown:
```
Caused by: java.lang.ClassNotFoundException:
software.amazon.awssdk.tra
klsince commented on code in PR #13636:
URL: https://github.com/apache/pinot/pull/13636#discussion_r1720140526
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/dedup/ConcurrentMapPartitionDedupMetadataManager.java:
##
@@ -19,106 +19,121 @@
package org.apache.
shounakmk219 commented on code in PR #13803:
URL: https://github.com/apache/pinot/pull/13803#discussion_r1720090925
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java:
##
@@ -103,12 +104,14 @@ public class PinotRealtimeTab
shounakmk219 commented on PR #13771:
URL: https://github.com/apache/pinot/pull/13771#issuecomment-2293833114
Hey @Jackie-Jiang I could not find any direct way of getting the signal
that query quota rate limiter change is propagated so right now I am checking
for the delay between 2 success
egalpin commented on code in PR #13742:
URL: https://github.com/apache/pinot/pull/13742#discussion_r1720064027
##
pinot-core/src/main/java/org/apache/pinot/core/transport/AsyncQueryResponse.java:
##
@@ -50,21 +52,31 @@ public class AsyncQueryResponse implements QueryResponse {
gortiz commented on PR #9416:
URL: https://github.com/apache/pinot/pull/9416#issuecomment-2293569057
Resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
gortiz commented on code in PR #13818:
URL: https://github.com/apache/pinot/pull/13818#discussion_r1719848974
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/v2/builder/BaseSingleTreeBuilder.java:
##
@@ -520,11 +520,22 @@ private void createForwardIn
mcvsubbu commented on code in PR #13803:
URL: https://github.com/apache/pinot/pull/13803#discussion_r1719842646
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java:
##
@@ -103,12 +104,14 @@ public class PinotRealtimeTableRe
mcvsubbu commented on PR #13695:
URL: https://github.com/apache/pinot/pull/13695#issuecomment-2293506342
How would ingestion rate limiting work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.27.6
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 0782c5a6c3 Bump software.amazon.awssdk:bom from 2.27.5 to 2.27.6
No n
dependabot[bot] opened a new pull request, #13828:
URL: https://github.com/apache/pinot/pull/13828
Bumps software.amazon.awssdk:bom from 2.27.5 to 2.27.6.
[ were added to refs/heads/master by this push:
new ef3caa391f Fix controller port logging in quickst
Jackie-Jiang merged PR #13794:
URL: https://github.com/apache/pinot/pull/13794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 3b9439d6fe Add more unit test for `AbstractMetric
Jackie-Jiang merged PR #13697:
URL: https://github.com/apache/pinot/pull/13697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
64 matches
Mail list logo