KKcorps commented on code in PR #13528:
URL: https://github.com/apache/pinot/pull/13528#discussion_r1663487055
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -1682,25 +1682,38 @@ public long getTimeSinceEventLastCon
codecov-commenter commented on PR #13528:
URL: https://github.com/apache/pinot/pull/13528#issuecomment-2205096446
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13528?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
codecov-commenter commented on PR #13527:
URL: https://github.com/apache/pinot/pull/13527#issuecomment-2205091170
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13527?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
swaminathanmanish commented on code in PR #13528:
URL: https://github.com/apache/pinot/pull/13528#discussion_r1663467898
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -1682,25 +1682,38 @@ public long getTimeSinceEv
KKcorps opened a new pull request, #13528:
URL: https://github.com/apache/pinot/pull/13528
This is leading to a lot of noisy logs. adding control to switch to debug
logging in case we are simply fetching offsets for a metric rather than for
actualusage
--
This is an automated message fro
itschrispeck opened a new pull request, #13527:
URL: https://github.com/apache/pinot/pull/13527
We've seen some NPEs caused by certain combinations of filters, namely when
the filtering follows the pattern:
`WHERE NOT ( AND )`, and the
docIds returned by the `` are less than the doc
Ids
satwik-pachigolla commented on PR #13225:
URL: https://github.com/apache/pinot/pull/13225#issuecomment-2205034728
@Jackie-Jiang It isn't a breaking change but I would still label it
incompatible / backwards-incompat. If someone pulls in this commit without
realising this change in behavior,
abhioncbr closed pull request #13510: commons-rng for random number generation.
URL: https://github.com/apache/pinot/pull/13510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Jackie-Jiang commented on issue #13508:
URL: https://github.com/apache/pinot/issues/13508#issuecomment-2204791609
cc @mayankshriv Can you help take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Jackie-Jiang commented on code in PR #13509:
URL: https://github.com/apache/pinot/pull/13509#discussion_r166198
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java:
##
@@ -702,6 +702,14 @@ public void cleanUpTask() {
}
Jackie-Jiang commented on code in PR #13417:
URL: https://github.com/apache/pinot/pull/13417#discussion_r1663326337
##
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/DeleteSchemaCommand.java:
##
@@ -150,8 +90,9 @@ public boolean execute()
try (FileUploadDown
Jackie-Jiang commented on PR #13477:
URL: https://github.com/apache/pinot/pull/13477#issuecomment-2204768704
@sullis is working on migrating from HttpClient4 to HttpClient5 in #13222. I
guess these 2 PRs are related, and I assume HttpClient5 probably has fixed the
bug described in #13431
Jackie-Jiang commented on PR #13525:
URL: https://github.com/apache/pinot/pull/13525#issuecomment-2204764948
We rarely use random in production code (especially in high perf code), so
I'd suggest just using `Random` for now and revisit if we need high performance
random generator
--
This
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 897376e1ee Adapt group trim threshold to group trim size rather than
vice versa (#13514)
add af8dd9bfca make pom
Jackie-Jiang merged PR #13526:
URL: https://github.com/apache/pinot/pull/13526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on PR #13362:
URL: https://github.com/apache/pinot/pull/13362#issuecomment-2204749693
After a second thought, the root cause of the problem is that: retention
manager always keeps the last completed segment even if it is already expired.
I think we need to fix this be
codecov-commenter commented on PR #13526:
URL: https://github.com/apache/pinot/pull/13526#issuecomment-2204734645
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13526?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
Jackie-Jiang commented on code in PR #13488:
URL: https://github.com/apache/pinot/pull/13488#discussion_r1663306183
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##
@@ -677,14 +678,30 @@ public RebalanceResult rebalan
abhioncbr commented on PR #13525:
URL: https://github.com/apache/pinot/pull/13525#issuecomment-2204725683
> Seems all the usages are within the tests, and this library is not that
commonly used (only [71
usages](https://mvnrepository.com/artifact/org.apache.commons/commons-rng-simple)).
I'
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from f4a1f56b6c Add table level metric for segment upload error (#13315)
add 897376e1ee Adapt group trim threshold to g
Jackie-Jiang merged PR #13514:
URL: https://github.com/apache/pinot/pull/13514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new f4a1f56b6c Add table level metric for segment upl
Jackie-Jiang merged PR #13315:
URL: https://github.com/apache/pinot/pull/13315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on code in PR #13222:
URL: https://github.com/apache/pinot/pull/13222#discussion_r1663288580
##
pinot-common/src/main/java/org/apache/pinot/common/minion/MinionClient.java:
##
@@ -72,8 +72,8 @@ public Map scheduleMinionTasks(@Nullable
String taskType, @Nu
Jackie-Jiang commented on code in PR #13525:
URL: https://github.com/apache/pinot/pull/13525#discussion_r1663281844
##
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/relocation/SegmentRelocatorTest.java:
##
@@ -126,7 +127,7 @@ public void testRebalanceTabl
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/org.checkerframework-checker-qual-3.45.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 2f547b0390 Bump org.checkerframework:checker-qual from 3.44.0 to 3.
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 0757b93d5c Bump software.amazon.awssdk:bom from 2.26.11 to 2.26.13
(#13522)
add 7213e137b8 Bump org.checkerframew
Jackie-Jiang merged PR #13523:
URL: https://github.com/apache/pinot/pull/13523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.26.13
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 4e17ca1216 Bump software.amazon.awssdk:bom from 2.26.11 to 2.26.13
The r
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 2e90f73bb4 Bump net.alchim31.maven:scala-maven-plugin from 4.9.1 to
4.9.2 (#13520)
add 0757b93d5c Bump software.a
Jackie-Jiang merged PR #13522:
URL: https://github.com/apache/pinot/pull/13522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/net.alchim31.maven-scala-maven-plugin-4.9.2
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 129b712ba5 Bump net.alchim31.maven:scala-maven-plugin from 4.9.1
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 550f71bb14 Bump circe.version from 0.14.8 to 0.14.9 (#13519)
add 2e90f73bb4 Bump net.alchim31.maven:scala-maven-pl
Jackie-Jiang merged PR #13520:
URL: https://github.com/apache/pinot/pull/13520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch dependabot/maven/circe.version-0.14.9
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 8a65451eef Bump circe.version from 0.14.8 to 0.14.9
The revisions that were on this bra
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from b8ccfadb43 Bump org.codehaus.mojo:versions-maven-plugin from 2.16.2 to
2.17.0 (#13512)
add 550f71bb14 Bump circe.
Jackie-Jiang merged PR #13519:
URL: https://github.com/apache/pinot/pull/13519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/org.codehaus.mojo-versions-maven-plugin-2.17.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 78bedee99b Bump org.codehaus.mojo:versions-maven-plugin from
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from f54559987e Handle unsupported exception gracefully (#13524)
add b8ccfadb43 Bump org.codehaus.mojo:versions-maven-p
Jackie-Jiang merged PR #13512:
URL: https://github.com/apache/pinot/pull/13512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/hk2.version-3.1.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 3a7fbd445a Bump hk2.version from 2.6.1 to 3.1.1
The revisions that were on this branch
dependabot[bot] commented on PR #13521:
URL: https://github.com/apache/pinot/pull/13521#issuecomment-2204663539
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a dependency by
Jackie-Jiang closed pull request #13521: Bump hk2.version from 2.6.1 to 3.1.1
URL: https://github.com/apache/pinot/pull/13521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Jackie-Jiang commented on PR #13225:
URL: https://github.com/apache/pinot/pull/13225#issuecomment-2204662013
@satwik-pachigolla It won't break existing tables since it is checked during
table config validation. Pinot won't allow new table config/table config update
with both configs
--
T
satwik-pachigolla commented on PR #13225:
URL: https://github.com/apache/pinot/pull/13225#issuecomment-2204553738
> Add a check to not allow only one of functionColumnPairs and
aggregationConfigs to be configured
Can we add the 'breaking-change' and / or 'incompatible' labels to the P
tibrewalpratik17 commented on code in PR #13489:
URL: https://github.com/apache/pinot/pull/13489#discussion_r1663216060
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/MinionTaskUtils.java:
##
@@ -206,4 +183,66 @@
sullis commented on PR #13222:
URL: https://github.com/apache/pinot/pull/13222#issuecomment-2204517052
Rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
klsince commented on code in PR #13489:
URL: https://github.com/apache/pinot/pull/13489#discussion_r1663205016
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/MinionTaskUtils.java:
##
@@ -206,4 +183,66 @@ public s
Jackie-Jiang closed issue #10691: Unable to create Star-Tree index for
DISTINCTCOUNTBITMAP
URL: https://github.com/apache/pinot/issues/10691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
wangpatrick57 opened a new pull request, #13526:
URL: https://github.com/apache/pinot/pull/13526
Before this change, if this repository was nested inside another Maven
project, it would point to the Maven project it was nested in instead of itself
when calling `mvn install` inside this repo
yashmayya opened a new pull request, #13514:
URL: https://github.com/apache/pinot/pull/13514
- The grouping algorithm and group limit configurations are described here -
https://docs.pinot.apache.org/users/user-guide-query/query-syntax/grouping-algorithm
- Currently, if the trim size is l
KKcorps merged PR #13524:
URL: https://github.com/apache/pinot/pull/13524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
shounakmk219 opened a new pull request, #13513:
URL: https://github.com/apache/pinot/pull/13513
Updated rules to expose metrics from below PRs:
- https://github.com/apache/pinot/pull/12710
- https://github.com/apache/pinot/pull/13298
--
This is an automated message from the A
gortiz merged PR #13513:
URL: https://github.com/apache/pinot/pull/13513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
kishoreg commented on issue #10147:
URL: https://github.com/apache/pinot/issues/10147#issuecomment-2197885403
How will broker query the new segment if it's not part of IS/EV?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
xiangfu0 merged PR #13490:
URL: https://github.com/apache/pinot/pull/13490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
Jackie-Jiang commented on code in PR #13490:
URL: https://github.com/apache/pinot/pull/13490#discussion_r1659410652
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformer.java:
##
@@ -173,10 +173,20 @@ private static Map
par
xiangfu0 commented on code in PR #13490:
URL: https://github.com/apache/pinot/pull/13490#discussion_r1659408832
##
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/GenericRow.java:
##
@@ -174,6 +174,30 @@ private Object copy(Object value) {
}
return list;
Jackie-Jiang merged PR #13479:
URL: https://github.com/apache/pinot/pull/13479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang merged PR #13463:
URL: https://github.com/apache/pinot/pull/13463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang closed issue #13462: Support `EXTRACT` as scalar function
URL: https://github.com/apache/pinot/issues/13462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
siddharthteotia commented on issue #13433:
URL: https://github.com/apache/pinot/issues/13433#issuecomment-2197767335
Yes Resiliency label would be useful. In fact, I think we have a bunch of
resiliency related open / in-progress work that should ideally be coupled under
resiliency label.
Jackie-Jiang commented on issue #13474:
URL: https://github.com/apache/pinot/issues/13474#issuecomment-219367
What I meant is that you may ask this in the troubleshooting channel, and
other users who have run into the same issue might be able to help
--
This is an automated message fr
Jackie-Jiang closed issue #13455: The TEXT_MATCH result does not meet
expectations.
URL: https://github.com/apache/pinot/issues/13455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
Jackie-Jiang commented on issue #10147:
URL: https://github.com/apache/pinot/issues/10147#issuecomment-2197768243
We sync'd on this offline, and here are the some conclusions:
- When segment commit happens (end offset of the consuming segment is
determined), controller can create the ZKMe
Jackie-Jiang merged PR #13507:
URL: https://github.com/apache/pinot/pull/13507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
siddharthteotia commented on issue #13452:
URL: https://github.com/apache/pinot/issues/13452#issuecomment-2197766238
@jasperjiaguo recently fixed a bug in this functionality that we had
discovered from an internally deployed use case.
Jia - is this a different problem ?
--
This i
jackjlli opened a new pull request, #13509:
URL: https://github.com/apache/pinot/pull/13509
This PR adds the nonLeaderCleanUp method with the list of table names as the
parameter in the PinotTaskGenerator interface.
When the tasks are scheduled, the current controller may not always b
Jackie-Jiang opened a new pull request, #13478:
URL: https://github.com/apache/pinot/pull/13478
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
Jackie-Jiang commented on code in PR #13465:
URL: https://github.com/apache/pinot/pull/13465#discussion_r1653254998
##
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##
@@ -346,9 +346,7 @@ public void start()
_sqlQueryExecutor = ne
abhioncbr commented on code in PR #13477:
URL: https://github.com/apache/pinot/pull/13477#discussion_r1653249539
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRunningQueryResource.java:
##
@@ -124,6 +125,9 @@ public String cancelQuery(
Jackie-Jiang commented on code in PR #13449:
URL: https://github.com/apache/pinot/pull/13449#discussion_r1653266496
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##
@@ -806,11 +822,8 @@ protected void doRemove
Jackie-Jiang commented on issue #13474:
URL: https://github.com/apache/pinot/issues/13474#issuecomment-2189541126
You may find some help from the Slack troubleshooting channel. I feel this
is related to the k8s setup. cc @zhtaoxiang
--
This is an automated message from the Apache Git Ser
This is an automated email from the ASF dual-hosted git repository.
kharekartik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new f54559987e Handle unsupported exception grac
This is an automated email from the ASF dual-hosted git repository.
kharekartik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new c156042c75 Fix NPE in Minion (#13518)
c15604
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/org.checkerframework-checker-qual-3.45.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 2f547b0390 Bump org.checkerframework:checker-qual from 3.44.0 t
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.26.12
in repository https://gitbox.apache.org/repos/asf/pinot.git
was d1aaf1e950 Bump software.amazon.awssdk:bom from 2.26.11 to 2.26.12
T
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.26.13
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 4e17ca1216 Bump software.amazon.awssdk:bom from 2.26.11 to 2.26.13
N
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/net.alchim31.maven-scala-maven-plugin-4.9.2
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 129b712ba5 Bump net.alchim31.maven:scala-maven-plugin from 4
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/hk2.version-3.1.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 3a7fbd445a Bump hk2.version from 2.6.1 to 3.1.1
No new revisions were added by this up
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/circe.version-0.14.9
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 8a65451eef Bump circe.version from 0.14.8 to 0.14.9
No new revisions were added by
81 matches
Mail list logo
