Re: [PR] Added API to check if 2 tables are co-located [pinot]

2024-06-15 Thread via GitHub
suyashpatel98 commented on PR #13403: URL: https://github.com/apache/pinot/pull/13403#issuecomment-2171065446 On second thought these is something wrong with the implementation - we shouldn't be getting segment names and comparing them. My implementation works locally because ` IdealS

Re: [PR] Added API to check if 2 tables are co-located [pinot]

2024-06-15 Thread via GitHub
codecov-commenter commented on PR #13403: URL: https://github.com/apache/pinot/pull/13403#issuecomment-2171047421 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13403?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Added API to check if 2 tables are co-located [pinot]

2024-06-15 Thread via GitHub
suyashpatel98 opened a new pull request, #13403: URL: https://github.com/apache/pinot/pull/13403 Addresses #11788. Approach: For each partition get the set of servers on which the partition resides for each table and verify that the 2 server sets are equal Edge case: Consider table0 (

(pinot) branch master updated: In ClusterTest, make start port higher to avoid potential conflict with Kafka (#13402)

2024-06-15 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 57d6486e9b In ClusterTest, make start port higher

Re: [PR] In ClusterTest, make start port higher to avoid potential conflict with Kafka [pinot]

2024-06-15 Thread via GitHub
Jackie-Jiang merged PR #13402: URL: https://github.com/apache/pinot/pull/13402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [I] Allow to add derived columns that depends on new columns [pinot]

2024-06-15 Thread via GitHub
npawar commented on issue #12186: URL: https://github.com/apache/pinot/issues/12186#issuecomment-2170965322 Chatting with Siddharth Dharm offline, who'd been trying this issue out. As per him this doesn't reproduce with these steps. I tried just now, and it indeed doesn’t reproduce that way

Re: [I] Pinot Server crash [pinot]

2024-06-15 Thread via GitHub
hpvd commented on issue #11471: URL: https://github.com/apache/pinot/issues/11471#issuecomment-2170938148 @Sotatek-HungNguyenThanh Does this idea solves this issue for you? If so we may close it... -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [I] Error while performing schema evolution [pinot]

2024-06-15 Thread via GitHub
hpvd commented on issue #13312: URL: https://github.com/apache/pinot/issues/13312#issuecomment-2170936350 @aishwaryathondapu does this bugfix solves this issue for you, so that we can close it? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [I] double NaN as default value can massivly expand off heap mutable dictionary [pinot]

2024-06-15 Thread via GitHub
hpvd commented on issue #10697: URL: https://github.com/apache/pinot/issues/10697#issuecomment-2170915489 @Jackie-Jiang since now also the second bugfix is merged: can this issue be closed or do we keep it open till `PostgreSQL behavior` is implemented? -- This is an automated message fro

Re: [I] SIGSEGV in pinot-server [pinot]

2024-06-15 Thread via GitHub
hpvd commented on issue #10861: URL: https://github.com/apache/pinot/issues/10861#issuecomment-2170825543 current state: one of the reviewer suggested to not merge the fix see https://github.com/apache/pinot/pull/10862#pullrequestreview-1468370724 -- This is an automated message from t

Re: [I] Allow users to specify lucene analyzer when creating text index [pinot]

2024-06-15 Thread via GitHub
hpvd commented on issue #9154: URL: https://github.com/apache/pinot/issues/9154#issuecomment-2170796575 @TT1103 does this merged feature solves this issue for you? If so, we could close this issue... as soon as @jackluo923 has updated the docs... -- This is an automated message from

Re: [I] Text-index does not support multi-token substring search where first and last tokens are partial [pinot]

2024-06-15 Thread via GitHub
hpvd commented on issue #10863: URL: https://github.com/apache/pinot/issues/10863#issuecomment-2170730801 @chenboat does this merged feature solves this issue for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [I] Pinot minions not building NATIVE indices [pinot]

2024-06-15 Thread via GitHub
hpvd commented on issue #11520: URL: https://github.com/apache/pinot/issues/11520#issuecomment-2170716482 @shwin does this merged fix solves this issue for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [I] Reloading segments does not update LUCENE vs NATIVE text indices [pinot]

2024-06-15 Thread via GitHub
hpvd commented on issue #11529: URL: https://github.com/apache/pinot/issues/11529#issuecomment-2170704777 @shwin does this merged fix solves this issue for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [I] Fix Lucene text index realtime to offline conversion [pinot]

2024-06-15 Thread via GitHub
hpvd commented on issue #13039: URL: https://github.com/apache/pinot/issues/13039#issuecomment-2170690465 @SabrinaZhaozyf is the merged bugfix solving this issue for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] In ClusterTest, make start port higher to avoid potential conflict with Kafka [pinot]

2024-06-15 Thread via GitHub
codecov-commenter commented on PR #13402: URL: https://github.com/apache/pinot/pull/13402#issuecomment-2170592335 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13402?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] In ClusterTest, make start port higher to avoid potential conflict with Kafka [pinot]

2024-06-15 Thread via GitHub
Jackie-Jiang opened a new pull request, #13402: URL: https://github.com/apache/pinot/pull/13402 - Kafka's default port is 19092 - To be future proof, make pinot components start from port 2 - Add method to restart controller -- This is an automated message from the Apache Git Ser

Re: [PR] [HELM]: Added namespace support in K8s deployment. [pinot]

2024-06-15 Thread via GitHub
xiangfu0 commented on code in PR #13380: URL: https://github.com/apache/pinot/pull/13380#discussion_r1641333277 ## helm/pinot/templates/_helpers.tpl: ## @@ -319,3 +319,14 @@ The name of the pinot minion stateless config. {{- define "pinot.minionStateless.config" -}} {{- printf

Re: [PR] [HELM]: Added namespace support in K8s deployment. [pinot]

2024-06-15 Thread via GitHub
xiangfu0 commented on code in PR #13380: URL: https://github.com/apache/pinot/pull/13380#discussion_r1641329977 ## helm/pinot/values.yaml: ## @@ -19,6 +19,9 @@ # Default values for Pinot. +namespaceOverride: Review Comment: is this supported or we should use ```

Re: [PR] [WIP]: Cleanup in pinot-compatibility-verifier module. [pinot]

2024-06-15 Thread via GitHub
codecov-commenter commented on PR #13401: URL: https://github.com/apache/pinot/pull/13401#issuecomment-2170414775 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13401?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch master updated: Add mode to allow adding dummy events for non-matching steps (#13382)

2024-06-15 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new c341e06b14 Add mode to allow adding dummy event

Re: [PR] Add mode to allow adding dummy events for non-matching steps [pinot]

2024-06-15 Thread via GitHub
xiangfu0 merged PR #13382: URL: https://github.com/apache/pinot/pull/13382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[PR] [WIP]: Cleanup in pinot-compatibility-verifier module. [pinot]

2024-06-15 Thread via GitHub
abhioncbr opened a new pull request, #13401: URL: https://github.com/apache/pinot/pull/13401 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-incompat`