xiangfu0 commented on code in PR #13380:
URL: https://github.com/apache/pinot/pull/13380#discussion_r1641333277
##########
helm/pinot/templates/_helpers.tpl:
##########
@@ -319,3 +319,14 @@ The name of the pinot minion stateless config.
{{- define "pinot.minionStateless.config" -}}
{{- printf "%s-config" (include "pinot.minionStateless.fullname" .) | trunc 63
| trimSuffix "-" -}}
{{- end -}}
+
+{{/*
+Return pinot namespace to use
+*/}}
+{{- define "pinot.namespace" -}}
+{{- if .Values.namespaceOverride -}}
+ {{- .Values.namespaceOverride -}}
+{{- else -}}
+ {{- .Release.Namespace -}}
Review Comment:
Is this k8s system default namespace?
what's the behavior if user set the default namespace to something else?
Shall we only define this if user want to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
