Re: [PR] Fix all typed ArrayList elements() method usage [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang commented on code in PR #13354: URL: https://github.com/apache/pinot/pull/13354#discussion_r1634301267 ## pinot-common/src/main/java/org/apache/pinot/common/utils/ArrayListUtils.java: ## @@ -0,0 +1,124 @@ +/** + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] UI Load time Improvement API Fixes #13278 [pinot]

2024-06-10 Thread via GitHub
shounakmk219 commented on code in PR #13296: URL: https://github.com/apache/pinot/pull/13296#discussion_r1634199499 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java: ## @@ -119,6 +121,28 @@ public List listSchemaNames(@C

Re: [PR] Add list of collaborators to asf.yaml [pinot]

2024-06-10 Thread via GitHub
yashmayya commented on PR #13346: URL: https://github.com/apache/pinot/pull/13346#issuecomment-2159769737 Thanks Jackie! Mentioning the newly added collaborators here as an FYI - @sullis, @shenyu0127, @tibrewalpratik17, @abhioncbr, @zhtaoxiang, @shounakmk219, @itschrispeck, @soumitra-st, @s

Re: [PR] Optimize snapshot flow to only snapshot segments which have updates [pinot]

2024-06-10 Thread via GitHub
klsince commented on code in PR #13285: URL: https://github.com/apache/pinot/pull/13285#discussion_r1634137440 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -703,9 +703,20 @@ public void run() { // persi

Re: [PR] fix race condition in `ScalingThreadPoolExecutor` [pinot]

2024-06-10 Thread via GitHub
codecov-commenter commented on PR #13360: URL: https://github.com/apache/pinot/pull/13360#issuecomment-2159718614 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13360?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch master updated (ad5ca349ab -> d09cd0cec7)

2024-06-10 Thread xbli
This is an automated email from the ASF dual-hosted git repository. xbli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from ad5ca349ab Add list of collaborators to asf.yaml (#13346) add d09cd0cec7 move shouldReplaceOnComparisonTie to base c

Re: [PR] move shouldReplaceOnComparisonTie to base class to be more reusable [pinot]

2024-06-10 Thread via GitHub
klsince merged PR #13353: URL: https://github.com/apache/pinot/pull/13353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

Re: [PR] extend CompactedPinotSegmentRecordReader so that it can skip deleteRecord [pinot]

2024-06-10 Thread via GitHub
klsince commented on code in PR #13352: URL: https://github.com/apache/pinot/pull/13352#discussion_r1634119955 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/readers/CompactedPinotSegmentRecordReader.java: ## @@ -36,19 +37,25 @@ public class Compact

[PR] fix race condition in `ScalingThreadPoolExecutor` [pinot]

2024-06-10 Thread via GitHub
itschrispeck opened a new pull request, #13360: URL: https://github.com/apache/pinot/pull/13360 I introduced `ScalingThreadPoolExecutor` previously to provide an autoscaling thread pool, used to prevent interrupts from corrupting the realtime Lucene index. There is a race condition

Re: [PR] Refactored compatibility-verifier module [pinot]

2024-06-10 Thread via GitHub
codecov-commenter commented on PR #13359: URL: https://github.com/apache/pinot/pull/13359#issuecomment-2159664376 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13359?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Refactored compatibility-verifier module [pinot]

2024-06-10 Thread via GitHub
abhioncbr opened a new pull request, #13359: URL: https://github.com/apache/pinot/pull/13359 **Labels:** - `refactor` - `cleanup` **Description:** TODO -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Fix NPE in ArrayAgg extractFinalResult functions [pinot]

2024-06-10 Thread via GitHub
codecov-commenter commented on PR #13358: URL: https://github.com/apache/pinot/pull/13358#issuecomment-2159628408 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13358?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] update RewriterConstants [pinot]

2024-06-10 Thread via GitHub
codecov-commenter commented on PR #13357: URL: https://github.com/apache/pinot/pull/13357#issuecomment-2159597608 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13357?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Exclude dimensions from star-tree index stored type check [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang commented on code in PR #13355: URL: https://github.com/apache/pinot/pull/13355#discussion_r1634027291 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/startree/v2/builder/StarTreeIndexSeparatorTest.java: ## @@ -18,85 +18,63 @@ */ package org.a

Re: [PR] Exclude dimensions from star-tree index stored type check [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang commented on code in PR #13355: URL: https://github.com/apache/pinot/pull/13355#discussion_r1634019815 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/SegmentLocalFSDirectory.java: ## @@ -268,7 +267,7 @@ private synchronized void lo

Re: [PR] Exclude dimensions from star-tree index stored type check [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang commented on code in PR #13355: URL: https://github.com/apache/pinot/pull/13355#discussion_r1634019517 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/StarTreeIndexReader.java: ## @@ -67,17 +66,11 @@ public class StarTreeIndexReader

Re: [I] Allowing empty segments with no offset advancing [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang commented on issue #12703: URL: https://github.com/apache/pinot/issues/12703#issuecomment-2159568541 > Is this as straight-forward as removing these lines? I think so. The drawback is that we might end up with a lot of segments that are all empty, but I guess we ca

Re: [PR] extend CompactedPinotSegmentRecordReader so that it can skip deleteRecord [pinot]

2024-06-10 Thread via GitHub
tibrewalpratik17 commented on code in PR #13352: URL: https://github.com/apache/pinot/pull/13352#discussion_r1634014707 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/readers/CompactedPinotSegmentRecordReader.java: ## @@ -36,19 +37,25 @@ public clas

Re: [PR] Fix [Type]ArrayList elements() method usage [pinot]

2024-06-10 Thread via GitHub
xiangfu0 commented on code in PR #13354: URL: https://github.com/apache/pinot/pull/13354#discussion_r1634013898 ## pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java: ## @@ -523,7 +523,7 @@ private static int[] toIntArray(Object value) { return (in

Re: [PR] New buffers [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang commented on code in PR #13304: URL: https://github.com/apache/pinot/pull/13304#discussion_r1634007122 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/memory/DataBuffer.java: ## @@ -0,0 +1,292 @@ +/** + * Licensed to the Apache Software Foundation (A

Re: [PR] Exclude dimensions from star-tree index stored type check [pinot]

2024-06-10 Thread via GitHub
codecov-commenter commented on PR #13355: URL: https://github.com/apache/pinot/pull/13355#issuecomment-2159556815 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13355?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] update RewriterConstants [pinot]

2024-06-10 Thread via GitHub
jasperjiaguo opened a new pull request, #13357: URL: https://github.com/apache/pinot/pull/13357 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-incompat`

Re: [PR] Exclude dimensions from star-tree index stored type check [pinot]

2024-06-10 Thread via GitHub
jadami10 commented on code in PR #13355: URL: https://github.com/apache/pinot/pull/13355#discussion_r1634000831 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/SegmentLocalFSDirectory.java: ## @@ -268,7 +267,7 @@ private synchronized void loadDa

(pinot) branch dependabot/npm_and_yarn/pinot-controller/src/main/resources/multi-8616326b9a deleted (was b18d139681)

2024-06-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/pinot-controller/src/main/resources/multi-8616326b9a in repository https://gitbox.apache.org/repos/asf/pinot.git was b18d139681 Bump braces, webpack, webpack-cli

Re: [PR] Bump braces, webpack, webpack-cli and webpack-dev-server in /pinot-controller/src/main/resources [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang closed pull request #13356: Bump braces, webpack, webpack-cli and webpack-dev-server in /pinot-controller/src/main/resources URL: https://github.com/apache/pinot/pull/13356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Bump braces, webpack, webpack-cli and webpack-dev-server in /pinot-controller/src/main/resources [pinot]

2024-06-10 Thread via GitHub
dependabot[bot] commented on PR #13356: URL: https://github.com/apache/pinot/pull/13356#issuecomment-2159537462 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by

Re: [I] Server crashing with OOM error [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang commented on issue #13335: URL: https://github.com/apache/pinot/issues/13335#issuecomment-2159535985 A thread dump can help capture the hotspot objects. This is also a good candidate question in the slack troubleshooting channel -- This is an automated message from the Apache

(pinot) branch master updated (393f130715 -> ad5ca349ab)

2024-06-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 393f130715 Clean Google Dependencies (#13297) add ad5ca349ab Add list of collaborators to asf.yaml (#13346) No ne

Re: [PR] Add list of collaborators to asf.yaml [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang merged PR #13346: URL: https://github.com/apache/pinot/pull/13346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/npm_and_yarn/pinot-controller/src/main/resources/multi-8616326b9a created (now b18d139681)

2024-06-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/pinot-controller/src/main/resources/multi-8616326b9a in repository https://gitbox.apache.org/repos/asf/pinot.git at b18d139681 Bump braces, webpack, webpack-cli

[PR] Bump braces, webpack, webpack-cli and webpack-dev-server in /pinot-controller/src/main/resources [pinot]

2024-06-10 Thread via GitHub
dependabot[bot] opened a new pull request, #13356: URL: https://github.com/apache/pinot/pull/13356 Bumps [braces](https://github.com/micromatch/braces) to 3.0.3 and updates ancestor dependencies [braces](https://github.com/micromatch/braces), [webpack](https://github.com/webpack/webpack),

Re: [PR] Clean Google Dependencies [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang merged PR #13297: URL: https://github.com/apache/pinot/pull/13297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [I] Google library dependency management [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang closed issue #13077: Google library dependency management URL: https://github.com/apache/pinot/issues/13077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

(pinot) branch master updated: Clean Google Dependencies (#13297)

2024-06-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 393f130715 Clean Google Dependencies (#13297) 393

Re: [PR] Fix [Type]ArrayList elements() method usage [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang commented on code in PR #13354: URL: https://github.com/apache/pinot/pull/13354#discussion_r1633994691 ## pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java: ## @@ -523,7 +523,7 @@ private static int[] toIntArray(Object value) { return

[PR] Exclude dimensions from star-tree index stored type check [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang opened a new pull request, #13355: URL: https://github.com/apache/pinot/pull/13355 Related to #12164 and #12554 Do not check stored type for dimensions to avoid mismatching columns with '__' in column name -- This is an automated message from the Apache Git Service. To

Re: [PR] move shouldReplaceOnComparisonTie to base class to be more reusable [pinot]

2024-06-10 Thread via GitHub
codecov-commenter commented on PR #13353: URL: https://github.com/apache/pinot/pull/13353#issuecomment-2159496652 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13353?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Fix [Type]ArrayList elements() method usage [pinot]

2024-06-10 Thread via GitHub
codecov-commenter commented on PR #13354: URL: https://github.com/apache/pinot/pull/13354#issuecomment-2159468956 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13354?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch master updated: extend CompactedPinotSegmentRecordReader so that it can skip deleteRecord (#13352)

2024-06-10 Thread xbli
This is an automated email from the ASF dual-hosted git repository. xbli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new b371feb933 extend CompactedPinotSegmentRecordReader

Re: [PR] extend CompactedPinotSegmentRecordReader so that it can skip deleteRecord [pinot]

2024-06-10 Thread via GitHub
klsince merged PR #13352: URL: https://github.com/apache/pinot/pull/13352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

Re: [PR] extend CompactedPinotSegmentRecordReader so that it can skip deleteRecord [pinot]

2024-06-10 Thread via GitHub
codecov-commenter commented on PR #13352: URL: https://github.com/apache/pinot/pull/13352#issuecomment-2159431626 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13352?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] move shouldReplaceOnComparisonTie to base class to be more reusable [pinot]

2024-06-10 Thread via GitHub
klsince commented on PR #13353: URL: https://github.com/apache/pinot/pull/13353#issuecomment-2159424750 cc @rohityadav1993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[PR] move shouldReplaceOnComparisonTie to base class to be more reusable [pinot]

2024-06-10 Thread via GitHub
klsince opened a new pull request, #13353: URL: https://github.com/apache/pinot/pull/13353 no new changes added, but moved shouldReplaceOnComparisonTie() method to base class to make it more reusable in other subclasses -- This is an automated message from the Apache Git Service. To resp

Re: [I] Null Pointer Exception in arrayagg function with empty column data [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang commented on issue #13343: URL: https://github.com/apache/pinot/issues/13343#issuecomment-2159410270 cc @xiangfu0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

(pinot) branch master updated: Adding a cluster config to enable instance pool and replica group configuration in table config (#13131)

2024-06-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 425182f438 Adding a cluster config to enable inst

Re: [PR] Adding a cluster config to enable instance pool and replica group configuration in table config [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang merged PR #13131: URL: https://github.com/apache/pinot/pull/13131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Adding a cluster config to enable instance pool and replica group configuration in table config [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang commented on PR #13131: URL: https://github.com/apache/pinot/pull/13131#issuecomment-2159405446 Good job! Please also update the pinot doc about the new config -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[PR] extend CompactedPinotSegmentRecordReader so that it can skip deleteRecord [pinot]

2024-06-10 Thread via GitHub
klsince opened a new pull request, #13352: URL: https://github.com/apache/pinot/pull/13352 Extend CompactedPinotSegmentRecordReader so that it can skip deleteRecord if configured. Note that dropping deleteRecord too soon may cause the old soft-deleted record to show up unexpectedly,

(pinot) branch master updated: Revert "support deleteColumn for compactionTask by extending the record reader (#13342)" (#13351)

2024-06-10 Thread xbli
This is an automated email from the ASF dual-hosted git repository. xbli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new e825e13978 Revert "support deleteColumn for compact

Re: [PR] Revert "support deleteColumn for compactionTask by extending the record reader [pinot]

2024-06-10 Thread via GitHub
klsince merged PR #13351: URL: https://github.com/apache/pinot/pull/13351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

Re: [PR] Revert "support deleteColumn for compactionTask by extending the record reader [pinot]

2024-06-10 Thread via GitHub
klsince commented on PR #13351: URL: https://github.com/apache/pinot/pull/13351#issuecomment-2159321440 > (minor) We might want to keep the first 2 files unchanged since we are reverting some valid formatting change Will keep this PR as a pure revert PR. and I'll open another PR for

Re: [PR] Support array sum aggregation function [pinot]

2024-06-10 Thread via GitHub
xiangfu0 commented on code in PR #13324: URL: https://github.com/apache/pinot/pull/13324#discussion_r1633842707 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/array/SumArrayDoubleAggregationFunction.java: ## @@ -0,0 +1,155 @@ +/** + * Licensed to th

Re: [PR] Revert "support deleteColumn for compactionTask by extending the record reader [pinot]

2024-06-10 Thread via GitHub
codecov-commenter commented on PR #13351: URL: https://github.com/apache/pinot/pull/13351#issuecomment-2159196572 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13351?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Revert "support deleteColumn for compactionTask by extending the record reader [pinot]

2024-06-10 Thread via GitHub
klsince opened a new pull request, #13351: URL: https://github.com/apache/pinot/pull/13351 As analyzed in https://github.com/apache/pinot/pull/13347, it's not right to drop 'delete record' in compaction task, as that'd remove 'delete record' too soon, making the deleted records in older seg

(pinot) branch master updated: Fix URI construction so that AddSchema command line tool works when override flag is set to true (#13320)

2024-06-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 5fc9bf60bd Fix URI construction so that AddSchema

Re: [PR] [Bug fix] Fix URI construction so that AddSchema command line tool works [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang merged PR #13320: URL: https://github.com/apache/pinot/pull/13320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [I] Data ingestion CPU efficiency improvements [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang commented on issue #13319: URL: https://github.com/apache/pinot/issues/13319#issuecomment-2159097713 Good findings! Let's first check if there are some low hanging fruit optimizations. cc @swaminathanmanish -- This is an automated message from the Apache Git Service. To r

Re: [PR] do not fail on duplicate relaxed vars [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang merged PR #13214: URL: https://github.com/apache/pinot/pull/13214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: do not fail on duplicate relaxed vars (#13214)

2024-06-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 49698174ee do not fail on duplicate relaxed vars

(pinot) branch master updated: update node version in the docs (#13294)

2024-06-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new c5dc885bac update node version in the docs (#1329

Re: [PR] update node version in the docs [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang merged PR #13294: URL: https://github.com/apache/pinot/pull/13294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Bump com.azure:azure-storage-file-datalake from 12.19.0 to 12.19.1 [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang merged PR #13350: URL: https://github.com/apache/pinot/pull/13350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/com.azure-azure-storage-file-datalake-12.19.1 deleted (was 0fbfc38021)

2024-06-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.azure-azure-storage-file-datalake-12.19.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was 0fbfc38021 Bump com.azure:azure-storage-file-datalake from 12.

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.25.69 deleted (was 3ba73cc3dc)

2024-06-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.25.69 in repository https://gitbox.apache.org/repos/asf/pinot.git was 3ba73cc3dc Bump software.amazon.awssdk:bom from 2.25.68 to 2.25.69 The r

(pinot) branch master updated (30a7609d09 -> b0f356cfd1)

2024-06-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 30a7609d09 Bump software.amazon.awssdk:bom from 2.25.68 to 2.25.69 (#13349) add b0f356cfd1 Bump com.azure:azure-s

(pinot) branch master updated: Bump software.amazon.awssdk:bom from 2.25.68 to 2.25.69 (#13349)

2024-06-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 30a7609d09 Bump software.amazon.awssdk:bom from 2

Re: [PR] Bump software.amazon.awssdk:bom from 2.25.68 to 2.25.69 [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang merged PR #13349: URL: https://github.com/apache/pinot/pull/13349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (e8db382d51 -> e072542e78)

2024-06-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from e8db382d51 [Backfill] allow externally partitioned segment uploads for upsert tables (#13107) add e072542e78 Bump

(pinot) branch dependabot/maven/dropwizard-metrics.version-4.2.26 deleted (was bf7485ab97)

2024-06-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/dropwizard-metrics.version-4.2.26 in repository https://gitbox.apache.org/repos/asf/pinot.git was bf7485ab97 Bump dropwizard-metrics.version from 4.2.25 to 4.2.26 The revi

Re: [PR] Bump dropwizard-metrics.version from 4.2.25 to 4.2.26 [pinot]

2024-06-10 Thread via GitHub
Jackie-Jiang merged PR #13348: URL: https://github.com/apache/pinot/pull/13348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: [Backfill] allow externally partitioned segment uploads for upsert tables (#13107)

2024-06-10 Thread xbli
This is an automated email from the ASF dual-hosted git repository. xbli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new e8db382d51 [Backfill] allow externally partitioned

Re: [PR] [Backfill] allow externally partitioned segment uploads for upsert tables [pinot]

2024-06-10 Thread via GitHub
klsince merged PR #13107: URL: https://github.com/apache/pinot/pull/13107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

Re: [PR] [Backfill] allow externally partitioned segment uploads for upsert tables [pinot]

2024-06-10 Thread via GitHub
klsince commented on code in PR #13107: URL: https://github.com/apache/pinot/pull/13107#discussion_r1633513536 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/SegmentGeneratorConfig.java: ## @@ -600,6 +616,11 @@ public String inferSegmentNameGeneratorType

Re: [PR] UI Load time Improvement API Fixes #13278 [pinot]

2024-06-10 Thread via GitHub
deepthi912 commented on code in PR #13296: URL: https://github.com/apache/pinot/pull/13296#discussion_r1633380421 ## pinot-common/src/main/java/org/apache/pinot/common/config/provider/TableCache.java: ## @@ -361,7 +361,8 @@ private void putSchema(ZNRecord znRecord) colu

Re: [I] Use Foreign Memory API, introduced in Java 22 [pinot]

2024-06-10 Thread via GitHub
gortiz commented on issue #12809: URL: https://github.com/apache/pinot/issues/12809#issuecomment-2158186978 pinot-test.yml is the one that tests the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] Unable to Run Ingestion Job when using ADLS Gen2 as a source and destination [pinot]

2024-06-10 Thread via GitHub
amirjalali1 commented on issue #11025: URL: https://github.com/apache/pinot/issues/11025#issuecomment-2158090798 i'm facing the same issue @Akash-Nair any resolution @snleee here is my spec im using the recipe for importing CSV file the only change here is reading from ADLS ` ex

(pinot) branch dependabot/maven/com.azure-azure-storage-file-datalake-12.19.1 created (now 0fbfc38021)

2024-06-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.azure-azure-storage-file-datalake-12.19.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at 0fbfc38021 Bump com.azure:azure-storage-file-datalake from

[PR] Bump com.azure:azure-storage-file-datalake from 12.19.0 to 12.19.1 [pinot]

2024-06-10 Thread via GitHub
dependabot[bot] opened a new pull request, #13350: URL: https://github.com/apache/pinot/pull/13350 Bumps [com.azure:azure-storage-file-datalake](https://github.com/Azure/azure-sdk-for-java) from 12.19.0 to 12.19.1. Release notes Sourced from https://github.com/Azure/azure-sdk-for-

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.25.69 created (now 3ba73cc3dc)

2024-06-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.25.69 in repository https://gitbox.apache.org/repos/asf/pinot.git at 3ba73cc3dc Bump software.amazon.awssdk:bom from 2.25.68 to 2.25.69 N

[PR] Bump software.amazon.awssdk:bom from 2.25.68 to 2.25.69 [pinot]

2024-06-10 Thread via GitHub
dependabot[bot] opened a new pull request, #13349: URL: https://github.com/apache/pinot/pull/13349 Bumps software.amazon.awssdk:bom from 2.25.68 to 2.25.69. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=softwa

[PR] Bump dropwizard-metrics.version from 4.2.25 to 4.2.26 [pinot]

2024-06-10 Thread via GitHub
dependabot[bot] opened a new pull request, #13348: URL: https://github.com/apache/pinot/pull/13348 Bumps `dropwizard-metrics.version` from 4.2.25 to 4.2.26. Updates `io.dropwizard.metrics:metrics-core` from 4.2.25 to 4.2.26 Release notes Sourced from https://github.com/dropwizard

(pinot) branch dependabot/maven/dropwizard-metrics.version-4.2.26 created (now bf7485ab97)

2024-06-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/dropwizard-metrics.version-4.2.26 in repository https://gitbox.apache.org/repos/asf/pinot.git at bf7485ab97 Bump dropwizard-metrics.version from 4.2.25 to 4.2.26 No n

Re: [PR] Improve performance of DataBlock serde [pinot]

2024-06-10 Thread via GitHub
gortiz commented on code in PR #13303: URL: https://github.com/apache/pinot/pull/13303#discussion_r1633056604 ## pinot-perf/src/main/java/org/apache/pinot/perf/BenchmarkDataBlock.java: ## @@ -0,0 +1,269 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Ensure upsert deletion consistency when enabled with compaction flow [pinot]

2024-06-10 Thread via GitHub
codecov-commenter commented on PR #13347: URL: https://github.com/apache/pinot/pull/13347#issuecomment-2158006287 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13347?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Improve performance of DataBlock serde [pinot]

2024-06-10 Thread via GitHub
gortiz commented on code in PR #13303: URL: https://github.com/apache/pinot/pull/13303#discussion_r1633033128 ## pinot-core/src/main/java/org/apache/pinot/core/common/datablock/DataBlockBuilder.java: ## @@ -187,200 +141,315 @@ public static RowDataBlock buildFromRows(List rows,

Re: [PR] Improve performance of DataBlock serde [pinot]

2024-06-10 Thread via GitHub
gortiz commented on code in PR #13303: URL: https://github.com/apache/pinot/pull/13303#discussion_r1633031444 ## pinot-core/src/main/java/org/apache/pinot/core/common/datablock/DataBlockBuilder.java: ## @@ -187,200 +141,315 @@ public static RowDataBlock buildFromRows(List rows,

Re: [PR] Improve performance of DataBlock serde [pinot]

2024-06-10 Thread via GitHub
gortiz commented on code in PR #13303: URL: https://github.com/apache/pinot/pull/13303#discussion_r1633023949 ## pinot-common/src/test/java/org/apache/pinot/common/datablock/BaseDataBlockContract.java: ## @@ -1,42 +0,0 @@ -/** - * Licensed to the Apache Software Foundation (ASF)

[PR] Ensure upsert deletion consistency when enabled with compaction flow [pinot]

2024-06-10 Thread via GitHub
tibrewalpratik17 opened a new pull request, #13347: URL: https://github.com/apache/pinot/pull/13347 Labels: `enhancement` `upsert` ### Problem statement In #12037, we added support for removing deleted keys and the validDocId for the deleted records after a TTL window. Th