vvivekiyer opened a new pull request, #13327:
URL: https://github.com/apache/pinot/pull/13327
This is a followup to https://github.com/apache/pinot/pull/13104
If there are cases of netty channel lock exceptions, we will avoid
publishing stats for some servers as the exception handlin
This is an automated email from the ASF dual-hosted git repository.
kharekartik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new fb64ec29e9 Fix few metric rules which were a
KKcorps merged PR #13290:
URL: https://github.com/apache/pinot/pull/13290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
rohityadav1993 commented on code in PR #13107:
URL: https://github.com/apache/pinot/pull/13107#discussion_r1630674736
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java:
##
@@ -158,6 +158,45 @@ protected vo
gortiz commented on code in PR #13298:
URL: https://github.com/apache/pinot/pull/13298#discussion_r1630692381
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java:
##
@@ -88,6 +90,16 @@ private static class IngestionTimestamps {
Jackie-Jiang closed issue #7213: [multistage] Support Window Functions
URL: https://github.com/apache/pinot/issues/7213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
Jackie-Jiang commented on issue #7213:
URL: https://github.com/apache/pinot/issues/7213#issuecomment-2154130013
Closing this as the basic window functions are all supported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
rohityadav1993 commented on code in PR #13107:
URL: https://github.com/apache/pinot/pull/13107#discussion_r1630674736
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java:
##
@@ -158,6 +158,45 @@ protected vo
rohityadav1993 commented on code in PR #13107:
URL: https://github.com/apache/pinot/pull/13107#discussion_r1630664998
##
pinot-common/src/main/java/org/apache/pinot/common/utils/UploadedRealtimeSegmentName.java:
##
@@ -0,0 +1,180 @@
+/**
+ * Licensed to the Apache Software Found
swaminathanmanish commented on code in PR #13298:
URL: https://github.com/apache/pinot/pull/13298#discussion_r1630651998
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java:
##
@@ -174,6 +188,22 @@ private long getIngestionDelayMs(l
eaugene commented on PR #13292:
URL: https://github.com/apache/pinot/pull/13292#issuecomment-2153869284
Hi @Jackie-Jiang, can you PTAL for this minor fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
codecov-commenter commented on PR #13325:
URL: https://github.com/apache/pinot/pull/13325#issuecomment-2153772651
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13325?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
Jackie-Jiang opened a new pull request, #13326:
URL: https://github.com/apache/pinot/pull/13326
This change can be used to bring back the legacy non-sql support removed in
#11610 and #11763, and log an error:
- on broker when alias is applied to filter clause
- on server when illegal c
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch handle_non_standard_sql
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 741712158c2eb3ab4296aba4fb613b8cde743858
Author: Xiaotian (Jackie) Jiang
AuthorDate: Wed Nov 8 18:20:27
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch handle_non_standard_sql
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 741712158c Handle legacy query and log error
This branch includes the following new commits:
ne
codecov-commenter commented on PR #13324:
URL: https://github.com/apache/pinot/pull/13324#issuecomment-2153621937
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13324?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
Jackie-Jiang opened a new pull request, #13325:
URL: https://github.com/apache/pinot/pull/13325
Clean up the flow from `RelNode` from planner side to `MultiStageOperator`
on the executor side:
- Cleanup unnecessary fields and conversions in `PlanNode`, and keep it
close to information fr
xiangfu0 opened a new pull request, #13324:
URL: https://github.com/apache/pinot/pull/13324
Support Aggregation function `SumArrayLong` and `SumArrayDouble` for
aggregate on Arrays to sum on the corresponding array positions.
--
This is an automated message from the Apache Git Service.
To
klsince commented on code in PR #13107:
URL: https://github.com/apache/pinot/pull/13107#discussion_r1630365372
##
pinot-common/src/main/java/org/apache/pinot/common/utils/UploadedRealtimeSegmentName.java:
##
@@ -0,0 +1,180 @@
+/**
+ * Licensed to the Apache Software Foundation (
tibrewalpratik17 commented on code in PR #13285:
URL: https://github.com/apache/pinot/pull/13285#discussion_r1630391893
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -703,9 +703,11 @@ public void run() {
/
tibrewalpratik17 commented on code in PR #13285:
URL: https://github.com/apache/pinot/pull/13285#discussion_r1630385916
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -703,9 +703,11 @@ public void run() {
/
tibrewalpratik17 commented on code in PR #13285:
URL: https://github.com/apache/pinot/pull/13285#discussion_r1630385916
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -703,9 +703,11 @@ public void run() {
/
tibrewalpratik17 commented on code in PR #13285:
URL: https://github.com/apache/pinot/pull/13285#discussion_r1630165678
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##
@@ -,6 +1132,9 @@ protected void add
tibrewalpratik17 commented on code in PR #13285:
URL: https://github.com/apache/pinot/pull/13285#discussion_r1630122807
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##
@@ -,6 +1132,9 @@ protected void add
klsince commented on code in PR #13285:
URL: https://github.com/apache/pinot/pull/13285#discussion_r1630153069
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##
@@ -874,19 +875,32 @@ protected void doTakeSnapsh
tibrewalpratik17 commented on code in PR #13285:
URL: https://github.com/apache/pinot/pull/13285#discussion_r1630119781
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##
@@ -874,19 +875,32 @@ protected void doT
klsince commented on code in PR #13285:
URL: https://github.com/apache/pinot/pull/13285#discussion_r1630013857
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##
@@ -874,19 +875,32 @@ protected void doTakeSnapsh
tibrewalpratik17 commented on PR #13285:
URL: https://github.com/apache/pinot/pull/13285#issuecomment-2153109192
cc @klsince @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
This is an automated email from the ASF dual-hosted git repository.
xbli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 1d1d25dc0f Update getValidDocIdsMetadataFromServer
klsince merged PR #13314:
URL: https://github.com/apache/pinot/pull/13314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
klsince commented on issue #13284:
URL: https://github.com/apache/pinot/issues/13284#issuecomment-2153094150
This reminded me of an improvement I tried for strictReplicaGroup
(https://github.com/apache/pinot/pull/11847) but didn't finish. As you
mentioned in the issue description, it's a bi
tibrewalpratik17 commented on code in PR #13187:
URL: https://github.com/apache/pinot/pull/13187#discussion_r1629984437
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/metadata/ColumnMetadataImpl.java:
##
@@ -229,11 +229,17 @@ public static ColumnMetadataIm
Jackie-Jiang commented on issue #13284:
URL: https://github.com/apache/pinot/issues/13284#issuecomment-2153029104
Great feature to add!
We need the following info to route the query:
IS: Find ONLINE/CONSUMING segments to query
EV: Actual segment states
Segment name or ZK metad
Jackie-Jiang commented on code in PR #13306:
URL: https://github.com/apache/pinot/pull/13306#discussion_r1629889683
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/PinotLogicalQueryPlanner.java:
##
@@ -51,70 +48,72 @@ private PinotLogicalQueryPlanner(
Jackie-Jiang commented on code in PR #13187:
URL: https://github.com/apache/pinot/pull/13187#discussion_r1629874567
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/metadata/ColumnMetadataImpl.java:
##
@@ -229,11 +229,17 @@ public static ColumnMetadataImpl
tibrewalpratik17 commented on code in PR #13187:
URL: https://github.com/apache/pinot/pull/13187#discussion_r1629870264
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##
@@ -585,6 +585,19 @@ public stati
Jackie-Jiang commented on code in PR #13187:
URL: https://github.com/apache/pinot/pull/13187#discussion_r1629848687
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##
@@ -585,6 +585,19 @@ public static vo
Jackie-Jiang commented on code in PR #13187:
URL: https://github.com/apache/pinot/pull/13187#discussion_r1629847762
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##
@@ -585,6 +585,19 @@ public static vo
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.25.67
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 4f5c7deee1 Bump software.amazon.awssdk:bom from 2.25.66 to 2.25.67
The r
Jackie-Jiang closed issue #13317: Ingest from Pulsar: Update to Pulsar 3.3
URL: https://github.com/apache/pinot/issues/13317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from ba2c373637 Bump org.apache.maven.plugins:maven-checkstyle-plugin
(#13321)
add 2c59fbec96 Bump pulsar.version from
Jackie-Jiang merged PR #13322:
URL: https://github.com/apache/pinot/pull/13322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 2c59fbec96 Bump pulsar.version from 3.2.3 to 3.3.0 (#13322)
add b602df5271 Bump software.amazon.awssdk:bom from 2.
Jackie-Jiang merged PR #13321:
URL: https://github.com/apache/pinot/pull/13321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang merged PR #13323:
URL: https://github.com/apache/pinot/pull/13323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch dependabot/maven/pulsar.version-3.3.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was a5972fc0b2 Bump pulsar.version from 3.2.3 to 3.3.0
The revisions that were on this bran
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/org.apache.maven.plugins-maven-checkstyle-plugin-3.4.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 420f5e74c2 Bump org.apache.maven.plugins:maven-checks
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new ba2c373637 Bump org.apache.maven.plugins:maven-ch
hpvd commented on PR #11262:
URL: https://github.com/apache/pinot/pull/11262#issuecomment-2152860652
Since this is a really important feature and so much work has already gone
into it,
I dare to send a shy ping to the requested reviewers @walterddr
@Jackie-Jiang
Thanks for all you wo
hpvd commented on issue #13317:
URL: https://github.com/apache/pinot/issues/13317#issuecomment-2152291744
dependabot already has done its job:
```
All checks have passed
22 successful checks
```
only one manual approving review required to close this.
https://github.com/apac
tibrewalpratik17 commented on code in PR #13187:
URL: https://github.com/apache/pinot/pull/13187#discussion_r1629444612
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##
@@ -585,6 +585,7 @@ public static
dependabot[bot] opened a new pull request, #13323:
URL: https://github.com/apache/pinot/pull/13323
Bumps software.amazon.awssdk:bom from 2.25.66 to 2.25.67.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=softwa
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.25.67
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 4f5c7deee1 Bump software.amazon.awssdk:bom from 2.25.66 to 2.25.67
N
dependabot[bot] opened a new pull request, #13322:
URL: https://github.com/apache/pinot/pull/13322
Bumps `pulsar.version` from 3.2.3 to 3.3.0.
Updates `org.apache.pulsar:pulsar-client` from 3.2.3 to 3.3.0
Release notes
Sourced from https://github.com/apache/pulsar/releases";>org.
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/pulsar.version-3.3.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at a5972fc0b2 Bump pulsar.version from 3.2.3 to 3.3.0
No new revisions were added by t
dependabot[bot] opened a new pull request, #13321:
URL: https://github.com/apache/pinot/pull/13321
Bumps
[org.apache.maven.plugins:maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin)
from 3.3.1 to 3.4.0.
Commits
https://github.com/apache/maven-checkstyl
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/org.apache.maven.plugins-maven-checkstyle-plugin-3.4.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 420f5e74c2 Bump org.apache.maven.plugins:maven-ch
eaugene commented on PR #13279:
URL: https://github.com/apache/pinot/pull/13279#issuecomment-2151603091
Thanks for catching this @tibrewalpratik17 .
_TIL :_ null in string concatenation is converted to "null" in java .
[Ref](https://docs.oracle.com/javase/specs/jls/se11/html/jls-5.html
gortiz commented on code in PR #13035:
URL: https://github.com/apache/pinot/pull/13035#discussion_r1628920654
##
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerTimer.java:
##
@@ -54,7 +54,14 @@ public enum ServerTimer implements AbstractMetrics.Timer {
UPSER
gortiz commented on code in PR #13035:
URL: https://github.com/apache/pinot/pull/13035#discussion_r1628906266
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/MultiStageQueryStats.java:
##
@@ -284,14 +284,18 @@ public void mergeUpstream(List otherStats) {
gortiz commented on code in PR #13035:
URL: https://github.com/apache/pinot/pull/13035#discussion_r1628900459
##
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerTimer.java:
##
@@ -54,7 +54,14 @@ public enum ServerTimer implements AbstractMetrics.Timer {
UPSER
gortiz commented on code in PR #13035:
URL: https://github.com/apache/pinot/pull/13035#discussion_r1628890607
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/MultiStageQueryStats.java:
##
@@ -256,7 +256,7 @@ public void mergeUpstream(MultiStageQueryStats
codecov-commenter commented on PR #13320:
URL: https://github.com/apache/pinot/pull/13320#issuecomment-2151554203
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13320?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
63 matches
Mail list logo
