gortiz commented on code in PR #13298:
URL: https://github.com/apache/pinot/pull/13298#discussion_r1630692381
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java:
##########
@@ -88,6 +90,16 @@ private static class IngestionTimestamps {
private final long _ingestionTimeMs;
private final long _firstStreamIngestionTimeMs;
}
+
+ private static class IngestionOffsets {
+ IngestionOffsets(StreamPartitionMsgOffset offset, StreamPartitionMsgOffset
latestOffset) {
+ _offset = offset;
+ _latestOffset = latestOffset;
+ }
+ private final StreamPartitionMsgOffset _offset;
+ private final StreamPartitionMsgOffset _latestOffset;
Review Comment:
nit: can we write the attributes before the constructor? Doing it the other
way around is very strange.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
