codecov-commenter commented on PR #12782:
URL: https://github.com/apache/pinot/pull/12782#issuecomment-2033583770
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12782?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
shounakmk219 commented on code in PR #12782:
URL: https://github.com/apache/pinot/pull/12782#discussion_r1548923240
##
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java:
##
@@ -587,64 +587,66 @@ public void fixSchemaNameInTableConfig() {
shounakmk219 opened a new pull request, #12782:
URL: https://github.com/apache/pinot/pull/12782
# Description
- Deprecating `PinotHelixResourceManager#getAllTables()` in favour of
`PinotHelixResourceManager#getAllTables(String databaseName)` as
`getAllTables()` only works for `defaul
codecov-commenter commented on PR #12779:
URL: https://github.com/apache/pinot/pull/12779#issuecomment-2033496193
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12779?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
shounakmk219 commented on code in PR #12739:
URL: https://github.com/apache/pinot/pull/12739#discussion_r1548851976
##
docker/images/pinot/etc/jmx_prometheus_javaagent/configs/broker.yml:
##
@@ -1,76 +1,90 @@
rules:
-- pattern: "\"org.apache.pinot.common.metrics\"<>(\\w+)"
- n
codecov-commenter commented on PR #12780:
URL: https://github.com/apache/pinot/pull/12780#issuecomment-2033412951
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12780?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
sullis opened a new pull request, #12780:
URL: https://github.com/apache/pinot/pull/12780
https://mvnrepository.com/artifact/org.testcontainers/testcontainers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 721e6550b9 BugFix: Fix merge result from more tha
Jackie-Jiang commented on PR #12778:
URL: https://github.com/apache/pinot/pull/12778#issuecomment-2033317163
What I meant is that the ser/de doesn't carry all information from
intermediate result, thus we need to set the extra parameters after it being
deserialized. I think it is okay for n
Jackie-Jiang merged PR #12778:
URL: https://github.com/apache/pinot/pull/12778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on issue #12721:
URL: https://github.com/apache/pinot/issues/12721#issuecomment-2033290879
@kelseiv Can you please take a look at the feedback from @jadami10 about the
schema doc?
--
This is an automated message from the Apache Git Service.
To respond to the message
sullis commented on PR #12750:
URL: https://github.com/apache/pinot/pull/12750#issuecomment-2033257882
ready to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
sullis commented on PR #12776:
URL: https://github.com/apache/pinot/pull/12776#issuecomment-2033255393
ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
lnbest0707-uber opened a new pull request, #12779:
URL: https://github.com/apache/pinot/pull/12779
tags: `feature`, `refactor`, `release-notes`
This adds an evolved version of ShemaConformingTransformerV2, it evolves
from the existing one with following new features:
1. Refact
Jackie-Jiang commented on PR #12697:
URL: https://github.com/apache/pinot/pull/12697#issuecomment-2033090446
I've reverted the change of removing separate executor for Kinesis and
Pulsar to make this PR only focus on the interface change
--
This is an automated message from the Apache Git
Jackie-Jiang commented on code in PR #12763:
URL: https://github.com/apache/pinot/pull/12763#discussion_r1548591606
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java:
##
@@ -583,15 +583,31 @@ priv
davecromberge commented on PR #12778:
URL: https://github.com/apache/pinot/pull/12778#issuecomment-2033021774
> Do you also need to set threshold?
Good catch - you are correct. This has now been included.
> The root cause of this is that the intermediate result is not fully
se
codecov-commenter commented on PR #12778:
URL: https://github.com/apache/pinot/pull/12778#issuecomment-2032955757
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12778?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 987a0fe622 upgrade to jacoco 0.8.12 (#12777)
987a
Jackie-Jiang merged PR #12777:
URL: https://github.com/apache/pinot/pull/12777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on PR #12611:
URL: https://github.com/apache/pinot/pull/12611#issuecomment-2032919114
No, seems it is not included..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
zhtaoxiang commented on code in PR #12739:
URL: https://github.com/apache/pinot/pull/12739#discussion_r1548459792
##
docker/images/pinot/etc/jmx_prometheus_javaagent/configs/broker.yml:
##
@@ -1,76 +1,90 @@
rules:
-- pattern: "\"org.apache.pinot.common.metrics\"<>(\\w+)"
- nam
davecromberge opened a new pull request, #12778:
URL: https://github.com/apache/pinot/pull/12778
Summary
-
The merge operation results in a null reference error when the set
operations is not set properly for Tuple Sketches.
Description
When more t
kishoreg commented on issue #10591:
URL: https://github.com/apache/pinot/issues/10591#issuecomment-2032801942
@ksnijjer datetrunc seems to be more closer to sql syntax and we probably
want to push the users towards datetrunc. can you list the scenarios where
datetimeconvert is useful
--
ksnijjer commented on issue #10591:
URL: https://github.com/apache/pinot/issues/10591#issuecomment-2032782598
@npawar this would be a very useful feature, anyone else can pick this one
up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
yupeng9 commented on code in PR #12659:
URL: https://github.com/apache/pinot/pull/12659#discussion_r1548368730
##
pinot-connectors/pinot-flink-connector/pom.xml:
##
@@ -51,7 +51,18 @@
org.apache.flink
- flink-streaming-java_${scala.compat.version}
Review
ankitsultana commented on PR #12611:
URL: https://github.com/apache/pinot/pull/12611#issuecomment-2032743607
@Jackie-Jiang : we are seeing this in our internal 1.1 release cut build as
well. We didn't add this to that release?
cc: @vvivekiyer
--
This is an automated message from t
gortiz merged PR #12765:
URL: https://github.com/apache/pinot/pull/12765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
This is an automated email from the ASF dual-hosted git repository.
gortiz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 2904ceb407 Delete database API (#12765)
2904ceb40
klsince commented on code in PR #12440:
URL: https://github.com/apache/pinot/pull/12440#discussion_r1548331232
##
pinot-spi/src/main/java/org/apache/pinot/spi/env/CommonsConfigurationUtils.java:
##
@@ -287,4 +342,42 @@ private static PropertiesConfiguration
createPropertiesConf
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/hk2.version-3.1.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
discard ee40f9aec5 Bump hk2.version from 2.6.1 to 3.1.0
add 08fc2c7d62 upgrade lmax disrup
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/swagger.version-1.6.14
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 4db7d06cbe Bump swagger.version from 1.6.9 to 1.6.14
The revisions that were on t
dependabot[bot] closed pull request #12749: Bump swagger.version from 1.6.9 to
1.6.14
URL: https://github.com/apache/pinot/pull/12749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
dependabot[bot] commented on PR #12749:
URL: https://github.com/apache/pinot/pull/12749#issuecomment-2032698594
Looks like these dependencies are no longer a dependency, so this is no
longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
Jackie-Jiang merged PR #12772:
URL: https://github.com/apache/pinot/pull/12772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new e7e4888ef7 Upgrade Jersey related libraries (#127
snleee commented on code in PR #12659:
URL: https://github.com/apache/pinot/pull/12659#discussion_r1548316107
##
pinot-connectors/pinot-flink-connector/pom.xml:
##
@@ -51,7 +51,18 @@
org.apache.flink
- flink-streaming-java_${scala.compat.version}
+ f
snleee commented on code in PR #12659:
URL: https://github.com/apache/pinot/pull/12659#discussion_r1548315118
##
pinot-connectors/pinot-flink-connector/pom.xml:
##
@@ -51,7 +51,18 @@
org.apache.flink
- flink-streaming-java_${scala.compat.version}
Review
jackjlli commented on PR #12764:
URL: https://github.com/apache/pinot/pull/12764#issuecomment-2032666868
Not just the test code which will invoke the real logic, in fact a lot of
companies will invoke the handleRequest() method with their own ways.
> I have handled this at [test side
Jackie-Jiang commented on code in PR #12772:
URL: https://github.com/apache/pinot/pull/12772#discussion_r1548258565
##
pom.xml:
##
@@ -1759,7 +1774,6 @@
commons-logging:commons-logging
Review Comment:
It is needed. We want to ex
satishd commented on PR #12538:
URL: https://github.com/apache/pinot/pull/12538#issuecomment-2032592795
>@satishd I guess you mean collision between two primary keys where one is
UUID conformant and the other is not?
Right.
>Unless we prepend the length of the string in the UUI
Jackie-Jiang merged PR #12771:
URL: https://github.com/apache/pinot/pull/12771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 3695bed80d Upgrade Calcite to 1.36.0 (#12754)
add 3badec56d7 Remove unused jcabi-log dependency (#12771)
No new r
Jackie-Jiang commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1548253609
##
pinot-common/src/main/java/org/apache/pinot/common/datatable/StatMap.java:
##
@@ -0,0 +1,759 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
shounakmk219 commented on code in PR #12765:
URL: https://github.com/apache/pinot/pull/12765#discussion_r1548240789
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotDatabaseRestletResource.java:
##
@@ -59,4 +67,91 @@ public class PinotDatabaseRest
klsince commented on code in PR #12772:
URL: https://github.com/apache/pinot/pull/12772#discussion_r1548231676
##
pom.xml:
##
@@ -1759,7 +1774,6 @@
commons-logging:commons-logging
Review Comment:
this comment seems not needed to
Jackie-Jiang merged PR #12754:
URL: https://github.com/apache/pinot/pull/12754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 4abb2d18f7 Set column major builder to be on by default (#12770)
add 3695bed80d Upgrade Calcite to 1.36.0 (#12754)
gortiz commented on code in PR #12765:
URL: https://github.com/apache/pinot/pull/12765#discussion_r1548226272
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotDatabaseRestletResource.java:
##
@@ -59,4 +67,91 @@ public class PinotDatabaseRestletRes
sullis opened a new pull request, #12777:
URL: https://github.com/apache/pinot/pull/12777
https://github.com/jacoco/jacoco/releases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
abhioncbr commented on issue #12155:
URL: https://github.com/apache/pinot/issues/12155#issuecomment-2032518517
@dttung2905 you can work on this. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
codecov-commenter commented on PR #12776:
URL: https://github.com/apache/pinot/pull/12776#issuecomment-2032077594
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12776?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
shounakmk219 commented on code in PR #12766:
URL: https://github.com/apache/pinot/pull/12766#discussion_r1547812702
##
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java:
##
@@ -587,64 +587,66 @@ public void fixSchemaNameInTableConfig() {
aw381246 commented on issue #12429:
URL: https://github.com/apache/pinot/issues/12429#issuecomment-2031945191
If you group by the same column that is in the distinctcount, every row in
the result should have a distinctcount of 1. The only reason pinot is
returning a value greater than 1 is
sullis opened a new pull request, #12776:
URL: https://github.com/apache/pinot/pull/12776
use static TypeReference object in MinionClient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
satishd commented on code in PR #12538:
URL: https://github.com/apache/pinot/pull/12538#discussion_r1547180230
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java:
##
@@ -44,8 +73,31 @@ public static Object hashPrimaryKey(PrimaryKey primaryKe
shounakmk219 commented on code in PR #12765:
URL: https://github.com/apache/pinot/pull/12765#discussion_r1547716136
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotDatabaseRestletResource.java:
##
@@ -59,4 +67,75 @@ public class PinotDatabaseRest
sullis commented on code in PR #12750:
URL: https://github.com/apache/pinot/pull/12750#discussion_r1547698734
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/AdminConsoleIntegrationTest.java:
##
@@ -90,4 +91,29 @@ public void testApiHelp()
respon
gortiz commented on code in PR #12765:
URL: https://github.com/apache/pinot/pull/12765#discussion_r1547450666
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotDatabaseRestletResource.java:
##
@@ -59,4 +67,75 @@ public class PinotDatabaseRestletRes
tibrewalpratik17 commented on issue #12458:
URL: https://github.com/apache/pinot/issues/12458#issuecomment-2031438550
Please assign to me. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hpvd commented on issue #12713:
URL: https://github.com/apache/pinot/issues/12713#issuecomment-2031408685
fyi: v3.2.2 was just released, including some client fixes:
https://github.com/apache/pulsar/releases/tag/v3.2.2
--
This is an automated message from the Apache Git Service.
To resp
Jackie-Jiang commented on code in PR #12750:
URL: https://github.com/apache/pinot/pull/12750#discussion_r1547318510
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/AdminConsoleIntegrationTest.java:
##
@@ -90,4 +91,29 @@ public void testApiHelp()
Jackie-Jiang commented on issue #3163:
URL: https://github.com/apache/pinot/issues/3163#issuecomment-2031294826
Can be solved by adjusting the ZK setting (documented
[here](https://docs.pinot.apache.org/reference/troubleshooting/troubleshoot-zookeeper#adjust-zookeeper-znode-size))
--
This
Jackie-Jiang closed issue #3163: helix idealstate zk node size limitation with
large pinot table
URL: https://github.com/apache/pinot/issues/3163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Jackie-Jiang commented on issue #2088:
URL: https://github.com/apache/pinot/issues/2088#issuecomment-2031293714
This problem can be solved by adjusting the ZK settings (documented
[here](https://docs.pinot.apache.org/reference/troubleshooting/troubleshoot-zookeeper#adjust-zookeeper-znode-siz
Jackie-Jiang closed issue #2088: Too many segments in a table caused entire
cluster ingestion hanging
URL: https://github.com/apache/pinot/issues/2088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 08fc2c7d62 upgrade lmax disruptor to 4.0.0 (#12769)
add 4abb2d18f7 Set column major builder to be on by default (#
Jackie-Jiang merged PR #12770:
URL: https://github.com/apache/pinot/pull/12770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
ankitsultana commented on PR #12538:
URL: https://github.com/apache/pinot/pull/12538#issuecomment-2031252530
@satishd : yeah just to be clear, I had meant collision between keys that
don't conform to UUID format.
> @ankitsultana If any of the values is not of type UUID and hash functi
69 matches
Mail list logo
